interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

NOR/CFI: fix order of arguments check 

Syntax of "flash bank" command requires:
- chip_width as CMD_ARGV[3]
- bus_width  as CMD_ARGV[4]
Actual code swaps the arguments.
Bug has no run time impact since wrong variables
are only used to check value and both are checked
against same constraint.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
This commit is contained in:
Antonio Borneo 2010-04-14 16:32:30 +08:00 committed by Øyvind Harboe
parent ee13916411
commit c9e58238c3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/flash/nor/cfi.c
View File

@ -599,8 +599,8 @@ FLASH_BANK_COMMAND_HANDLER(cfi_flash_bank_command)
}
uint16_t chip_width, bus_width;
COMMAND_PARSE_NUMBER(u16, CMD_ARGV[3], bus_width);
COMMAND_PARSE_NUMBER(u16, CMD_ARGV[4], chip_width);
COMMAND_PARSE_NUMBER(u16, CMD_ARGV[3], chip_width);
COMMAND_PARSE_NUMBER(u16, CMD_ARGV[4], bus_width);
if ((chip_width > CFI_MAX_CHIP_WIDTH)
|| (bus_width > CFI_MAX_BUS_WIDTH))