interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

server/gdb: Use 'bool' data type where appropriate 

Change-Id: Ic23c5469334337963185b69fcabeedf70c2c7ae9
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: https://review.openocd.org/c/openocd/+/8253
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Tested-by: jenkins
This commit is contained in:
Marc Schink 2024-05-03 09:18:00 +02:00 committed by Antonio Borneo
parent 2506ccb509
commit c831758ea4
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/server/gdb_server.c
View File

@ -128,9 +128,9 @@ static int gdb_actual_connections;
/* set if we are sending a memory map to gdb /* set if we are sending a memory map to gdb
* via qXfer:memory-map:read packet */ * via qXfer:memory-map:read packet */
/* enabled by default*/ /* enabled by default*/
static int gdb_use_memory_map = 1; static bool gdb_use_memory_map = true;
/* enabled by default*/ /* enabled by default*/
static int gdb_flash_program = 1; static bool gdb_flash_program = true;
/* if set, data aborts cause an error to be reported in memory read packets /* if set, data aborts cause an error to be reported in memory read packets
* see the code in gdb_read_memory_packet() for further explanations. * see the code in gdb_read_memory_packet() for further explanations.
@ -144,7 +144,7 @@ static int gdb_report_register_access_error;
/* set if we are sending target descriptions to gdb /* set if we are sending target descriptions to gdb
* via qXfer:features:read packet */ * via qXfer:features:read packet */
/* enabled by default */ /* enabled by default */
static int gdb_use_target_description = 1; static bool gdb_use_target_description = true;
/* current processing free-run type, used by file-I/O */ /* current processing free-run type, used by file-I/O */
static char gdb_running_type; static char gdb_running_type;
@ -2599,7 +2599,7 @@ static int gdb_get_target_description_chunk(struct target *target, struct target
return ERROR_OK; return ERROR_OK;
} }
static int gdb_target_description_supported(struct target *target, int *supported) static int gdb_target_description_supported(struct target *target, bool *supported)
{ {
int retval = ERROR_OK; int retval = ERROR_OK;
struct reg **reg_list = NULL; struct reg **reg_list = NULL;
@ -2631,9 +2631,9 @@ static int gdb_target_description_supported(struct target *target, int *supporte
if (supported) { if (supported) {
if (architecture || feature_list_size) if (architecture || feature_list_size)
*supported = 1; *supported = true;
else else
*supported = 0; *supported = false;
} }
error: error:
@ -2867,20 +2867,20 @@ static int gdb_query_packet(struct connection *connection,
char *buffer = NULL; char *buffer = NULL;
int pos = 0; int pos = 0;
int size = 0; int size = 0;
int gdb_target_desc_supported = 0; bool gdb_target_desc_supported = false;
/* we need to test that the target supports target descriptions */ /* we need to test that the target supports target descriptions */
retval = gdb_target_description_supported(target, &gdb_target_desc_supported); retval = gdb_target_description_supported(target, &gdb_target_desc_supported);
if (retval != ERROR_OK) { if (retval != ERROR_OK) {
LOG_INFO("Failed detecting Target Description Support, disabling"); LOG_INFO("Failed detecting Target Description Support, disabling");
gdb_target_desc_supported = 0; gdb_target_desc_supported = false;
} }
/* support may be disabled globally */ /* support may be disabled globally */
if (gdb_use_target_description == 0) { if (!gdb_use_target_description) {
if (gdb_target_desc_supported) if (gdb_target_desc_supported)
LOG_WARNING("Target Descriptions Supported, but disabled"); LOG_WARNING("Target Descriptions Supported, but disabled");
gdb_target_desc_supported = 0; gdb_target_desc_supported = false;
} }
xml_printf(&retval, xml_printf(&retval,
@ -2889,8 +2889,8 @@ static int gdb_query_packet(struct connection *connection,
&size, &size,
"PacketSize=%x;qXfer:memory-map:read%c;qXfer:features:read%c;qXfer:threads:read+;QStartNoAckMode+;vContSupported+", "PacketSize=%x;qXfer:memory-map:read%c;qXfer:features:read%c;qXfer:threads:read+;QStartNoAckMode+;vContSupported+",
GDB_BUFFER_SIZE, GDB_BUFFER_SIZE,
((gdb_use_memory_map == 1) && (flash_get_bank_count() > 0)) ? '+' : '-', (gdb_use_memory_map && (flash_get_bank_count() > 0)) ? '+' : '-',
(gdb_target_desc_supported == 1) ? '+' : '-'); gdb_target_desc_supported ? '+' : '-');
if (retval != ERROR_OK) { if (retval != ERROR_OK) {
gdb_send_error(connection, 01); gdb_send_error(connection, 01);
@ -3280,7 +3280,7 @@ static int gdb_v_packet(struct connection *connection,
/* if flash programming disabled - send a empty reply */ /* if flash programming disabled - send a empty reply */
if (gdb_flash_program == 0) { if (!gdb_flash_program) {
gdb_put_packet(connection, "", 0); gdb_put_packet(connection, "", 0);
return ERROR_OK; return ERROR_OK;
} }