interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

flash/nor/stellaris: actually enable protection and unprotection with ICDI 

This is still limited to pre-Snowflake parts and the first 64K of
flash.

Change-Id: I9ca872ada3d1a87dba6261464b2a72a15eda5ecf
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/2264
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
This commit is contained in:
Paul Fertser 2014-08-19 21:54:31 +04:00 committed by Spencer Oliver
parent 1f6a66ab7f
commit b631e78b25
1 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/flash/nor/stellaris.c
View File

@ -950,6 +950,13 @@ static int stellaris_protect(struct flash_bank *bank, int set, int first, int la
if (stellaris_info->did1 == 0) if (stellaris_info->did1 == 0)
return ERROR_FLASH_BANK_NOT_PROBED; return ERROR_FLASH_BANK_NOT_PROBED;
if (stellaris_info->target_class == 0x03 &&
!((stellaris_info->did0 >> 8) & 0xFF) &&
!((stellaris_info->did0) & 0xFF)) {
LOG_ERROR("DustDevil A0 parts can't be unprotected, see errata; refusing to proceed");
return ERROR_FLASH_OPERATION_FAILED;
}
if (stellaris_info->target_class == 0xa) { if (stellaris_info->target_class == 0xa) {
LOG_ERROR("Protection on Snowflake is not supported yet"); LOG_ERROR("Protection on Snowflake is not supported yet");
return ERROR_FLASH_OPERATION_FAILED; return ERROR_FLASH_OPERATION_FAILED;
@ -997,15 +1004,8 @@ static int stellaris_protect(struct flash_bank *bank, int set, int first, int la
/* Commit FMPPE */ /* Commit FMPPE */
target_write_u32(target, FLASH_FMA, 1); target_write_u32(target, FLASH_FMA, 1);
/* Write commit command */ /* Write commit command */
/* REVISIT safety check, since this cannot be undone target_write_u32(target, FLASH_FMC, FMC_WRKEY | FMC_COMT);
* except by the "Recover a locked device" procedure.
* REVISIT DustDevil-A0 parts have an erratum making FMPPE commits
* inadvisable ... it makes future mass erase operations fail.
*/
LOG_WARNING("Flash protection cannot be removed once committed, commit is NOT executed !");
/* target_write_u32(target, FLASH_FMC, FMC_WRKEY | FMC_COMT); */
/* Wait until erase complete */ /* Wait until erase complete */
do { do {
@ -1392,6 +1392,12 @@ COMMAND_HANDLER(stellaris_handle_recover_command)
* cycle to recover. * cycle to recover.
*/ */
Jim_Eval_Named(CMD_CTX->interp, "catch { hla_command \"debug unlock\" }", 0, 0);
if (!strcmp(Jim_GetString(Jim_GetResult(CMD_CTX->interp), NULL), "0")) {
retval = ERROR_OK;
goto user_action;
}
/* assert SRST */ /* assert SRST */
if (!(jtag_get_reset_config() & RESET_HAS_SRST)) { if (!(jtag_get_reset_config() & RESET_HAS_SRST)) {
LOG_ERROR("Can't recover Stellaris flash without SRST"); LOG_ERROR("Can't recover Stellaris flash without SRST");
@ -1416,6 +1422,7 @@ COMMAND_HANDLER(stellaris_handle_recover_command)
/* wait 400+ msec ... OK, "1+ second" is simpler */ /* wait 400+ msec ... OK, "1+ second" is simpler */
usleep(1000); usleep(1000);
user_action:
/* USER INTERVENTION required for the power cycle /* USER INTERVENTION required for the power cycle
* Restarting OpenOCD is likely needed because of mode switching. * Restarting OpenOCD is likely needed because of mode switching.
*/ */