interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Factoring of jtag_examine_chain for maintainability: 

- Limit scope: move tap and bit_count variables to point of first use.


git-svn-id: svn://svn.berlios.de/openocd/trunk@2090 b42882b7-edfa-0310-969c-e2dbd0fdcd60
This commit is contained in:
zwelch 2009-06-07 05:24:20 +00:00
parent 63c4848d11
commit b550f70100
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/jtag/jtag.c
View File

@ -1064,9 +1064,7 @@ static bool jtag_examine_chain_match_tap(const struct jtag_tap_s *tap)
*/ */
static int jtag_examine_chain(void) static int jtag_examine_chain(void)
{ {
jtag_tap_t *tap;
u8 idcode_buffer[JTAG_MAX_CHAIN_SIZE * 4]; u8 idcode_buffer[JTAG_MAX_CHAIN_SIZE * 4];
int bit_count;
int device_count = 0; int device_count = 0;
jtag_examine_chain_execute(idcode_buffer, JTAG_MAX_CHAIN_SIZE); jtag_examine_chain_execute(idcode_buffer, JTAG_MAX_CHAIN_SIZE);
@ -1075,14 +1073,14 @@ static int jtag_examine_chain(void)
return ERROR_JTAG_INIT_FAILED; return ERROR_JTAG_INIT_FAILED;
/* point at the 1st tap */ /* point at the 1st tap */
tap = jtag_tap_next_enabled(NULL); jtag_tap_t *tap = jtag_tap_next_enabled(NULL);
if (tap == NULL) if (tap == NULL)
{ {
LOG_ERROR("JTAG: No taps enabled?"); LOG_ERROR("JTAG: No taps enabled?");
return ERROR_JTAG_INIT_FAILED; return ERROR_JTAG_INIT_FAILED;
} }
for (bit_count = 0; bit_count < (JTAG_MAX_CHAIN_SIZE * 32) - 31;) for (unsigned bit_count = 0; bit_count < (JTAG_MAX_CHAIN_SIZE * 32) - 31;)
{ {
u32 idcode = buf_get_u32(idcode_buffer, bit_count, 32); u32 idcode = buf_get_u32(idcode_buffer, bit_count, 32);
if ((idcode & 1) == 0) if ((idcode & 1) == 0)