interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

target: use boolean values for 'valid' and 'dirty' flags 

Convert to boolean the remaining numeric assignment and comparison

Change-Id: Idc25221d93e85236185aab9ee36f0a379939c89c
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7961
Reviewed-by: zapb <dev@zapb.de>
Tested-by: jenkins
This commit is contained in:
Antonio Borneo 2023-11-05 12:55:27 +01:00
parent 5587710c1a
commit b39072f2ef
4 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/target/arc.c
View File

@ -1265,8 +1265,8 @@ static int arc_resume(struct target *target, int current, target_addr_t address,
/* current = 1: continue on current PC, otherwise continue at <address> */ /* current = 1: continue on current PC, otherwise continue at <address> */
if (!current) { if (!current) {
target_buffer_set_u32(target, pc->value, address); target_buffer_set_u32(target, pc->value, address);
pc->dirty = 1; pc->dirty = true;
pc->valid = 1; pc->valid = true;
LOG_DEBUG("Changing the value of current PC to 0x%08" TARGET_PRIxADDR, address); LOG_DEBUG("Changing the value of current PC to 0x%08" TARGET_PRIxADDR, address);
} }
@ -1281,7 +1281,7 @@ static int arc_resume(struct target *target, int current, target_addr_t address,
resume_pc, pc->dirty, pc->valid); resume_pc, pc->dirty, pc->valid);
/* check if GDB tells to set our PC where to continue from */ /* check if GDB tells to set our PC where to continue from */
if ((pc->valid == 1) && (resume_pc == target_buffer_get_u32(target, pc->value))) { if (pc->valid && resume_pc == target_buffer_get_u32(target, pc->value)) {
value = target_buffer_get_u32(target, pc->value); value = target_buffer_get_u32(target, pc->value);
LOG_DEBUG("resume Core (when start-core) with PC @:0x%08" PRIx32, value); LOG_DEBUG("resume Core (when start-core) with PC @:0x%08" PRIx32, value);
CHECK_RETVAL(arc_jtag_write_aux_reg_one(&arc->jtag_info, AUX_PC_REG, value)); CHECK_RETVAL(arc_jtag_write_aux_reg_one(&arc->jtag_info, AUX_PC_REG, value));
@ -2007,8 +2007,8 @@ static int arc_step(struct target *target, int current, target_addr_t address,
/* current = 1: continue on current pc, otherwise continue at <address> */ /* current = 1: continue on current pc, otherwise continue at <address> */
if (!current) { if (!current) {
buf_set_u32(pc->value, 0, 32, address); buf_set_u32(pc->value, 0, 32, address);
pc->dirty = 1; pc->dirty = true;
pc->valid = 1; pc->valid = true;
} }
LOG_DEBUG("Target steps one instruction from PC=0x%" PRIx32, LOG_DEBUG("Target steps one instruction from PC=0x%" PRIx32,

4
src/target/etm.c
View File

@ -552,8 +552,8 @@ static int etm_set_reg(struct reg *reg, uint32_t value)
} }
buf_set_u32(reg->value, 0, reg->size, value); buf_set_u32(reg->value, 0, reg->size, value);
reg->valid = 1; reg->valid = true;
reg->dirty = 0; reg->dirty = false;
return ERROR_OK; return ERROR_OK;
} }

16
src/target/mips64.c
View File

@ -247,8 +247,8 @@ static int mips64_set_core_reg(struct reg *reg, uint8_t *buf)
return ERROR_TARGET_NOT_HALTED; return ERROR_TARGET_NOT_HALTED;
buf_set_u64(reg->value, 0, 64, value); buf_set_u64(reg->value, 0, 64, value);
reg->dirty = 1; reg->dirty = true;
reg->valid = 1; reg->valid = true;
return ERROR_OK; return ERROR_OK;
} }
@ -265,8 +265,8 @@ static int mips64_read_core_reg(struct target *target, int num)
reg_value = mips64->core_regs[num]; reg_value = mips64->core_regs[num];
buf_set_u64(mips64->core_cache->reg_list[num].value, 0, 64, reg_value); buf_set_u64(mips64->core_cache->reg_list[num].value, 0, 64, reg_value);
mips64->core_cache->reg_list[num].valid = 1; mips64->core_cache->reg_list[num].valid = true;
mips64->core_cache->reg_list[num].dirty = 0; mips64->core_cache->reg_list[num].dirty = false;
return ERROR_OK; return ERROR_OK;
} }
@ -284,8 +284,8 @@ static int mips64_write_core_reg(struct target *target, int num)
reg_value = buf_get_u64(mips64->core_cache->reg_list[num].value, 0, 64); reg_value = buf_get_u64(mips64->core_cache->reg_list[num].value, 0, 64);
mips64->core_regs[num] = reg_value; mips64->core_regs[num] = reg_value;
LOG_DEBUG("write core reg %i value 0x%" PRIx64 "", num, reg_value); LOG_DEBUG("write core reg %i value 0x%" PRIx64 "", num, reg_value);
mips64->core_cache->reg_list[num].valid = 1; mips64->core_cache->reg_list[num].valid = true;
mips64->core_cache->reg_list[num].dirty = 0; mips64->core_cache->reg_list[num].dirty = false;
return ERROR_OK; return ERROR_OK;
} }
@ -297,8 +297,8 @@ int mips64_invalidate_core_regs(struct target *target)
unsigned int i; unsigned int i;
for (i = 0; i < mips64->core_cache->num_regs; i++) { for (i = 0; i < mips64->core_cache->num_regs; i++) {
mips64->core_cache->reg_list[i].valid = 0; mips64->core_cache->reg_list[i].valid = false;
mips64->core_cache->reg_list[i].dirty = 0; mips64->core_cache->reg_list[i].dirty = false;
} }
return ERROR_OK; return ERROR_OK;

8
src/target/mips_mips64.c
View File

@ -625,8 +625,8 @@ static int mips_mips64_resume(struct target *target, int current,
/* current = 1: continue on current pc, otherwise continue at <address> */ /* current = 1: continue on current pc, otherwise continue at <address> */
if (!current) { if (!current) {
buf_set_u64(pc->value, 0, 64, address); buf_set_u64(pc->value, 0, 64, address);
pc->dirty = 1; pc->dirty = true;
pc->valid = 1; pc->valid = true;
} }
resume_pc = buf_get_u64(pc->value, 0, 64); resume_pc = buf_get_u64(pc->value, 0, 64);
@ -717,8 +717,8 @@ static int mips_mips64_step(struct target *target, int current,
* <address> */ * <address> */
if (!current) { if (!current) {
buf_set_u64(pc->value, 0, 64, address); buf_set_u64(pc->value, 0, 64, address);
pc->dirty = 1; pc->dirty = true;
pc->valid = 1; pc->valid = true;
} }
/* the front-end may request us not to handle breakpoints */ /* the front-end may request us not to handle breakpoints */