interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

config files: Drop incorrect comments. 

There are many "force an error till we get a good number" comments in
target/board files. This refers to the use-case where a config script
sets _CPUTAPID to 0xffffffff (which presumely gets overridden later):

 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
    # Force an error until we get a good number.
    set _CPUTAPID 0xffffffff
 }

However, the same comment was also copy-pasted in many files which do
_not_ set _CPUTAPID to 0xffffffff, where the comment doesn't make any
sense at all. Drop those comments. Also, add one missing comment, and
fix small whitespace and grammar issues.

Change-Id: Ic4ba3b5ccba87ed40cea0d6a7d66609fbdfa3c71
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Reviewed-on: http://openocd.zylin.com/136
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
This commit is contained in:
Uwe Hermann 2011-10-29 22:58:12 +02:00 committed by Peter Stuge
parent fe2fd812fa
commit abfd4b19a6
18 changed files with 4 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tcl/board/at91eb40a.cfg
View File

@ -19,7 +19,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x1f0f0f0f set _CPUTAPID 0x1f0f0f0f
} }

1
tcl/board/mini2440.cfg
View File

@ -100,7 +100,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x0032409d set _CPUTAPID 0x0032409d
} }

2
tcl/target/at91sam7se512.cfg
View File

@ -18,7 +18,7 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number # Force an error until we get a good number.
set _CPUTAPID 0xffffffff set _CPUTAPID 0xffffffff
} }

2
tcl/target/at91sam9.cfg
View File

@ -17,13 +17,11 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x0792603f set _CPUTAPID 0x0792603f
} }
reset_config trst_and_srst separate trst_push_pull srst_open_drain reset_config trst_and_srst separate trst_push_pull srst_open_drain
#
jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x1 -irmask 0xf -expected-id $_CPUTAPID jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x1 -irmask 0xf -expected-id $_CPUTAPID
adapter_nsrst_delay 300 adapter_nsrst_delay 300

1
tcl/target/avr32.cfg
View File

@ -1,7 +1,6 @@
set _CHIPNAME avr32 set _CHIPNAME avr32
set _ENDIAN big set _ENDIAN big
# force an error till we get a good number
set _CPUTAPID 0x21e8203f set _CPUTAPID 0x21e8203f
jtag_nsrst_delay 100 jtag_nsrst_delay 100

1
tcl/target/dsp56321.cfg
View File

@ -17,7 +17,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x1181501d set _CPUTAPID 0x1181501d
} }

1
tcl/target/dsp568013.cfg
View File

@ -16,7 +16,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x01f2401d set _CPUTAPID 0x01f2401d
} }

1
tcl/target/dsp568037.cfg
View File

@ -16,7 +16,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x01f2801d set _CPUTAPID 0x01f2801d
} }

2
tcl/target/epc9301.cfg
View File

@ -15,7 +15,7 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number # Force an error until we get a good number.
set _CPUTAPID 0xffffffff set _CPUTAPID 0xffffffff
} }

2
tcl/target/is5114.cfg
View File

@ -18,7 +18,7 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number # Force an error until we get a good number.
set _CPUTAPID 0xffffffff set _CPUTAPID 0xffffffff
} }

1
tcl/target/pic32mx.cfg
View File

@ -14,7 +14,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x30938053 set _CPUTAPID 0x30938053
} }

1
tcl/target/samsung_s3c2410.cfg
View File

@ -16,6 +16,7 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID] } { if { [info exists CPUTAPID] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# Force an error until we get a good number.
set _CPUTAPID 0xffffffff set _CPUTAPID 0xffffffff
} }

1
tcl/target/samsung_s3c2440.cfg
View File

@ -19,7 +19,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x0032409d set _CPUTAPID 0x0032409d
} }

1
tcl/target/samsung_s3c2450.cfg
View File

@ -29,7 +29,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x07926f0f set _CPUTAPID 0x07926f0f
} }

2
tcl/target/samsung_s3c6410.cfg
View File

@ -23,14 +23,12 @@ if { [info exists ENDIAN] } {
if { [info exists ETBTAPID ] } { if { [info exists ETBTAPID ] } {
set _ETBTAPID $ETBTAPID set _ETBTAPID $ETBTAPID
} else { } else {
# force an error till we get a good number
set _ETBTAPID 0x2b900f0f set _ETBTAPID 0x2b900f0f
} }
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x07b76f0f set _CPUTAPID 0x07b76f0f
} }

1
tcl/target/smp8634.cfg
View File

@ -15,7 +15,6 @@ if { [info exists ENDIAN] } {
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x08630001 set _CPUTAPID 0x08630001
} }

1
tcl/target/tmpa900.cfg
View File

@ -14,7 +14,6 @@ set _ENDIAN little
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x07926031 set _CPUTAPID 0x07926031
} }

1
tcl/target/tmpa910.cfg
View File

@ -14,7 +14,6 @@ set _ENDIAN little
if { [info exists CPUTAPID ] } { if { [info exists CPUTAPID ] } {
set _CPUTAPID $CPUTAPID set _CPUTAPID $CPUTAPID
} else { } else {
# force an error till we get a good number
set _CPUTAPID 0x07926031 set _CPUTAPID 0x07926031
} }