interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

target: Make profiling function more readable 

Change variable name 'length' to 'numBuckets'.  It is more readable.

Change-Id: I913cba0746f887adf6da401a46cd5e9ea88d2c6d
Signed-off-by: Hsiangkai Wang <hsiangkai@gmail.com>
Reviewed-on: http://openocd.zylin.com/1606
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
This commit is contained in:
Hsiangkai Wang 2013-08-30 13:18:54 +08:00 committed by Spencer Oliver
parent cd0ef0cd3f
commit a4bacdcb84
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/target/target.c
View File

@ -3391,19 +3391,19 @@ static void writeGmon(uint32_t *samples, uint32_t sampleNum, const char *filenam
assert(addressSpace >= 2); assert(addressSpace >= 2);
static const uint32_t maxBuckets = 16 * 1024; /* maximum buckets. */ static const uint32_t maxBuckets = 16 * 1024; /* maximum buckets. */
uint32_t length = addressSpace; uint32_t numBuckets = addressSpace;
if (length > maxBuckets) if (numBuckets > maxBuckets)
length = maxBuckets; numBuckets = maxBuckets;
int *buckets = malloc(sizeof(int)*length); int *buckets = malloc(sizeof(int) * numBuckets);
if (buckets == NULL) { if (buckets == NULL) {
fclose(f); fclose(f);
return; return;
} }
memset(buckets, 0, sizeof(int) * length); memset(buckets, 0, sizeof(int) * numBuckets);
for (i = 0; i < sampleNum; i++) { for (i = 0; i < sampleNum; i++) {
uint32_t address = samples[i]; uint32_t address = samples[i];
long long a = address - min; long long a = address - min;
long long b = length - 1; long long b = numBuckets - 1;
long long c = addressSpace - 1; long long c = addressSpace - 1;
int index_t = (a * b) / c; /* danger!!!! int32 overflows */ int index_t = (a * b) / c; /* danger!!!! int32 overflows */
buckets[index_t]++; buckets[index_t]++;
@ -3412,7 +3412,7 @@ static void writeGmon(uint32_t *samples, uint32_t sampleNum, const char *filenam
/* append binary memory gmon.out &profile_hist_hdr ((char*)&profile_hist_hdr + sizeof(struct gmon_hist_hdr)) */ /* append binary memory gmon.out &profile_hist_hdr ((char*)&profile_hist_hdr + sizeof(struct gmon_hist_hdr)) */
writeLong(f, min); /* low_pc */ writeLong(f, min); /* low_pc */
writeLong(f, max); /* high_pc */ writeLong(f, max); /* high_pc */
writeLong(f, length); /* # of samples */ writeLong(f, numBuckets); /* # of buckets */
writeLong(f, 100); /* KLUDGE! We lie, ca. 100Hz best case. */ writeLong(f, 100); /* KLUDGE! We lie, ca. 100Hz best case. */
writeString(f, "seconds"); writeString(f, "seconds");
for (i = 0; i < (15-strlen("seconds")); i++) for (i = 0; i < (15-strlen("seconds")); i++)
@ -3421,9 +3421,9 @@ static void writeGmon(uint32_t *samples, uint32_t sampleNum, const char *filenam
/*append binary memory gmon.out profile_hist_data (profile_hist_data + profile_hist_hdr.hist_size) */ /*append binary memory gmon.out profile_hist_data (profile_hist_data + profile_hist_hdr.hist_size) */
char *data = malloc(2 * length); char *data = malloc(2 * numBuckets);
if (data != NULL) { if (data != NULL) {
for (i = 0; i < length; i++) { for (i = 0; i < numBuckets; i++) {
int val; int val;
val = buckets[i]; val = buckets[i];
if (val > 65535) if (val > 65535)
@ -3432,7 +3432,7 @@ static void writeGmon(uint32_t *samples, uint32_t sampleNum, const char *filenam
data[i * 2 + 1] = (val >> 8) & 0xff; data[i * 2 + 1] = (val >> 8) & 0xff;
} }
free(buckets); free(buckets);
writeData(f, data, length * 2); writeData(f, data, numBuckets * 2);
free(data); free(data);
} else } else
free(buckets); free(buckets);