interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

openrisc: Fix segv jsp due to free of unallocated data 

The prompt pointer in the jtag serial port is never zero'd or allocated.
Completely remove it since there is not much use for it as the target
software will provide the actual prompt.

Change-Id: Id95d8ccb9f725e53b9d03386b11d91eba1cd6ef4
Signed-off-by: Stafford Horne <shorne@gmail.com>
Reviewed-on: http://openocd.zylin.com/4093
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
This commit is contained in:
Stafford Horne 2017-04-05 06:11:30 +09:00 committed by Antonio Borneo
parent f788949651
commit a098a14eb5
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/target/openrisc/jsp_server.c
View File

@ -184,14 +184,8 @@ static int jsp_input(struct connection *connection)
static int jsp_connection_closed(struct connection *connection) static int jsp_connection_closed(struct connection *connection)
{ {
struct telnet_connection *t_con = connection->priv;
struct jsp_service *jsp_service = connection->service->priv; struct jsp_service *jsp_service = connection->service->priv;
if (t_con->prompt) {
free(t_con->prompt);
t_con->prompt = NULL;
}
int retval = target_unregister_timer_callback(&jsp_poll_read, jsp_service); int retval = target_unregister_timer_callback(&jsp_poll_read, jsp_service);
if (ERROR_OK != retval) if (ERROR_OK != retval)
return retval; return retval;