mx2: add error propagation and remove warnings

Change-Id: Idd4fb452790e5d7921a749679dbd865586e5a4a9
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/48
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
This commit is contained in:
Øyvind Harboe 2011-10-22 01:11:58 +02:00 committed by Øyvind Harboe
parent dad3850264
commit 9bb3a05f0e
1 changed files with 14 additions and 9 deletions

View File

@ -501,15 +501,20 @@ static int imx27_read_page(struct nand_device *nand, uint32_t page,
return retval; return retval;
} }
/* Reset address_cycles before imx27_command ?? */ /* Reset address_cycles before imx27_command ?? */
retval = ERROR_OK; retval = imx27_command(nand, NAND_CMD_READ0);
retval |= imx27_command(nand, NAND_CMD_READ0); if (retval != ERROR_OK) return retval;
retval = imx27_address(nand, 0); //col
retval |= imx27_address(nand, 0); //col if (retval != ERROR_OK) return retval;
retval |= imx27_address(nand, 0); //col retval = imx27_address(nand, 0); //col
retval |= imx27_address(nand, page & 0xff); //page address if (retval != ERROR_OK) return retval;
retval |= imx27_address(nand, (page >> 8) & 0xff); //page address retval = imx27_address(nand, page & 0xff); //page address
retval |= imx27_address(nand, (page >> 16) & 0xff); //page address if (retval != ERROR_OK) return retval;
retval |= imx27_command(nand, NAND_CMD_READSTART); retval = imx27_address(nand, (page >> 8) & 0xff); //page address
if (retval != ERROR_OK) return retval;
retval = imx27_address(nand, (page >> 16) & 0xff); //page address
if (retval != ERROR_OK) return retval;
retval = imx27_command(nand, NAND_CMD_READSTART);
if (retval != ERROR_OK) return retval;
target_write_u16(target, MX2_NF_BUFADDR, 0); target_write_u16(target, MX2_NF_BUFADDR, 0);
mx2_nf_info->fin = MX2_NF_FIN_DATAOUT; mx2_nf_info->fin = MX2_NF_FIN_DATAOUT;