interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Better handling of OpenOCD command invocation result/context. 

git-svn-id: svn://svn.berlios.de/openocd/trunk@866 b42882b7-edfa-0310-969c-e2dbd0fdcd60
This commit is contained in:
oharboe 2008-07-24 10:16:44 +00:00
parent 06d501a192
commit 91a16a3810
2 changed files with 54 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
src/helper/command.c
View File

@ -55,12 +55,15 @@ static void tcl_output(void *privData, const char *file, int line, const char *f
Jim_AppendString(interp, tclOutput, string, strlen(string)); Jim_AppendString(interp, tclOutput, string, strlen(string));
} }
extern command_context_t *global_cmd_ctx;
static int script_command(Jim_Interp *interp, int argc, Jim_Obj *const *argv) static int script_command(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
{ {
/* the private data is stashed in the interp structure */ /* the private data is stashed in the interp structure */
command_t *c; command_t *c;
command_context_t *context; command_context_t *context;
int *retval; int retval;
int i; int i;
int nwords; int nwords;
char **words; char **words;
@ -92,26 +95,40 @@ static int script_command(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
/* grab the command context from the associated data */ /* grab the command context from the associated data */
context = Jim_GetAssocData(interp, "context"); context = Jim_GetAssocData(interp, "context");
retval = Jim_GetAssocData(interp, "retval"); if (context == NULL)
if (context != NULL && retval != NULL)
{ {
/* Tcl can invoke commands directly instead of via command_run_line(). This would
* happen when the Jim Tcl interpreter is provided by eCos.
*/
context = global_cmd_ctx;
}
/* capture log output and return it */ /* capture log output and return it */
Jim_Obj *tclOutput = Jim_NewStringObj(interp, "", 0); Jim_Obj *tclOutput = Jim_NewStringObj(interp, "", 0);
/* a garbage collect can happen, so we need a reference count to this object */
Jim_IncrRefCount(tclOutput);
log_add_callback(tcl_output, tclOutput); log_add_callback(tcl_output, tclOutput);
*retval = run_command(context, c, words, nwords); retval = run_command(context, c, words, nwords);
log_remove_callback(tcl_output, tclOutput); log_remove_callback(tcl_output, tclOutput);
/* We dump output into this local variable */ /* We dump output into this local variable */
Jim_SetVariableStr(interp, "ocd_output", tclOutput); Jim_SetVariableStr(interp, "ocd_output", tclOutput);
} Jim_DecrRefCount(interp, tclOutput);
for (i = 0; i < nwords; i++) for (i = 0; i < nwords; i++)
free(words[i]); free(words[i]);
free(words); free(words);
return (*retval==ERROR_OK)?JIM_OK:JIM_ERR; int *return_retval = Jim_GetAssocData(interp, "retval");
if (return_retval != NULL)
{
*return_retval = retval;
}
return (retval==ERROR_OK)?JIM_OK:JIM_ERR;
} }
command_t* register_command(command_context_t *context, command_t *parent, char *name, int (*handler)(struct command_context_s *context, char* name, char** args, int argc), enum command_mode mode, char *help) command_t* register_command(command_context_t *context, command_t *parent, char *name, int (*handler)(struct command_context_s *context, char* name, char** args, int argc), enum command_mode mode, char *help)
@ -393,21 +410,28 @@ int command_run_line(command_context_t *context, char *line)
* results * results
*/ */
/* run the line thru a script engine */ /* run the line thru a script engine */
int retval; int retval=ERROR_FAIL;
int retcode; int retcode;
Jim_DeleteAssocData(interp, "context"); /* remove existing */ /* Beware! This code needs to be reentrant. It is also possible
* for OpenOCD commands to be invoked directly from Tcl. This would
* happen when the Jim Tcl interpreter is provided by eCos for
* instance.
*/
Jim_DeleteAssocData(interp, "context");
retcode = Jim_SetAssocData(interp, "context", NULL, context); retcode = Jim_SetAssocData(interp, "context", NULL, context);
if (retcode != JIM_OK) if (retcode == JIM_OK)
return ERROR_FAIL; {
/* associated the return value */ /* associated the return value */
retval = ERROR_OK; Jim_DeleteAssocData(interp, "retval");
Jim_DeleteAssocData(interp, "retval"); /* remove existing */
retcode = Jim_SetAssocData(interp, "retval", NULL, &retval); retcode = Jim_SetAssocData(interp, "retval", NULL, &retval);
if (retcode != JIM_OK) if (retcode == JIM_OK)
return ERROR_FAIL; {
retcode = Jim_Eval(interp, line); retcode = Jim_Eval(interp, line);
Jim_DeleteAssocData(interp, "retval");
}
Jim_DeleteAssocData(interp, "context");
}
if (retcode == JIM_ERR) { if (retcode == JIM_ERR) {
if (retval!=ERROR_COMMAND_CLOSE_CONNECTION) if (retval!=ERROR_COMMAND_CLOSE_CONNECTION)
{ {

4
src/openocd.c
View File

@ -131,11 +131,13 @@ int handle_init_command(struct command_context_s *cmd_ctx, char *cmd, char **arg
return ERROR_OK; return ERROR_OK;
} }
command_context_t *global_cmd_ctx;
command_context_t *setup_command_handler(void) command_context_t *setup_command_handler(void)
{ {
command_context_t *cmd_ctx; command_context_t *cmd_ctx;
cmd_ctx = command_init(); global_cmd_ctx = cmd_ctx = command_init();
register_command(cmd_ctx, NULL, "version", handle_version_command, register_command(cmd_ctx, NULL, "version", handle_version_command,
COMMAND_EXEC, "show OpenOCD version"); COMMAND_EXEC, "show OpenOCD version");