From 8bbbff185ff97102f7b0db4f1aee7f4d81a06e7d Mon Sep 17 00:00:00 2001 From: Antonio Borneo Date: Sat, 9 Sep 2023 09:24:59 +0200 Subject: [PATCH] flash: npcx: fix memory leak in npcx_flash_bank_command Recent commit 62f76b216930 ("flash/nor: add support for Nuvoton NPCX4/K3 series flash") introduces a memory leak for a missing free() on early return for an error. Add the free() on the return path on error. Change-Id: Ica8568a986802e23df2ab7bed4e8cc4bbb6305a5 Signed-off-by: Antonio Borneo Fixes: 62f76b216930 ("flash/nor: add support for Nuvoton NPCX4/K3 series flash") Reviewed-on: https://review.openocd.org/c/openocd/+/7894 Tested-by: jenkins Reviewed-by: Tomas Vanek --- src/flash/nor/npcx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/flash/nor/npcx.c b/src/flash/nor/npcx.c index 7304a6841..4a301f1e9 100644 --- a/src/flash/nor/npcx.c +++ b/src/flash/nor/npcx.c @@ -321,6 +321,7 @@ FLASH_BANK_COMMAND_HANDLER(npcx_flash_bank_command) npcx_bank->fiu_ver = NPCX_FIU_NPCK; } else { LOG_ERROR("%s is not a valid fiu", fiu); + free(npcx_bank); return ERROR_TARGET_INVALID; } }