interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Improve handle_dump_image_command argument parsing: 

- Use parse_u32 to ensure address and size parse properly.


git-svn-id: svn://svn.berlios.de/openocd/trunk@2233 b42882b7-edfa-0310-969c-e2dbd0fdcd60
This commit is contained in:
zwelch 2009-06-13 00:33:48 +00:00
parent bb37adadab
commit 890973acc4
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/target/target.c
View File

@ -2266,10 +2266,8 @@ static int handle_dump_image_command(struct command_context_s *cmd_ctx, char *cm
{ {
fileio_t fileio; fileio_t fileio;
u32 address;
u32 size;
u8 buffer[560]; u8 buffer[560];
int retval=ERROR_OK, retvaltemp; int retvaltemp;
duration_t duration; duration_t duration;
char *duration_text; char *duration_text;
@ -2282,8 +2280,15 @@ static int handle_dump_image_command(struct command_context_s *cmd_ctx, char *cm
return ERROR_OK; return ERROR_OK;
} }
address = strtoul(args[1], NULL, 0); u32 address;
size = strtoul(args[2], NULL, 0); int retval = parse_u32(args[1], &address);
if (ERROR_OK != retval)
return retval;
u32 size;
retval = parse_u32(args[2], &size);
if (ERROR_OK != retval)
return retval;
if (fileio_open(&fileio, args[0], FILEIO_WRITE, FILEIO_BINARY) != ERROR_OK) if (fileio_open(&fileio, args[0], FILEIO_WRITE, FILEIO_BINARY) != ERROR_OK)
{ {