interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mem_ap_read_u32 error propagation 

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This commit is contained in:
Øyvind Harboe 2010-07-19 13:50:28 +02:00
parent e7a1ec64bf
commit 7dcde11b45
2 changed files with 48 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/target/arm_adi_v5.c
View File

@ -1088,11 +1088,21 @@ static int dap_info_command(struct command_context *cmd_ctx,
command_print(cmd_ctx, "\tROM table in legacy format"); command_print(cmd_ctx, "\tROM table in legacy format");
/* Now we read ROM table ID registers, ref. ARM IHI 0029B sec */ /* Now we read ROM table ID registers, ref. ARM IHI 0029B sec */
mem_ap_read_u32(dap, (dbgbase&0xFFFFF000) | 0xFF0, &cid0); retval = mem_ap_read_u32(dap, (dbgbase&0xFFFFF000) | 0xFF0, &cid0);
mem_ap_read_u32(dap, (dbgbase&0xFFFFF000) | 0xFF4, &cid1); if (retval != ERROR_OK)
mem_ap_read_u32(dap, (dbgbase&0xFFFFF000) | 0xFF8, &cid2); return retval;
mem_ap_read_u32(dap, (dbgbase&0xFFFFF000) | 0xFFC, &cid3); retval = mem_ap_read_u32(dap, (dbgbase&0xFFFFF000) | 0xFF4, &cid1);
mem_ap_read_u32(dap, (dbgbase&0xFFFFF000) | 0xFCC, &memtype); if (retval != ERROR_OK)
return retval;
retval = mem_ap_read_u32(dap, (dbgbase&0xFFFFF000) | 0xFF8, &cid2);
if (retval != ERROR_OK)
return retval;
retval = mem_ap_read_u32(dap, (dbgbase&0xFFFFF000) | 0xFFC, &cid3);
if (retval != ERROR_OK)
return retval;
retval = mem_ap_read_u32(dap, (dbgbase&0xFFFFF000) | 0xFCC, &memtype);
if (retval != ERROR_OK)
return retval;
retval = dap_run(dap); retval = dap_run(dap);
if (retval != ERROR_OK) if (retval != ERROR_OK)
return retval; return retval;

44
src/target/cortex_m3.c
View File

@ -68,7 +68,9 @@ static int cortexm3_dap_read_coreregister_u32(struct adiv5_dap *swjdp,
/* because the DCB_DCRDR is used for the emulated dcc channel /* because the DCB_DCRDR is used for the emulated dcc channel
* we have to save/restore the DCB_DCRDR when used */ * we have to save/restore the DCB_DCRDR when used */
mem_ap_read_u32(swjdp, DCB_DCRDR, &dcrdr); retval = mem_ap_read_u32(swjdp, DCB_DCRDR, &dcrdr);
if (retval != ERROR_OK)
return retval;
/* mem_ap_write_u32(swjdp, DCB_DCRSR, regnum); */ /* mem_ap_write_u32(swjdp, DCB_DCRSR, regnum); */
retval = dap_setup_accessport(swjdp, CSW_32BIT | CSW_ADDRINC_OFF, DCB_DCRSR & 0xFFFFFFF0); retval = dap_setup_accessport(swjdp, CSW_32BIT | CSW_ADDRINC_OFF, DCB_DCRSR & 0xFFFFFFF0);
@ -107,7 +109,9 @@ static int cortexm3_dap_write_coreregister_u32(struct adiv5_dap *swjdp,
/* because the DCB_DCRDR is used for the emulated dcc channel /* because the DCB_DCRDR is used for the emulated dcc channel
* we have to save/restore the DCB_DCRDR when used */ * we have to save/restore the DCB_DCRDR when used */
mem_ap_read_u32(swjdp, DCB_DCRDR, &dcrdr); retval = mem_ap_read_u32(swjdp, DCB_DCRDR, &dcrdr);
if (retval != ERROR_OK)
return retval;
/* mem_ap_write_u32(swjdp, DCB_DCRDR, core_regs[i]); */ /* mem_ap_write_u32(swjdp, DCB_DCRDR, core_regs[i]); */
retval = dap_setup_accessport(swjdp, CSW_32BIT | CSW_ADDRINC_OFF, DCB_DCRDR & 0xFFFFFFF0); retval = dap_setup_accessport(swjdp, CSW_32BIT | CSW_ADDRINC_OFF, DCB_DCRDR & 0xFFFFFFF0);
@ -297,33 +301,51 @@ static int cortex_m3_examine_exception_reason(struct target *target)
struct adiv5_dap *swjdp = &armv7m->dap; struct adiv5_dap *swjdp = &armv7m->dap;
int retval; int retval;
mem_ap_read_u32(swjdp, NVIC_SHCSR, &shcsr); retval = mem_ap_read_u32(swjdp, NVIC_SHCSR, &shcsr);
if (retval != ERROR_OK)
return retval;
switch (armv7m->exception_number) switch (armv7m->exception_number)
{ {
case 2: /* NMI */ case 2: /* NMI */
break; break;
case 3: /* Hard Fault */ case 3: /* Hard Fault */
mem_ap_read_atomic_u32(swjdp, NVIC_HFSR, &except_sr); retval = mem_ap_read_atomic_u32(swjdp, NVIC_HFSR, &except_sr);
if (retval != ERROR_OK)
return retval;
if (except_sr & 0x40000000) if (except_sr & 0x40000000)
{ {
mem_ap_read_u32(swjdp, NVIC_CFSR, &cfsr); retval = mem_ap_read_u32(swjdp, NVIC_CFSR, &cfsr);
if (retval != ERROR_OK)
return retval;
} }
break; break;
case 4: /* Memory Management */ case 4: /* Memory Management */
mem_ap_read_u32(swjdp, NVIC_CFSR, &except_sr); retval = mem_ap_read_u32(swjdp, NVIC_CFSR, &except_sr);
mem_ap_read_u32(swjdp, NVIC_MMFAR, &except_ar); if (retval != ERROR_OK)
return retval;
retval = mem_ap_read_u32(swjdp, NVIC_MMFAR, &except_ar);
if (retval != ERROR_OK)
return retval;
break; break;
case 5: /* Bus Fault */ case 5: /* Bus Fault */
mem_ap_read_u32(swjdp, NVIC_CFSR, &except_sr); retval = mem_ap_read_u32(swjdp, NVIC_CFSR, &except_sr);
mem_ap_read_u32(swjdp, NVIC_BFAR, &except_ar); if (retval != ERROR_OK)
return retval;
retval = mem_ap_read_u32(swjdp, NVIC_BFAR, &except_ar);
if (retval != ERROR_OK)
return retval;
break; break;
case 6: /* Usage Fault */ case 6: /* Usage Fault */
mem_ap_read_u32(swjdp, NVIC_CFSR, &except_sr); retval = mem_ap_read_u32(swjdp, NVIC_CFSR, &except_sr);
if (retval != ERROR_OK)
return retval;
break; break;
case 11: /* SVCall */ case 11: /* SVCall */
break; break;
case 12: /* Debug Monitor */ case 12: /* Debug Monitor */
mem_ap_read_u32(swjdp, NVIC_DFSR, &except_sr); retval = mem_ap_read_u32(swjdp, NVIC_DFSR, &except_sr);
if (retval != ERROR_OK)
return retval;
break; break;
case 14: /* PendSV */ case 14: /* PendSV */
break; break;