interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

added comments w.r.t. potential performance problems 

git-svn-id: svn://svn.berlios.de/openocd/trunk@1663 b42882b7-edfa-0310-969c-e2dbd0fdcd60
This commit is contained in:
oharboe 2009-05-08 06:14:08 +00:00
parent f2676adb3c
commit 75f98d1649
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/target/arm7tdmi.c
View File

@ -372,6 +372,13 @@ void arm7tdmi_change_to_arm(target_t *target, u32 *r0, u32 *pc)
*pc -= 0xa; *pc -= 0xa;
} }
/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many
* roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s?
*
* The solution is to arrange for a large out/in scan in this loop and
* and convert data afterwards.
*/
void arm7tdmi_read_core_regs(target_t *target, u32 mask, u32* core_regs[16]) void arm7tdmi_read_core_regs(target_t *target, u32 mask, u32* core_regs[16])
{ {
int i; int i;

6
src/target/arm_adi_v5.c
View File

@ -867,6 +867,12 @@ int mem_ap_read_buf_u16(swjdp_common_t *swjdp, u8 *buffer, int count, u32 addres
return retval; return retval;
} }
/* FIX!!! is this a potential performance bottleneck w.r.t. requiring too many
* roundtrips when jtag_execute_queue() has a large overhead(e.g. for USB)s?
*
* The solution is to arrange for a large out/in scan in this loop and
* and convert data afterwards.
*/
int mem_ap_read_buf_packed_u8(swjdp_common_t *swjdp, u8 *buffer, int count, u32 address) int mem_ap_read_buf_packed_u8(swjdp_common_t *swjdp, u8 *buffer, int count, u32 address)
{ {
u32 invalue; u32 invalue;