interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

helper/command: simplify script_command_args_alloc() 

The output parameter nwords is always equal to the input parameter
argc, when the function succeeds.

Drop the parameter nwords and let the caller use directly the
value in argc.

While there, convert some 'unsigned' to 'unsigned int'.

Change-Id: Ie3d8ce1351792f3c07fe39cdcbcd180fd24dc928
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/8054
Tested-by: jenkins
This commit is contained in:
Antonio Borneo 2023-08-06 10:32:46 +02:00
parent 5e1468da18
commit 712c1244e8
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/helper/command.c
View File

@ -161,15 +161,13 @@ static void script_command_args_free(char **words, unsigned nwords)
free(words);
}
static char **script_command_args_alloc(
unsigned argc, Jim_Obj * const *argv, unsigned *nwords)
static char **script_command_args_alloc(unsigned int argc, Jim_Obj * const *argv)
{
char **words = malloc(argc * sizeof(char *));
if (!words)
return NULL;
unsigned i;
for (i = 0; i < argc; i++) {
for (unsigned int i = 0; i < argc; i++) {
const char *w = Jim_GetString(argv[i], NULL);
words[i] = strdup(w);
if (!words[i]) {
@ -177,7 +175,6 @@ static char **script_command_args_alloc(
return NULL;
}
}
*nwords = i;
return words;
}
@ -901,8 +898,8 @@ static int exec_command(Jim_Interp *interp, struct command_context *cmd_ctx,
return c->jim_handler(interp, argc, argv);
/* use c->handler */
unsigned int nwords;
char **words = script_command_args_alloc(argc, argv, &nwords);
unsigned int nwords = argc;
char **words = script_command_args_alloc(argc, argv);
if (!words)
return JIM_ERR;