interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

tcl/chip/st/spear: fix syntax errors 

While the current jimtcl does not consider this an error, the Tcl
dodekalogue states that strings terminate at the second double quote
character (see https://www.tcl.tk/man/tcl/TclCmd/Tcl.htm#M8).

These syntax errors were caught by tclint v0.2.5
(https://github.com/nmoroze/tclint):

```
tclint tcl/chip/st/spear/spear3xx_ddr.tcl | grep "syntax error"
```

Change-Id: I2763d93095e3db7590644652f16b7b24939d6cae
Signed-off-by: Noah Moroze <noahmoroze@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/8281
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
This commit is contained in:
Noah Moroze 2024-05-15 22:49:23 -04:00 committed by Antonio Borneo
parent 223e3d8fe7
commit 7050cade9d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tcl/chip/st/spear/spear3xx_ddr.tcl
View File

@ -10,7 +10,7 @@
proc sp3xx_ddr_init {ddr_type {ddr_chips 1}} { proc sp3xx_ddr_init {ddr_type {ddr_chips 1}} {
if { $ddr_chips != 1 && $ddr_chips != 2 } { if { $ddr_chips != 1 && $ddr_chips != 2 } {
error "Only 1 or 2 DDR chips permitted. Wrong value "$ddr_chips error "Only 1 or 2 DDR chips permitted. Wrong value $ddr_chips"
} }
if { $ddr_type == "mt47h64m16_3_333_cl5_async" } { if { $ddr_type == "mt47h64m16_3_333_cl5_async" } {
@ -21,7 +21,7 @@ proc sp3xx_ddr_init {ddr_type {ddr_chips 1}} {
# ????? $ddr_chips # ????? $ddr_chips
# set ddr_size 0x????? # set ddr_size 0x?????
} else { } else {
error "sp3xx_ddr_init: unrecognized DDR type "$ddr_type error "sp3xx_ddr_init: unrecognized DDR type $ddr_type"
} }
# MPMC START # MPMC START