armv8: factor out generic bit set/clr for debug registers
introduce armv8_set_dbgreg_bits() function to make register bit-field modifications easier to read. Change-Id: I6b06f66262587fd301d848c9e0645e8327653de7 Signed-off-by: Matthias Welwarsky <matthias.welwarsky@sysgo.com> Reviewed-on: http://openocd.zylin.com/3989 Tested-by: jenkins Reviewed-by: Paul Fertser <fercerpav@gmail.com>
This commit is contained in:
parent
095ff3d210
commit
6fb9f2e3ee
|
@ -238,23 +238,7 @@ static int aarch64_dpm_setup(struct aarch64_common *a8, uint64_t debug)
|
|||
static int aarch64_set_dscr_bits(struct target *target, unsigned long bit_mask, unsigned long value)
|
||||
{
|
||||
struct armv8_common *armv8 = target_to_armv8(target);
|
||||
uint32_t dscr;
|
||||
|
||||
/* Read DSCR */
|
||||
int retval = mem_ap_read_atomic_u32(armv8->debug_ap,
|
||||
armv8->debug_base + CPUV8_DBG_DSCR, &dscr);
|
||||
if (ERROR_OK != retval)
|
||||
return retval;
|
||||
|
||||
/* clear bitfield */
|
||||
dscr &= ~bit_mask;
|
||||
/* put new value */
|
||||
dscr |= value & bit_mask;
|
||||
|
||||
/* write new DSCR */
|
||||
retval = mem_ap_write_atomic_u32(armv8->debug_ap,
|
||||
armv8->debug_base + CPUV8_DBG_DSCR, dscr);
|
||||
return retval;
|
||||
return armv8_set_dbgreg_bits(armv8, CPUV8_DBG_DSCR, bit_mask, value);
|
||||
}
|
||||
|
||||
static struct target *get_aarch64(struct target *target, int32_t coreid)
|
||||
|
|
|
@ -1292,3 +1292,24 @@ int armv8_get_gdb_reg_list(struct target *target,
|
|||
}
|
||||
}
|
||||
}
|
||||
|
||||
int armv8_set_dbgreg_bits(struct armv8_common *armv8, unsigned int reg, unsigned long mask, unsigned long value)
|
||||
{
|
||||
uint32_t tmp;
|
||||
|
||||
/* Read register */
|
||||
int retval = mem_ap_read_atomic_u32(armv8->debug_ap,
|
||||
armv8->debug_base + reg, &tmp);
|
||||
if (ERROR_OK != retval)
|
||||
return retval;
|
||||
|
||||
/* clear bitfield */
|
||||
tmp &= ~mask;
|
||||
/* put new value */
|
||||
tmp |= value & mask;
|
||||
|
||||
/* write new value */
|
||||
retval = mem_ap_write_atomic_u32(armv8->debug_ap,
|
||||
armv8->debug_base + reg, tmp);
|
||||
return retval;
|
||||
}
|
||||
|
|
|
@ -307,6 +307,7 @@ static inline unsigned int armv8_curel_from_core_mode(enum arm_mode core_mode)
|
|||
}
|
||||
|
||||
void armv8_select_reg_access(struct armv8_common *armv8, bool is_aarch64);
|
||||
int armv8_set_dbgreg_bits(struct armv8_common *armv8, unsigned int reg, unsigned long mask, unsigned long value);
|
||||
|
||||
extern const struct command_registration armv8_command_handlers[];
|
||||
|
||||
|
|
Loading…
Reference in New Issue