interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix for warnings detected by clang static analyzer 

Fix for potential memory leakage and for unused/unreported return error code

Change-Id: Ifb2c95b60637c3a241ad4bf41d1a328c92ccea4b
Signed-off-by: Michele Sardo <msmttchr@gmail.com>
Reviewed-on: http://openocd.zylin.com/4476
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
This commit is contained in:
Michele Sardo 2018-03-22 12:02:19 +01:00 committed by Tomas Vanek
parent 7690a74b09
commit 6e6f90d1af
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/flash/nor/bluenrg-x.c
View File

@ -274,6 +274,7 @@ static int bluenrgx_write_bytes(struct target *target, uint32_t address_base, ui
if (pre_bytes) { if (pre_bytes) {
if (target_read_u32(target, pre_address, &pre_word)) { if (target_read_u32(target, pre_address, &pre_word)) {
LOG_ERROR("Memory read failed"); LOG_ERROR("Memory read failed");
free(new_buffer);
return ERROR_FAIL; return ERROR_FAIL;
} }
@ -282,6 +283,7 @@ static int bluenrgx_write_bytes(struct target *target, uint32_t address_base, ui
if (post_bytes) { if (post_bytes) {
if (target_read_u32(target, post_address, &post_word)) { if (target_read_u32(target, post_address, &post_word)) {
LOG_ERROR("Memory read failed"); LOG_ERROR("Memory read failed");
free(new_buffer);
return ERROR_FAIL; return ERROR_FAIL;
} }
@ -450,6 +452,9 @@ static int bluenrgx_write(struct flash_bank *bank, const uint8_t *buffer,
destroy_reg_param(&reg_params[2]); destroy_reg_param(&reg_params[2]);
destroy_reg_param(&reg_params[3]); destroy_reg_param(&reg_params[3]);
destroy_reg_param(&reg_params[4]); destroy_reg_param(&reg_params[4]);
if (retval != ERROR_OK)
return retval;
} }
/* Program chunk at end, not addressable by fast burst write algorithm */ /* Program chunk at end, not addressable by fast burst write algorithm */