Explain why reg_cache_values isn't per-hart.

Change-Id: Ie67e43bf89fdc68b4b2c12f37fa8a3ec3e6088ef
2018-06-20 14:52:38 -07:00 · 2018-06-20 14:52:38 -07:00 · 6c59fb8df4
parent 5d9f486404
commit 6c59fb8df4
1 changed files with 3 additions and 1 deletions
--- a/src/target/riscv/riscv.h
+++ b/src/target/riscv/riscv.h
@ -58,7 +58,9 @@ typedef struct {
 	uint64_t saved_registers[RISCV_MAX_HARTS][RISCV_MAX_REGISTERS];
 	bool valid_saved_registers[RISCV_MAX_HARTS][RISCV_MAX_REGISTERS];

-	/* The register cache points into here. */
+	/* OpenOCD's register cache points into here. This is not per-hart because
+	 * we just invalidate the entire cache when we change which hart is
+	 * selected. */
 	uint64_t reg_cache_values[RISCV_MAX_REGISTERS];

 	/* Single buffer that contains all register names, instead of calling