interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

gdb: fix occasional crash when flash probe failed 

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This commit is contained in:
Øyvind Harboe 2010-11-13 13:03:29 +01:00
parent c62fb3fa81
commit 6287c23b32
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/server/gdb_server.c
View File

@ -833,9 +833,6 @@ static int gdb_new_connection(struct connection *connection)
breakpoint_clear_target(gdb_service->target); breakpoint_clear_target(gdb_service->target);
watchpoint_clear_target(gdb_service->target); watchpoint_clear_target(gdb_service->target);
/* register callback to be informed about target events */
target_register_event_callback(gdb_target_callback_event_handler, connection);
/* remove the initial ACK from the incoming buffer */ /* remove the initial ACK from the incoming buffer */
if ((retval = gdb_get_char(connection, &initial_ack)) != ERROR_OK) if ((retval = gdb_get_char(connection, &initial_ack)) != ERROR_OK)
return retval; return retval;
@ -873,6 +870,13 @@ static int gdb_new_connection(struct connection *connection)
target_name(gdb_service->target), target_name(gdb_service->target),
target_state_name(gdb_service->target)); target_state_name(gdb_service->target));
/* DANGER! If we fail subsequently, we must remove this handler,
* otherwise we occasionally see crashes as the timer can invoke the
* callback fn.
*
* register callback to be informed about target events */
target_register_event_callback(gdb_target_callback_event_handler, connection);
return ERROR_OK; return ERROR_OK;
} }