interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Eliminate duplicated code in the handle_mw_command memory write loop. 

- wordsize will always be 1, 2, or 4 due to preceeding switch statement.
- move call to keep_alive after successful writes, not upon failures


git-svn-id: svn://svn.berlios.de/openocd/trunk@1953 b42882b7-edfa-0310-969c-e2dbd0fdcd60
This commit is contained in:
zwelch 2009-05-30 23:57:30 +00:00
parent 335fee3f36
commit 58e31916de
1 changed files with 4 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/target/target.c
View File

@ -1958,27 +1958,11 @@ static int handle_mw_command(struct command_context_s *cmd_ctx, char *cmd, char
} }
for (i=0; i<count; i++) for (i=0; i<count; i++)
{ {
int retval; int retval = target->type->write_memory(target,
switch (wordsize) address + i * wordsize, wordsize, 1, value_buf);
{ if (ERROR_OK != retval)
case 4:
retval = target->type->write_memory(target, address + i*wordsize, 4, 1, value_buf);
break;
case 2:
retval = target->type->write_memory(target, address + i*wordsize, 2, 1, value_buf);
break;
case 1:
retval = target->type->write_memory(target, address + i*wordsize, 1, 1, value_buf);
break;
default:
return ERROR_OK;
}
keep_alive();
if (retval!=ERROR_OK)
{
return retval; return retval;
} keep_alive();
} }
return ERROR_OK; return ERROR_OK;