interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

jim tests: use installed 

Delete obsolete jim that comes with OpenOCD.
This commit is contained in:
Øyvind Harboe 2010-10-10 19:17:03 +02:00
parent 4617cd0f91
commit 559d08c19e
14 changed files with 79 additions and 14903 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Makefile.am
View File

@ -18,7 +18,7 @@ MAINFILE = main.c
endif endif
openocd_SOURCES = $(MAINFILE) openocd_SOURCES = $(MAINFILE)
openocd_LDADD = libopenocd.la openocd_LDADD = libopenocd.la -ljim
libopenocd_la_SOURCES = \ libopenocd_la_SOURCES = \
hello.c \ hello.c \

4
src/ecosboard.c
View File

@ -500,6 +500,10 @@ static void zylinjtag_startNetwork(void)
cyg_httpd_init_tcl_interpreter(); cyg_httpd_init_tcl_interpreter();
// Kludge! Why can't I do this from httpd.c??? I get linker errors...
// some of that --start/end-group stuff?
Jim_InitStaticExtensions(httpstate.jim_interp);
Jim_CreateCommand(httpstate.jim_interp, "log", zylinjtag_Jim_Command_log, Jim_CreateCommand(httpstate.jim_interp, "log", zylinjtag_Jim_Command_log,
NULL, NULL); NULL, NULL);
Jim_CreateCommand(httpstate.jim_interp, "zy1000_reboot", Jim_CreateCommand(httpstate.jim_interp, "zy1000_reboot",

4
src/helper/Makefile.am
View File

@ -9,7 +9,7 @@ noinst_LTLIBRARIES = libhelper.la
if ECOSBOARD if ECOSBOARD
CONFIGFILES = time_support_ecos.c CONFIGFILES = time_support_ecos.c
else else
CONFIGFILES = options.c jim.c jim-eventloop.c time_support_common.c CONFIGFILES = options.c time_support_common.c
endif endif
@ -48,8 +48,6 @@ noinst_HEADERS = \
time_support.h \ time_support.h \
replacements.h \ replacements.h \
fileio.h \ fileio.h \
jim.h \
jim-eventloop.h \
system.h \ system.h \
bin2char.c bin2char.c

104
src/helper/command.c
View File

@ -684,7 +684,8 @@ int command_run_line(struct command_context *context, char *line)
if (retval != ERROR_COMMAND_CLOSE_CONNECTION) if (retval != ERROR_COMMAND_CLOSE_CONNECTION)
{ {
/* We do not print the connection closed error message */ /* We do not print the connection closed error message */
Jim_PrintErrorMessage(interp); Jim_MakeErrorMessage(interp);
LOG_USER_N("%s\n", Jim_GetString(Jim_GetResult(interp), NULL));
} }
if (retval == ERROR_OK) if (retval == ERROR_OK)
{ {
@ -785,89 +786,6 @@ static int jim_echo(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
return JIM_OK; return JIM_OK;
} }
static size_t openocd_jim_fwrite(const void *_ptr, size_t size, size_t n, void *cookie)
{
size_t nbytes;
const char *ptr;
Jim_Interp *interp;
/* make it a char easier to read code */
ptr = _ptr;
interp = cookie;
nbytes = size * n;
if (ptr == NULL || interp == NULL || nbytes == 0) {
return 0;
}
/* do we have to chunk it? */
if (ptr[nbytes] == 0)
{
/* no it is a C style string */
LOG_USER_N("%s", ptr);
return strlen(ptr);
}
/* GRR we must chunk - not null terminated */
while (nbytes) {
char chunk[128 + 1];
int x;
x = nbytes;
if (x > 128) {
x = 128;
}
/* copy it */
memcpy(chunk, ptr, x);
/* terminate it */
chunk[n] = 0;
/* output it */
LOG_USER_N("%s", chunk);
ptr += x;
nbytes -= x;
}
return n;
}
static size_t openocd_jim_fread(void *ptr, size_t size, size_t n, void *cookie)
{
/* TCL wants to read... tell him no */
return 0;
}
static int openocd_jim_vfprintf(void *cookie, const char *fmt, va_list ap)
{
char *cp;
int n;
Jim_Interp *interp;
n = -1;
interp = cookie;
if (interp == NULL)
return n;
cp = alloc_vprintf(fmt, ap);
if (cp)
{
LOG_USER_N("%s", cp);
n = strlen(cp);
free(cp);
}
return n;
}
static int openocd_jim_fflush(void *cookie)
{
/* nothing to flush */
return 0;
}
static char* openocd_jim_fgets(char *s, int size, void *cookie)
{
/* not supported */
errno = ENOTSUP;
return NULL;
}
/* Capture progress output and return as tcl return value. If the /* Capture progress output and return as tcl return value. If the
* progress output was empty, return tcl return value. * progress output was empty, return tcl return value.
*/ */
@ -1400,11 +1318,11 @@ struct command_context* command_init(const char *startup_tcl, Jim_Interp *interp
/* Create a jim interpreter if we were not handed one */ /* Create a jim interpreter if we were not handed one */
if (interp == NULL) if (interp == NULL)
{ {
Jim_InitEmbedded();
/* Create an interpreter */ /* Create an interpreter */
interp = Jim_CreateInterp(); interp = Jim_CreateInterp();
/* Add all the Jim core commands */ /* Add all the Jim core commands */
Jim_RegisterCoreCommands(interp); Jim_RegisterCoreCommands(interp);
Jim_InitStaticExtensions(interp);
} }
#endif #endif
context->interp = interp; context->interp = interp;
@ -1442,26 +1360,14 @@ struct command_context* command_init(const char *startup_tcl, Jim_Interp *interp
Jim_CreateCommand(interp, "echo", jim_echo, NULL, NULL); Jim_CreateCommand(interp, "echo", jim_echo, NULL, NULL);
Jim_CreateCommand(interp, "capture", jim_capture, NULL, NULL); Jim_CreateCommand(interp, "capture", jim_capture, NULL, NULL);
/* Set Jim's STDIO */
interp->cookie_stdin = interp;
interp->cookie_stdout = interp;
interp->cookie_stderr = interp;
interp->cb_fwrite = openocd_jim_fwrite;
interp->cb_fread = openocd_jim_fread ;
interp->cb_vfprintf = openocd_jim_vfprintf;
interp->cb_fflush = openocd_jim_fflush;
interp->cb_fgets = openocd_jim_fgets;
register_commands(context, NULL, command_builtin_handlers); register_commands(context, NULL, command_builtin_handlers);
#if !BUILD_ECOSBOARD
Jim_EventLoopOnLoad(interp);
#endif
Jim_SetAssocData(interp, "context", NULL, context); Jim_SetAssocData(interp, "context", NULL, context);
if (Jim_Eval_Named(interp, startup_tcl, "embedded:startup.tcl",1) == JIM_ERR) if (Jim_Eval_Named(interp, startup_tcl, "embedded:startup.tcl",1) == JIM_ERR)
{ {
LOG_ERROR("Failed to run startup.tcl (embedded into OpenOCD)"); LOG_ERROR("Failed to run startup.tcl (embedded into OpenOCD)");
Jim_PrintErrorMessage(interp); Jim_MakeErrorMessage(interp);
LOG_USER_N("%s", Jim_GetString(Jim_GetResult(interp), NULL));
exit(-1); exit(-1);
} }
Jim_DeleteAssocData(interp, "context"); Jim_DeleteAssocData(interp, "context");

7
src/helper/command.h
View File

@ -29,12 +29,11 @@
#if BUILD_ECOSBOARD #if BUILD_ECOSBOARD
#include <stdio.h> #include <stdio.h>
#include <stdarg.h> #include <stdarg.h>
/* Jim is provied by eCos */
#include <cyg/jimtcl/jim.h>
#else
#include <helper/jim.h>
#endif #endif
#include <jim.h>
#include <jim-nvp.h>
/* To achieve C99 printf compatibility in MinGW, gnu_printf should be /* To achieve C99 printf compatibility in MinGW, gnu_printf should be
* used for __attribute__((format( ... ))), with GCC v4.4 or later * used for __attribute__((format( ... ))), with GCC v4.4 or later
*/ */

532
src/helper/jim-eventloop.c
View File

@ -1,532 +0,0 @@
/* Jim - A small embeddable Tcl interpreter
*
* Copyright 2005 Salvatore Sanfilippo <antirez@invece.org>
* Copyright 2005 Clemens Hintze <c.hintze@gmx.net>
* Copyright 2005 patthoyts - Pat Thoyts <patthoyts@users.sf.net>
* Copyright 2008 oharboe - Øyvind Harboe - oyvind.harboe@zylin.com
* Copyright 2008 Andrew Lunn <andrew@lunn.ch>
* Copyright 2008 Duane Ellis <openocd@duaneellis.com>
* Copyright 2008 Uwe Klein <uklein@klein-messgeraete.de>
*
* The FreeBSD license
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the following
* disclaimer in the documentation and/or other materials
* provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE JIM TCL PROJECT ``AS IS'' AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
* PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
* JIM TCL PROJECT OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
* INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
* ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* The views and conclusions contained in the software and documentation
* are those of the authors and should not be interpreted as representing
* official policies, either expressed or implied, of the Jim Tcl Project.
**/
/* TODO:
*
* - to really use flags in Jim_ProcessEvents()
* - more complete [after] command with [after info] and other subcommands.
* - Win32 port
*/
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#define JIM_EXTENSION
#define __JIM_EVENTLOOP_CORE__
#ifdef __ECOS
#include <pkgconf/jimtcl.h>
#include <sys/time.h>
#include <cyg/jimtcl/jim.h>
#include <cyg/jimtcl/jim-eventloop.h>
#else
#include "jim.h"
#include "jim-eventloop.h"
#endif
/* File event structure */
typedef struct Jim_FileEvent {
void *handle;
int mask; /* one of JIM_EVENT_(READABLE | WRITABLE | EXCEPTION) */
Jim_FileProc *fileProc;
Jim_EventFinalizerProc *finalizerProc;
void *clientData;
struct Jim_FileEvent *next;
} Jim_FileEvent;
/* Time event structure */
typedef struct Jim_TimeEvent {
jim_wide id; /* time event identifier. */
int mode; /* restart, repetitive .. UK */
long initialms; /* initial relativ timer value UK */
long when_sec; /* seconds */
long when_ms; /* milliseconds */
Jim_TimeProc *timeProc;
Jim_EventFinalizerProc *finalizerProc;
void *clientData;
struct Jim_TimeEvent *next;
} Jim_TimeEvent;
/* Per-interp stucture containing the state of the event loop */
typedef struct Jim_EventLoop {
jim_wide timeEventNextId;
Jim_FileEvent *fileEventHead;
Jim_TimeEvent *timeEventHead;
} Jim_EventLoop;
static void Jim_CreateFileHandler(Jim_Interp *interp, void *handle, int mask,
Jim_FileProc *proc, void *clientData,
Jim_EventFinalizerProc *finalizerProc)
{
Jim_FileEvent *fe;
Jim_EventLoop *eventLoop = Jim_GetAssocData(interp, "eventloop");
// fprintf(stderr,"rein\n");
fe = Jim_Alloc(sizeof(*fe));
fe->handle = handle;
fe->mask = mask;
fe->fileProc = proc;
fe->finalizerProc = finalizerProc;
fe->clientData = clientData;
fe->next = eventLoop->fileEventHead;
eventLoop->fileEventHead = fe;
// fprintf(stderr,"raus\n");
}
static void Jim_DeleteFileHandler(Jim_Interp *interp, void *handle)
{
Jim_FileEvent *fe, *prev = NULL;
Jim_EventLoop *eventLoop = Jim_GetAssocData(interp, "eventloop");
fe = eventLoop->fileEventHead;
while (fe) {
if (fe->handle == handle) {
if (prev == NULL)
eventLoop->fileEventHead = fe->next;
else
prev->next = fe->next;
if (fe->finalizerProc)
fe->finalizerProc(interp, fe->clientData);
Jim_Free(fe);
return;
}
prev = fe;
fe = fe->next;
}
}
/* That's another part of this extension that needs to be ported
* to WIN32. */
static void JimGetTime(long *seconds, long *milliseconds)
{
struct timeval tv;
gettimeofday(&tv, NULL);
*seconds = tv.tv_sec;
*milliseconds = tv.tv_usec/1000;
}
static jim_wide Jim_CreateTimeHandler(Jim_Interp *interp, jim_wide milliseconds,
Jim_TimeProc *proc, void *clientData,
Jim_EventFinalizerProc *finalizerProc)
{
Jim_EventLoop *eventLoop = Jim_GetAssocData(interp, "eventloop");
jim_wide id = eventLoop->timeEventNextId++;
Jim_TimeEvent *te;
long cur_sec, cur_ms;
JimGetTime(&cur_sec, &cur_ms);
te = Jim_Alloc(sizeof(*te));
te->id = id;
te->mode = 0;
te->initialms = milliseconds;
te->when_sec = cur_sec + milliseconds/1000;
te->when_ms = cur_ms + milliseconds%1000;
if (te->when_ms >= 1000) {
te->when_sec ++;
te->when_ms -= 1000;
}
te->timeProc = proc;
te->finalizerProc = finalizerProc;
te->clientData = clientData;
te->next = eventLoop->timeEventHead;
eventLoop->timeEventHead = te;
return id;
}
static jim_wide Jim_DeleteTimeHandler(Jim_Interp *interp, jim_wide id)
{
Jim_TimeEvent *te, *prev = NULL;
Jim_EventLoop *eventLoop = Jim_GetAssocData(interp, "eventloop");
long cur_sec, cur_ms;
jim_wide remain ;
JimGetTime(&cur_sec, &cur_ms);
te = eventLoop->timeEventHead;
if (id >= eventLoop->timeEventNextId)
return -2; /* wrong event ID */
while (te) {
if (te->id == id) {
remain = (te->when_sec - cur_sec) * 1000;
remain += (te->when_ms - cur_ms) ;
remain = (remain < 0) ? 0 : remain ;
if (prev == NULL)
eventLoop->timeEventHead = te->next;
else
prev->next = te->next;
if (te->finalizerProc)
te->finalizerProc(interp, te->clientData);
Jim_Free(te);
return remain;
}
prev = te;
te = te->next;
}
return -1; /* NO event with the specified ID found */
}
/* Search the first timer to fire.
* This operation is useful to know how many time the select can be
* put in sleep without to delay any event.
* If there are no timers NULL is returned. */
static Jim_TimeEvent *JimSearchNearestTimer(Jim_EventLoop *eventLoop)
{
Jim_TimeEvent *te = eventLoop->timeEventHead;
Jim_TimeEvent *nearest = NULL;
while (te) {
if (!nearest || te->when_sec < nearest->when_sec ||
(te->when_sec == nearest->when_sec &&
te->when_ms < nearest->when_ms))
nearest = te;
te = te->next;
}
return nearest;
}
/* --- POSIX version of Jim_ProcessEvents, for now the only available --- */
#define JIM_FILE_EVENTS 1
#define JIM_TIME_EVENTS 2
#define JIM_ALL_EVENTS (JIM_FILE_EVENTS | JIM_TIME_EVENTS)
#define JIM_DONT_WAIT 4
/* Process every pending time event, then every pending file event
* (that may be registered by time event callbacks just processed).
* Without special flags the function sleeps until some file event
* fires, or when the next time event occurrs (if any).
*
* If flags is 0, the function does nothing and returns.
* if flags has JIM_ALL_EVENTS set, all the kind of events are processed.
* if flags has JIM_FILE_EVENTS set, file events are processed.
* if flags has JIM_TIME_EVENTS set, time events are processed.
* if flags has JIM_DONT_WAIT set the function returns ASAP until all
* the events that's possible to process without to wait are processed.
*
* The function returns the number of events processed. */
int Jim_ProcessEvents(Jim_Interp *interp, int flags)
{
int maxfd = 0, numfd = 0, processed = 0;
fd_set rfds, wfds, efds;
Jim_EventLoop *eventLoop = Jim_GetAssocData(interp, "eventloop");
Jim_FileEvent *fe = eventLoop->fileEventHead;
Jim_TimeEvent *te;
jim_wide maxId;
JIM_NOTUSED(flags);
FD_ZERO(&rfds);
FD_ZERO(&wfds);
FD_ZERO(&efds);
/* Check file events */
while (fe != NULL) {
int fd = fileno((FILE*)fe->handle);
if (fe->mask & JIM_EVENT_READABLE)
FD_SET(fd, &rfds);
if (fe->mask & JIM_EVENT_WRITABLE) FD_SET(fd, &wfds);
if (fe->mask & JIM_EVENT_EXCEPTION) FD_SET(fd, &efds);
if (maxfd < fd) maxfd = fd;
numfd++;
fe = fe->next;
}
/* Note that we want call select() even if there are no
* file events to process as long as we want to process time
* events, in order to sleep until the next time event is ready
* to fire. */
if (numfd || ((flags & JIM_TIME_EVENTS) && !(flags & JIM_DONT_WAIT))) {
int retval;
Jim_TimeEvent *shortest;
struct timeval tv, *tvp;
jim_wide dt;
shortest = JimSearchNearestTimer(eventLoop);
if (shortest) {
long now_sec, now_ms;
/* Calculate the time missing for the nearest
* timer to fire. */
JimGetTime(&now_sec, &now_ms);
tvp = &tv;
dt = 1000 * (shortest->when_sec - now_sec);
dt += (shortest->when_ms - now_ms);
if (dt < 0) {
dt = 1;
}
tvp->tv_sec = dt / 1000;
tvp->tv_usec = dt % 1000;
// fprintf(stderr,"Next %d.% 8d\n",(int)tvp->tv_sec,(int)tvp->tv_usec);
} else {
tvp = NULL; /* wait forever */
// fprintf(stderr,"No Event\n");
}
retval = select(maxfd + 1, &rfds, &wfds, &efds, tvp);
if (retval < 0) {
switch (errno) {
case EINTR: fprintf(stderr,"select EINTR\n"); break;
case EINVAL: fprintf(stderr,"select EINVAL\n"); break;
case ENOMEM: fprintf(stderr,"select ENOMEM\n"); break;
}
} else if (retval > 0) {
fe = eventLoop->fileEventHead;
while (fe != NULL) {
int fd = fileno((FILE*)fe->handle);
// fprintf(stderr,"fd: %d mask: %02x \n",fd,fe->mask);
if ((fe->mask & JIM_EVENT_READABLE && FD_ISSET(fd, &rfds)) ||
(fe->mask & JIM_EVENT_WRITABLE && FD_ISSET(fd, &wfds)) ||
(fe->mask & JIM_EVENT_EXCEPTION && FD_ISSET(fd, &efds)))
{
int mask = 0;
if (fe->mask & JIM_EVENT_READABLE && FD_ISSET(fd, &rfds)) {
mask |= JIM_EVENT_READABLE;
if ((fe->mask & JIM_EVENT_FEOF) && feof((FILE *)fe->handle))
mask |= JIM_EVENT_FEOF;
}
if (fe->mask & JIM_EVENT_WRITABLE && FD_ISSET(fd, &wfds))
mask |= JIM_EVENT_WRITABLE;
if (fe->mask & JIM_EVENT_EXCEPTION && FD_ISSET(fd, &efds))
mask |= JIM_EVENT_EXCEPTION;
if (fe->fileProc(interp, fe->clientData, mask) == JIM_ERR) {
/* Remove the element on handler error */
Jim_DeleteFileHandler(interp, fe->handle);
}
processed++;
/* After an event is processed our file event list
* may no longer be the same, so what we do
* is to clear the bit for this file descriptor and
* restart again from the head. */
fe = eventLoop->fileEventHead;
FD_CLR(fd, &rfds);
FD_CLR(fd, &wfds);
FD_CLR(fd, &efds);
} else {
fe = fe->next;
}
}
}
}
/* Check time events */
te = eventLoop->timeEventHead;
maxId = eventLoop->timeEventNextId-1;
while (te) {
long now_sec, now_ms;
jim_wide id;
if (te->id > maxId) {
te = te->next;
continue;
}
JimGetTime(&now_sec, &now_ms);
if (now_sec > te->when_sec ||
(now_sec == te->when_sec && now_ms >= te->when_ms))
{
id = te->id;
te->timeProc(interp, te->clientData);
/* After an event is processed our time event list may
* no longer be the same, so we restart from head.
* Still we make sure to don't process events registered
* by event handlers itself in order to don't loop forever
* even in case an [after 0] that continuously register
* itself. To do so we saved the max ID we want to handle. */
Jim_DeleteTimeHandler(interp, id);
te = eventLoop->timeEventHead;
} else {
te = te->next;
}
}
return processed;
}
/* ---------------------------------------------------------------------- */
static void JimELAssocDataDeleProc(Jim_Interp *interp, void *data)
{
void *next;
Jim_FileEvent *fe;
Jim_TimeEvent *te;
Jim_EventLoop *eventLoop = data;
fe = eventLoop->fileEventHead;
while (fe) {
next = fe->next;
if (fe->finalizerProc)
fe->finalizerProc(interp, fe->clientData);
Jim_Free(fe);
fe = next;
}
te = eventLoop->timeEventHead;
while (te) {
next = te->next;
if (te->finalizerProc)
te->finalizerProc(interp, te->clientData);
Jim_Free(te);
te = next;
}
Jim_Free(data);
}
static int JimELVwaitCommand(Jim_Interp *interp, int argc,
Jim_Obj *const *argv)
{
Jim_Obj *oldValue;
if (argc != 2) {
Jim_WrongNumArgs(interp, 1, argv, "name");
return JIM_ERR;
}
oldValue = Jim_GetGlobalVariable(interp, argv[1], JIM_NONE);
if (oldValue) Jim_IncrRefCount(oldValue);
while (1) {
Jim_Obj *currValue;
Jim_ProcessEvents(interp, JIM_ALL_EVENTS);
currValue = Jim_GetGlobalVariable(interp, argv[1], JIM_NONE);
/* Stop the loop if the vwait-ed variable changed value,
* or if was unset and now is set (or the contrary). */
if ((oldValue && !currValue) ||
(!oldValue && currValue) ||
(oldValue && currValue &&
!Jim_StringEqObj(oldValue, currValue, JIM_CASESENS)))
break;
}
if (oldValue) Jim_DecrRefCount(interp, oldValue);
return JIM_OK;
}
static void JimAfterTimeHandler(Jim_Interp *interp, void *clientData)
{
Jim_Obj *objPtr = clientData;
Jim_EvalObjBackground(interp, objPtr);
}
static void JimAfterTimeEventFinalizer(Jim_Interp *interp, void *clientData)
{
Jim_Obj *objPtr = clientData;
Jim_DecrRefCount(interp, objPtr);
}
static int JimELAfterCommand(Jim_Interp *interp, int argc,
Jim_Obj *const *argv)
{
jim_wide ms, id;
Jim_Obj *objPtr, *idObjPtr;
const char *options[] = {
"info", "cancel", "restart", "expire", NULL
};
enum {INFO, CANCEL, RESTART, EXPIRE, CREATE };
int option = CREATE ;
if (argc < 3) {
Jim_WrongNumArgs(interp, 1, argv, "<after milliseconds> script");
return JIM_ERR;
}
if (Jim_GetWide(interp, argv[1], &ms) != JIM_OK)
if (Jim_GetEnum(interp, argv[1], options, &option, "after options",
JIM_ERRMSG) != JIM_OK)
return JIM_ERR;
switch (option) {
case CREATE:
Jim_IncrRefCount(argv[2]);
id = Jim_CreateTimeHandler(interp, ms, JimAfterTimeHandler, argv[2],
JimAfterTimeEventFinalizer);
objPtr = Jim_NewStringObj(interp, NULL, 0);
Jim_AppendString(interp, objPtr, "after#", -1);
idObjPtr = Jim_NewIntObj(interp, id);
Jim_IncrRefCount(idObjPtr);
Jim_AppendObj(interp, objPtr, idObjPtr);
Jim_DecrRefCount(interp, idObjPtr);
Jim_SetResult(interp, objPtr);
return JIM_OK;
case CANCEL:
{
int tlen ;
jim_wide remain = 0;
const char *tok = Jim_GetString(argv[2], &tlen);
if (sscanf(tok,"after#%" JIM_WIDE_MODIFIER, &id) == 1) {
remain = Jim_DeleteTimeHandler(interp, id);
if (remain > -2) {
Jim_SetResult(interp, Jim_NewIntObj(interp, remain));
return JIM_OK;
}
}
Jim_SetResultString(interp, "invalid event" , -1);
return JIM_ERR;
}
default:
fprintf(stderr,"unserviced option to after %d\n",option);
}
return JIM_OK;
}
/* This extension is not dynamically loaded, instead it's linked statically,
which is why we shouldn't use the unspecific 'Jim_OnLoad' name */
int Jim_EventLoopOnLoad(Jim_Interp *interp)
{
Jim_EventLoop *eventLoop;
Jim_InitExtension(interp);
if (Jim_PackageProvide(interp, "eventloop", "1.0", JIM_ERRMSG) != JIM_OK)
return JIM_ERR;
eventLoop = Jim_Alloc(sizeof(*eventLoop));
eventLoop->fileEventHead = NULL;
eventLoop->timeEventHead = NULL;
eventLoop->timeEventNextId = 1;
Jim_SetAssocData(interp, "eventloop", JimELAssocDataDeleProc, eventLoop);
Jim_CreateCommand(interp, "vwait", JimELVwaitCommand, NULL, NULL);
Jim_CreateCommand(interp, "after", JimELAfterCommand, NULL, NULL);
/* Export events API */
Jim_RegisterApi(interp, "Jim_CreateFileHandler", Jim_CreateFileHandler);
Jim_RegisterApi(interp, "Jim_DeleteFileHandler", Jim_DeleteFileHandler);
Jim_RegisterApi(interp, "Jim_CreateTimeHandler", Jim_CreateTimeHandler);
Jim_RegisterApi(interp, "Jim_DeleteTimeHandler", Jim_DeleteTimeHandler);
Jim_RegisterApi(interp, "Jim_ProcessEvents", Jim_ProcessEvents);
return JIM_OK;
}

75
src/helper/jim-eventloop.h
View File

@ -1,75 +0,0 @@
/* Jim - A small embeddable Tcl interpreter
*
* Copyright 2005 Salvatore Sanfilippo <antirez@invece.org>
* Copyright 2005 Clemens Hintze <c.hintze@gmx.net>
* Copyright 2005 patthoyts - Pat Thoyts <patthoyts@users.sf.net>
* Copyright 2008 oharboe - Øyvind Harboe - oyvind.harboe@zylin.com
* Copyright 2008 Andrew Lunn <andrew@lunn.ch>
* Copyright 2008 Duane Ellis <openocd@duaneellis.com>
* Copyright 2008 Uwe Klein <uklein@klein-messgeraete.de>
*
* The FreeBSD license
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the following
* disclaimer in the documentation and/or other materials
* provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE JIM TCL PROJECT ``AS IS'' AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
* PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
* JIM TCL PROJECT OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
* INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
* STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
* ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* The views and conclusions contained in the software and documentation
* are those of the authors and should not be interpreted as representing
* official policies, either expressed or implied, of the Jim Tcl Project.
**/
/* ------ USAGE -------
*
* In order to use this file from other extensions include it in every
* file where you need to call the eventloop API, also in the init
* function of your extension call Jim_ImportEventloopAPI(interp)
* after the Jim_InitExtension() call.
*
* See the UDP extension as example.
*/
#ifndef __JIM_EVENTLOOP_H__
#define __JIM_EVENTLOOP_H__
typedef int Jim_FileProc(Jim_Interp *interp, void *clientData, int mask);
typedef void Jim_TimeProc(Jim_Interp *interp, void *clientData);
typedef void Jim_EventFinalizerProc(Jim_Interp *interp, void *clientData);
/* File event structure */
#define JIM_EVENT_READABLE 1
#define JIM_EVENT_WRITABLE 2
#define JIM_EVENT_EXCEPTION 4
#define JIM_EVENT_FEOF 8
int Jim_EventLoopOnLoad(Jim_Interp *interp);
/* --- POSIX version of Jim_ProcessEvents, for now the only available --- */
#define JIM_FILE_EVENTS 1
#define JIM_TIME_EVENTS 2
#define JIM_ALL_EVENTS (JIM_FILE_EVENTS | JIM_TIME_EVENTS)
#define JIM_DONT_WAIT 4
int Jim_ProcessEvents(Jim_Interp *interp, int flags);
#endif /* __JIM_EVENTLOOP_H__ */

12820
src/helper/jim.c
View File

File diff suppressed because it is too large Load Diff

1324
src/helper/jim.h
View File

File diff suppressed because it is too large Load Diff

33
src/jtag/tcl.c
View File

@ -63,7 +63,7 @@ struct jtag_tap *jtag_tap_by_jim_obj(Jim_Interp *interp, Jim_Obj *o)
if (NULL == cp) if (NULL == cp)
cp = "(unknown)"; cp = "(unknown)";
if (NULL == t) if (NULL == t)
Jim_SetResult_sprintf(interp, "Tap '%s' could not be found", cp); Jim_SetResultFormatted(interp, "Tap '%s' could not be found", cp);
return t; return t;
} }
@ -145,7 +145,7 @@ static int Jim_Command_drscan(Jim_Interp *interp, int argc, Jim_Obj *const *args
endstate = tap_state_by_name(cp); endstate = tap_state_by_name(cp);
if (endstate < 0) { if (endstate < 0) {
/* update the error message */ /* update the error message */
Jim_SetResult_sprintf(interp,"endstate: %s invalid", cp); Jim_SetResultFormatted(interp,"endstate: %s invalid", cp);
} else { } else {
if (!scan_is_safe(endstate)) if (!scan_is_safe(endstate))
LOG_WARNING("drscan with unsafe " LOG_WARNING("drscan with unsafe "
@ -242,7 +242,7 @@ static int Jim_Command_pathmove(Jim_Interp *interp, int argc, Jim_Obj *const *ar
if (states[i] < 0) if (states[i] < 0)
{ {
/* update the error message */ /* update the error message */
Jim_SetResult_sprintf(interp,"endstate: %s invalid", cp); Jim_SetResultFormatted(interp,"endstate: %s invalid", cp);
return JIM_ERR; return JIM_ERR;
} }
} }
@ -419,7 +419,7 @@ static int jtag_tap_configure_cmd(Jim_GetOptInfo *goi, struct jtag_tap * tap)
return e; return e;
break; break;
default: default:
Jim_SetResult_sprintf(goi->interp, "unknown event: %s", n->name); Jim_SetResultFormatted(goi->interp, "unknown event: %s", n->name);
return JIM_ERR; return JIM_ERR;
} }
} }
@ -443,7 +443,7 @@ static int jim_newtap_expected_id(Jim_Nvp *n, Jim_GetOptInfo *goi,
jim_wide w; jim_wide w;
int e = Jim_GetOpt_Wide(goi, &w); int e = Jim_GetOpt_Wide(goi, &w);
if (e != JIM_OK) { if (e != JIM_OK) {
Jim_SetResult_sprintf(goi->interp, "option: %s bad parameter", n->name); Jim_SetResultFormatted(goi->interp, "option: %s bad parameter", n->name);
return e; return e;
} }
@ -451,7 +451,7 @@ static int jim_newtap_expected_id(Jim_Nvp *n, Jim_GetOptInfo *goi,
uint32_t *new_expected_ids = malloc(expected_len + sizeof(uint32_t)); uint32_t *new_expected_ids = malloc(expected_len + sizeof(uint32_t));
if (new_expected_ids == NULL) if (new_expected_ids == NULL)
{ {
Jim_SetResult_sprintf(goi->interp, "no memory"); Jim_SetResultFormatted(goi->interp, "no memory");
return JIM_ERR; return JIM_ERR;
} }
@ -481,7 +481,7 @@ static int jim_newtap_ir_param(Jim_Nvp *n, Jim_GetOptInfo *goi,
int e = Jim_GetOpt_Wide(goi, &w); int e = Jim_GetOpt_Wide(goi, &w);
if (e != JIM_OK) if (e != JIM_OK)
{ {
Jim_SetResult_sprintf(goi->interp, Jim_SetResultFormatted(goi->interp,
"option: %s bad parameter", n->name); "option: %s bad parameter", n->name);
free((void *)pTap->dotted_name); free((void *)pTap->dotted_name);
return e; return e;
@ -545,7 +545,7 @@ static int jim_newtap_cmd(Jim_GetOptInfo *goi)
pTap = calloc(1, sizeof(struct jtag_tap)); pTap = calloc(1, sizeof(struct jtag_tap));
if (!pTap) { if (!pTap) {
Jim_SetResult_sprintf(goi->interp, "no memory"); Jim_SetResultFormatted(goi->interp, "no memory");
return JIM_ERR; return JIM_ERR;
} }
@ -553,7 +553,7 @@ static int jim_newtap_cmd(Jim_GetOptInfo *goi)
* we expect CHIP + TAP + OPTIONS * we expect CHIP + TAP + OPTIONS
* */ * */
if (goi->argc < 3) { if (goi->argc < 3) {
Jim_SetResult_sprintf(goi->interp, "Missing CHIP TAP OPTIONS ...."); Jim_SetResultFormatted(goi->interp, "Missing CHIP TAP OPTIONS ....");
free(pTap); free(pTap);
return JIM_ERR; return JIM_ERR;
} }
@ -631,7 +631,7 @@ static int jim_newtap_cmd(Jim_GetOptInfo *goi)
return JIM_OK; return JIM_OK;
} }
Jim_SetResult_sprintf(goi->interp, Jim_SetResultFormatted(goi->interp,
"newtap: %s missing IR length", "newtap: %s missing IR length",
pTap->dotted_name); pTap->dotted_name);
jtag_tap_free(pTap); jtag_tap_free(pTap);
@ -654,7 +654,8 @@ static void jtag_tap_handle_event(struct jtag_tap *tap, enum jtag_event e)
if (Jim_EvalObj(jteap->interp, jteap->body) != JIM_OK) if (Jim_EvalObj(jteap->interp, jteap->body) != JIM_OK)
{ {
Jim_PrintErrorMessage(jteap->interp); Jim_MakeErrorMessage(jteap->interp);
LOG_USER_N("%s\n", Jim_GetString(Jim_GetResult(jteap->interp), NULL));
continue; continue;
} }
@ -687,7 +688,9 @@ static int jim_jtag_arp_init(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
struct command_context *context = current_command_context(interp); struct command_context *context = current_command_context(interp);
int e = jtag_init_inner(context); int e = jtag_init_inner(context);
if (e != ERROR_OK) { if (e != ERROR_OK) {
Jim_SetResult_sprintf(goi.interp, "error: %d", e); Jim_Obj *eObj = Jim_NewIntObj(goi.interp, e);
Jim_SetResultFormatted(goi.interp, "error: %#s", eObj);
Jim_FreeNewObj(goi.interp, eObj);
return JIM_ERR; return JIM_ERR;
} }
return JIM_OK; return JIM_OK;
@ -704,7 +707,9 @@ static int jim_jtag_arp_init_reset(Jim_Interp *interp, int argc, Jim_Obj *const
struct command_context *context = current_command_context(interp); struct command_context *context = current_command_context(interp);
int e = jtag_init_reset(context); int e = jtag_init_reset(context);
if (e != ERROR_OK) { if (e != ERROR_OK) {
Jim_SetResult_sprintf(goi.interp, "error: %d", e); Jim_Obj *eObj = Jim_NewIntObj(goi.interp, e);
Jim_SetResultFormatted(goi.interp, "error: %#s", eObj);
Jim_FreeNewObj(goi.interp, eObj);
return JIM_ERR; return JIM_ERR;
} }
return JIM_OK; return JIM_OK;
@ -754,7 +759,7 @@ static int jim_jtag_tap_enabler(Jim_Interp *interp, int argc, Jim_Obj *const *ar
Jim_GetOptInfo goi; Jim_GetOptInfo goi;
Jim_GetOpt_Setup(&goi, interp, argc-1, argv + 1); Jim_GetOpt_Setup(&goi, interp, argc-1, argv + 1);
if (goi.argc != 1) { if (goi.argc != 1) {
Jim_SetResult_sprintf(goi.interp, "usage: %s <name>", cmd_name); Jim_SetResultFormatted(goi.interp, "usage: %s <name>", cmd_name);
return JIM_ERR; return JIM_ERR;
} }

2
src/target/dsp563xx.c
View File

@ -21,7 +21,7 @@
#include "config.h" #include "config.h"
#endif #endif
#include <helper/jim.h> #include <jim.h>
#include "target.h" #include "target.h"
#include "target_type.h" #include "target_type.h"

2
src/target/dsp563xx_once.c
View File

@ -21,7 +21,7 @@
#include "config.h" #include "config.h"
#endif #endif
#include <helper/jim.h> #include <jim.h>
#include "target.h" #include "target.h"
#include "target_type.h" #include "target_type.h"

72
src/target/target.c
View File

@ -505,7 +505,8 @@ static int target_process_reset(struct command_context *cmd_ctx, enum target_res
jtag_poll_set_enabled(save_poll); jtag_poll_set_enabled(save_poll);
if (retval != JIM_OK) { if (retval != JIM_OK) {
Jim_PrintErrorMessage(cmd_ctx->interp); Jim_MakeErrorMessage(cmd_ctx->interp);
command_print(NULL,"%s\n", Jim_GetString(Jim_GetResult(cmd_ctx->interp), NULL));
return ERROR_FAIL; return ERROR_FAIL;
} }
@ -3627,7 +3628,8 @@ void target_handle_event(struct target *target, enum target_event e)
Jim_GetString(teap->body, NULL)); Jim_GetString(teap->body, NULL));
if (Jim_EvalObj(teap->interp, teap->body) != JIM_OK) if (Jim_EvalObj(teap->interp, teap->body) != JIM_OK)
{ {
Jim_PrintErrorMessage(teap->interp); Jim_MakeErrorMessage(teap->interp);
command_print(NULL,"%s\n", Jim_GetString(Jim_GetResult(teap->interp), NULL));
} }
} }
} }
@ -3709,7 +3711,7 @@ static int target_configure(Jim_GetOptInfo *goi, struct target *target)
case TCFG_TYPE: case TCFG_TYPE:
/* not setable */ /* not setable */
if (goi->isconfigure) { if (goi->isconfigure) {
Jim_SetResult_sprintf(goi->interp, Jim_SetResultFormatted(goi->interp,
"not settable: %s", n->name); "not settable: %s", n->name);
return JIM_ERR; return JIM_ERR;
} else { } else {
@ -3902,7 +3904,7 @@ static int target_configure(Jim_GetOptInfo *goi, struct target *target)
case TCFG_VARIANT: case TCFG_VARIANT:
if (goi->isconfigure) { if (goi->isconfigure) {
if (goi->argc < 1) { if (goi->argc < 1) {
Jim_SetResult_sprintf(goi->interp, Jim_SetResultFormatted(goi->interp,
"%s ?STRING?", "%s ?STRING?",
n->name); n->name);
return JIM_ERR; return JIM_ERR;
@ -3980,7 +3982,7 @@ static int jim_target_mw(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
if (goi.argc < 2 || goi.argc > 4) if (goi.argc < 2 || goi.argc > 4)
{ {
Jim_SetResult_sprintf(goi.interp, Jim_SetResultFormatted(goi.interp,
"usage: %s [phys] <address> <data> [<count>]", cmd_name); "usage: %s [phys] <address> <data> [<count>]", cmd_name);
return JIM_ERR; return JIM_ERR;
} }
@ -4051,7 +4053,7 @@ static int jim_target_md(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
if ((goi.argc < 1) || (goi.argc > 3)) if ((goi.argc < 1) || (goi.argc > 3))
{ {
Jim_SetResult_sprintf(goi.interp, Jim_SetResultFormatted(goi.interp,
"usage: %s [phys] <address> [<count>]", cmd_name); "usage: %s [phys] <address> [<count>]", cmd_name);
return JIM_ERR; return JIM_ERR;
} }
@ -4118,40 +4120,42 @@ static int jim_target_md(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
} }
e = fn(target, a, b, y / b, target_buf); e = fn(target, a, b, y / b, target_buf);
if (e != ERROR_OK) { if (e != ERROR_OK) {
Jim_SetResult_sprintf(interp, "error reading target @ 0x%08lx", (int)(a)); char tmp[10];
snprintf(tmp, sizeof(tmp), "%08lx", (long)a);
Jim_SetResultFormatted(interp, "error reading target @ 0x%s", tmp);
return JIM_ERR; return JIM_ERR;
} }
Jim_fprintf(interp, interp->cookie_stdout, "0x%08x ", (int)(a)); command_print(NULL, "0x%08x ", (int)(a));
switch (b) { switch (b) {
case 4: case 4:
for (x = 0; x < 16 && x < y; x += 4) for (x = 0; x < 16 && x < y; x += 4)
{ {
z = target_buffer_get_u32(target, &(target_buf[ x ])); z = target_buffer_get_u32(target, &(target_buf[ x ]));
Jim_fprintf(interp, interp->cookie_stdout, "%08x ", (int)(z)); command_print(NULL, "%08x ", (int)(z));
} }
for (; (x < 16) ; x += 4) { for (; (x < 16) ; x += 4) {
Jim_fprintf(interp, interp->cookie_stdout, " "); command_print(NULL, " ");
} }
break; break;
case 2: case 2:
for (x = 0; x < 16 && x < y; x += 2) for (x = 0; x < 16 && x < y; x += 2)
{ {
z = target_buffer_get_u16(target, &(target_buf[ x ])); z = target_buffer_get_u16(target, &(target_buf[ x ]));
Jim_fprintf(interp, interp->cookie_stdout, "%04x ", (int)(z)); command_print(NULL, "%04x ", (int)(z));
} }
for (; (x < 16) ; x += 2) { for (; (x < 16) ; x += 2) {
Jim_fprintf(interp, interp->cookie_stdout, " "); command_print(NULL, " ");
} }
break; break;
case 1: case 1:
default: default:
for (x = 0 ; (x < 16) && (x < y) ; x += 1) { for (x = 0 ; (x < 16) && (x < y) ; x += 1) {
z = target_buffer_get_u8(target, &(target_buf[ x ])); z = target_buffer_get_u8(target, &(target_buf[ x ]));
Jim_fprintf(interp, interp->cookie_stdout, "%02x ", (int)(z)); command_print(NULL, "%02x ", (int)(z));
} }
for (; (x < 16) ; x += 1) { for (; (x < 16) ; x += 1) {
Jim_fprintf(interp, interp->cookie_stdout, " "); command_print(NULL, " ");
} }
break; break;
} }
@ -4173,7 +4177,7 @@ static int jim_target_md(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
/* terminate */ /* terminate */
target_buf[16] = 0; target_buf[16] = 0;
/* print - with a newline */ /* print - with a newline */
Jim_fprintf(interp, interp->cookie_stdout, "%s\n", target_buf); command_print(NULL, "%s\n", target_buf);
/* NEXT... */ /* NEXT... */
c -= 16; c -= 16;
a += 16; a += 16;
@ -4197,7 +4201,7 @@ static int jim_target_array2mem(Jim_Interp *interp,
static int jim_target_tap_disabled(Jim_Interp *interp) static int jim_target_tap_disabled(Jim_Interp *interp)
{ {
Jim_SetResult_sprintf(interp, "[TAP is disabled]"); Jim_SetResultFormatted(interp, "[TAP is disabled]");
return JIM_ERR; return JIM_ERR;
} }
@ -4215,7 +4219,9 @@ static int jim_target_examine(Jim_Interp *interp, int argc, Jim_Obj *const *argv
int e = target->type->examine(target); int e = target->type->examine(target);
if (e != ERROR_OK) if (e != ERROR_OK)
{ {
Jim_SetResult_sprintf(interp, "examine-fails: %d", e); Jim_Obj *eObj = Jim_NewIntObj(interp, e);
Jim_SetResultFormatted(interp, "examine-fails: %#s", eObj);
Jim_FreeNewObj(interp, eObj);
return JIM_ERR; return JIM_ERR;
} }
return JIM_OK; return JIM_OK;
@ -4255,7 +4261,9 @@ static int jim_target_poll(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
} }
if (e != ERROR_OK) if (e != ERROR_OK)
{ {
Jim_SetResult_sprintf(interp, "poll-fails: %d", e); Jim_Obj *eObj = Jim_NewIntObj(interp, e);
Jim_SetResultFormatted(interp, "poll-fails: %#s", eObj);
Jim_FreeNewObj(interp, eObj);
return JIM_ERR; return JIM_ERR;
} }
return JIM_OK; return JIM_OK;
@ -4296,7 +4304,7 @@ static int jim_target_reset(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
} }
if (!target->type->assert_reset || !target->type->deassert_reset) if (!target->type->assert_reset || !target->type->deassert_reset)
{ {
Jim_SetResult_sprintf(interp, Jim_SetResultFormatted(interp,
"No target-specific reset for %s", "No target-specific reset for %s",
target_name(target)); target_name(target));
return JIM_ERR; return JIM_ERR;
@ -4337,7 +4345,7 @@ static int jim_target_wait_state(Jim_Interp *interp, int argc, Jim_Obj *const *a
if (goi.argc != 2) if (goi.argc != 2)
{ {
const char *cmd_name = Jim_GetString(argv[0], NULL); const char *cmd_name = Jim_GetString(argv[0], NULL);
Jim_SetResult_sprintf(goi.interp, Jim_SetResultFormatted(goi.interp,
"%s <state_name> <timeout_in_msec>", cmd_name); "%s <state_name> <timeout_in_msec>", cmd_name);
return JIM_ERR; return JIM_ERR;
} }
@ -4360,10 +4368,12 @@ static int jim_target_wait_state(Jim_Interp *interp, int argc, Jim_Obj *const *a
e = target_wait_state(target, n->value, a); e = target_wait_state(target, n->value, a);
if (e != ERROR_OK) if (e != ERROR_OK)
{ {
Jim_SetResult_sprintf(goi.interp, Jim_Obj *eObj = Jim_NewIntObj(interp, e);
"target: %s wait %s fails (%d) %s", Jim_SetResultFormatted(goi.interp,
"target: %s wait %s fails (%#s) %s",
target_name(target), n->name, target_name(target), n->name,
e, target_strerror_safe(e)); eObj, target_strerror_safe(e));
Jim_FreeNewObj(interp, eObj);
return JIM_ERR; return JIM_ERR;
} }
return JIM_OK; return JIM_OK;
@ -4412,7 +4422,7 @@ static int jim_target_invoke_event(Jim_Interp *interp, int argc, Jim_Obj *const
if (goi.argc != 1) if (goi.argc != 1)
{ {
const char *cmd_name = Jim_GetString(argv[0], NULL); const char *cmd_name = Jim_GetString(argv[0], NULL);
Jim_SetResult_sprintf(goi.interp, "%s <eventname>", cmd_name); Jim_SetResultFormatted(goi.interp, "%s <eventname>", cmd_name);
return JIM_ERR; return JIM_ERR;
} }
Jim_Nvp *n; Jim_Nvp *n;
@ -4583,7 +4593,7 @@ static int target_create(Jim_GetOptInfo *goi)
cmd = Jim_GetCommand(goi->interp, new_cmd, JIM_ERRMSG); cmd = Jim_GetCommand(goi->interp, new_cmd, JIM_ERRMSG);
if (cmd) { if (cmd) {
cp = Jim_GetString(new_cmd, NULL); cp = Jim_GetString(new_cmd, NULL);
Jim_SetResult_sprintf(goi->interp, "Command/target: %s Exists", cp); Jim_SetResultFormatted(goi->interp, "Command/target: %s Exists", cp);
return JIM_ERR; return JIM_ERR;
} }
@ -4598,7 +4608,7 @@ static int target_create(Jim_GetOptInfo *goi)
} }
} }
if (target_types[x] == NULL) { if (target_types[x] == NULL) {
Jim_SetResult_sprintf(goi->interp, "Unknown target type %s, try one of ", cp); Jim_SetResultFormatted(goi->interp, "Unknown target type %s, try one of ", cp);
for (x = 0 ; target_types[x] ; x++) { for (x = 0 ; target_types[x] ; x++) {
if (target_types[x + 1]) { if (target_types[x + 1]) {
Jim_AppendStrings(goi->interp, Jim_AppendStrings(goi->interp,
@ -4808,7 +4818,7 @@ static int jim_target_number(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
LOG_WARNING("don't use numbers as target identifiers; use names"); LOG_WARNING("don't use numbers as target identifiers; use names");
if (goi.argc != 1) if (goi.argc != 1)
{ {
Jim_SetResult_sprintf(goi.interp, "usage: target number <number>"); Jim_SetResultFormatted(goi.interp, "usage: target number <number>");
return JIM_ERR; return JIM_ERR;
} }
jim_wide w; jim_wide w;
@ -4825,8 +4835,12 @@ static int jim_target_number(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
Jim_SetResultString(goi.interp, target_name(target), -1); Jim_SetResultString(goi.interp, target_name(target), -1);
return JIM_OK; return JIM_OK;
} }
Jim_SetResult_sprintf(goi.interp, {
"Target: number %d does not exist", (int)(w)); Jim_Obj *wObj = Jim_NewIntObj(goi.interp, w);
Jim_SetResultFormatted(goi.interp,
"Target: number %#s does not exist", wObj);
Jim_FreeNewObj(interp, wObj);
}
return JIM_ERR; return JIM_ERR;
} }

1
src/target/target_type.h
View File

@ -27,6 +27,7 @@
#define TARGET_TYPE_H #define TARGET_TYPE_H
#include <helper/types.h> #include <helper/types.h>
#include <jim-nvp.h>
struct target; struct target;