interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

smp: Fix byte order bug 

Found by grepping for pointer casts.

Also rewrite to reduce scope and allocate the few bytes needed on stack
instead of on heap.

Change-Id: Ia2a369fb612e807b981ee60ebcfd9c09c2fbdf4c
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1779
Tested-by: jenkins
Reviewed-by: Mathias Küster <kesmtp@freenet.de>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
This commit is contained in:
Andreas Fritiofson 2013-09-30 23:33:59 +02:00 committed by Spencer Oliver
parent 484dbcc302
commit 4f6f065201
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/target/smp.c
View File

@ -59,18 +59,16 @@ int gdb_read_smp_packet(struct connection *connection,
char *packet, int packet_size) char *packet, int packet_size)
{ {
struct target *target = get_target_from_connection(connection); struct target *target = get_target_from_connection(connection);
uint32_t len = sizeof(int32_t);
uint8_t *buffer;
char *hex_buffer;
int retval = ERROR_OK; int retval = ERROR_OK;
if (target->smp) { if (target->smp) {
if (strncmp(packet, "jc", 2) == 0) { if (strncmp(packet, "jc", 2) == 0) {
hex_buffer = malloc(len * 2 + 1); const uint32_t len = sizeof(target->gdb_service->core[0]);
buffer = (uint8_t *)&target->gdb_service->core[0]; char hex_buffer[len * 2 + 1];
int pkt_len = hexify(hex_buffer, (char *)buffer, len, len * 2 + 1); char buffer[len];
buf_set_u32(buffer, 0, len * 8, target->gdb_service->core[0]);
int pkt_len = hexify(hex_buffer, buffer, sizeof(buffer), sizeof(hex_buffer));
retval = gdb_put_packet(connection, hex_buffer, pkt_len); retval = gdb_put_packet(connection, hex_buffer, pkt_len);
free(hex_buffer);
} }
} else } else
retval = gdb_put_packet(connection, "E01", 3); retval = gdb_put_packet(connection, "E01", 3);