interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

target/register: Minor code cleanup 

Change-Id: Ie02a112c0339ae5d3b3763483e493370b487be98
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/6294
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
This commit is contained in:
Marc Schink 2021-06-04 14:31:57 +02:00 committed by Antonio Borneo
parent f5898bd93f
commit 4bb1d8b45e
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/target/register.c
View File

@ -39,21 +39,20 @@
struct reg *register_get_by_number(struct reg_cache *first, struct reg *register_get_by_number(struct reg_cache *first,
uint32_t reg_num, bool search_all) uint32_t reg_num, bool search_all)
{ {
unsigned i;
struct reg_cache *cache = first; struct reg_cache *cache = first;
while (cache) { while (cache) {
for (i = 0; i < cache->num_regs; i++) { for (unsigned int i = 0; i < cache->num_regs; i++) {
if (cache->reg_list[i].exist == false) if (!cache->reg_list[i].exist)
continue; continue;
if (cache->reg_list[i].number == reg_num) if (cache->reg_list[i].number == reg_num)
return &(cache->reg_list[i]); return &(cache->reg_list[i]);
} }
if (search_all) if (!search_all)
cache = cache->next;
else
break; break;
cache = cache->next;
} }
return NULL; return NULL;
@ -62,21 +61,20 @@ struct reg *register_get_by_number(struct reg_cache *first,
struct reg *register_get_by_name(struct reg_cache *first, struct reg *register_get_by_name(struct reg_cache *first,
const char *name, bool search_all) const char *name, bool search_all)
{ {
unsigned i;
struct reg_cache *cache = first; struct reg_cache *cache = first;
while (cache) { while (cache) {
for (i = 0; i < cache->num_regs; i++) { for (unsigned int i = 0; i < cache->num_regs; i++) {
if (cache->reg_list[i].exist == false) if (!cache->reg_list[i].exist)
continue; continue;
if (strcmp(cache->reg_list[i].name, name) == 0) if (strcmp(cache->reg_list[i].name, name) == 0)
return &(cache->reg_list[i]); return &(cache->reg_list[i]);
} }
if (search_all) if (!search_all)
cache = cache->next;
else
break; break;
cache = cache->next;
} }
return NULL; return NULL;
@ -108,8 +106,8 @@ void register_cache_invalidate(struct reg_cache *cache)
{ {
struct reg *reg = cache->reg_list; struct reg *reg = cache->reg_list;
for (unsigned n = cache->num_regs; n != 0; n--, reg++) { for (unsigned int n = cache->num_regs; n != 0; n--, reg++) {
if (reg->exist == false) if (!reg->exist)
continue; continue;
reg->valid = false; reg->valid = false;
reg->dirty = false; reg->dirty = false;