interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

target: fix minor typos and duplicated words 

Change-Id: I8deb0017dc66a243e3dd51e285aa086db500decd
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5766
Tested-by: jenkins
This commit is contained in:
Antonio Borneo 2020-07-12 20:25:00 +02:00
parent 3e6f4f8b21
commit 480ba8ca88
47 changed files with 114 additions and 114 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/target/aarch64.c
View File

@ -2497,7 +2497,7 @@ static int aarch64_jim_configure(struct target *target, Jim_GetOptInfo *goi)
* Call adiv5_jim_configure() to parse the common DAP options * Call adiv5_jim_configure() to parse the common DAP options
* It will return JIM_CONTINUE if it didn't find any known * It will return JIM_CONTINUE if it didn't find any known
* options, JIM_OK if it correctly parsed the topmost option * options, JIM_OK if it correctly parsed the topmost option
* and JIM_ERR if an error occured during parameter evaluation. * and JIM_ERR if an error occurred during parameter evaluation.
* For JIM_CONTINUE, we check our own params. * For JIM_CONTINUE, we check our own params.
*/ */
e = adiv5_jim_configure(target, goi); e = adiv5_jim_configure(target, goi);

14
src/target/arc.c
View File

@ -33,7 +33,7 @@
* unexisting register is safe RAZ, rather then an error. * unexisting register is safe RAZ, rather then an error.
* Note, core registers cannot be BCR. * Note, core registers cannot be BCR.
* *
* In arc/cpu/ tcl files all regiters are defined as core, non-BCR aux * In arc/cpu/ tcl files all registers are defined as core, non-BCR aux
* and BCR aux, in "add-reg" command they are passed to three lists * and BCR aux, in "add-reg" command they are passed to three lists
* respectively: core_reg_descriptions, aux_reg_descriptions, * respectively: core_reg_descriptions, aux_reg_descriptions,
* bcr_reg_descriptions. * bcr_reg_descriptions.
@ -286,7 +286,7 @@ const struct reg_arch_type arc_reg_type = {
.set = arc_set_register, .set = arc_set_register,
}; };
/* GDB register groups. For now we suport only general and "empty" */ /* GDB register groups. For now we support only general and "empty" */
static const char * const reg_group_general = "general"; static const char * const reg_group_general = "general";
static const char * const reg_group_other = ""; static const char * const reg_group_other = "";
@ -548,7 +548,7 @@ int arc_reg_get_field(struct target *target, const char *reg_name,
struct reg *reg = arc_reg_get_by_name(target->reg_cache, reg_name, true); struct reg *reg = arc_reg_get_by_name(target->reg_cache, reg_name, true);
if (!reg) { if (!reg) {
LOG_ERROR("Requested register `%s' doens't exist.", reg_name); LOG_ERROR("Requested register `%s' doesn't exist.", reg_name);
return ERROR_ARC_REGISTER_NOT_FOUND; return ERROR_ARC_REGISTER_NOT_FOUND;
} }
@ -575,7 +575,7 @@ int arc_reg_get_field(struct target *target, const char *reg_name,
if (!reg->valid) if (!reg->valid)
CHECK_RETVAL(reg->type->get(reg)); CHECK_RETVAL(reg->type->get(reg));
/* First do endiannes-safe read of register value /* First do endianness-safe read of register value
* then convert it to binary buffer for further * then convert it to binary buffer for further
* field extraction */ * field extraction */
@ -1396,7 +1396,7 @@ static int arc_target_create(struct target *target, Jim_Interp *interp)
* Write 4-byte instruction to memory. This is like target_write_u32, however * Write 4-byte instruction to memory. This is like target_write_u32, however
* in case of little endian ARC instructions are in middle endian format, not * in case of little endian ARC instructions are in middle endian format, not
* little endian, so different type of conversion should be done. * little endian, so different type of conversion should be done.
* Middle endinan: instruction "aabbccdd", stored as "bbaaddcc" * Middle endian: instruction "aabbccdd", stored as "bbaaddcc"
*/ */
int arc_write_instruction_u32(struct target *target, uint32_t address, int arc_write_instruction_u32(struct target *target, uint32_t address,
uint32_t instr) uint32_t instr)
@ -1800,7 +1800,7 @@ int arc_remove_auxreg_actionpoint(struct target *target, uint32_t auxreg_addr)
return retval; return retval;
} }
/* Helper function which swiches core to single_step mode by /* Helper function which switches core to single_step mode by
* doing aux r/w operations. */ * doing aux r/w operations. */
int arc_config_step(struct target *target, int enable_step) int arc_config_step(struct target *target, int enable_step)
{ {
@ -2081,7 +2081,7 @@ struct target_type arcv2_target = {
.arch_state = arc_arch_state, .arch_state = arc_arch_state,
/* TODO That seems like something similiar to metaware hostlink, so perhaps /* TODO That seems like something similar to metaware hostlink, so perhaps
* we can exploit this in the future. */ * we can exploit this in the future. */
.target_request_data = NULL, .target_request_data = NULL,

24
src/target/arc_cmd.c
View File

@ -86,7 +86,7 @@ static int jim_arc_read_reg_type_field(Jim_GetOptInfo *goi, const char **field_n
int e = JIM_OK; int e = JIM_OK;
if ((type == CFG_ADD_REG_TYPE_STRUCT && goi->argc < 3) || if ((type == CFG_ADD_REG_TYPE_STRUCT && goi->argc < 3) ||
(type == CFG_ADD_REG_TYPE_FLAG && goi->argc < 2)) { (type == CFG_ADD_REG_TYPE_FLAG && goi->argc < 2)) {
Jim_SetResultFormatted(goi->interp, "Not enough argmunets after -flag/-bitfield"); Jim_SetResultFormatted(goi->interp, "Not enough arguments after -flag/-bitfield");
return JIM_ERR; return JIM_ERR;
} }
@ -101,7 +101,7 @@ static int jim_arc_read_reg_type_field(Jim_GetOptInfo *goi, const char **field_n
end_pos = start_pos; end_pos = start_pos;
/* Check if any argnuments remain, /* Check if any arguments remain,
* set bitfields[cur_field].end if flag is multibit */ * set bitfields[cur_field].end if flag is multibit */
if (goi->argc > 0) if (goi->argc > 0)
/* Check current argv[0], if it is equal to "-flag", /* Check current argv[0], if it is equal to "-flag",
@ -143,9 +143,9 @@ static int jim_arc_add_reg_type_flags(Jim_Interp *interp, int argc,
int e = JIM_OK; int e = JIM_OK;
/* Check if the amount of argnuments is not zero */ /* Check if the amount of arguments is not zero */
if (goi.argc <= 0) { if (goi.argc <= 0) {
Jim_SetResultFormatted(goi.interp, "The command has no argnuments"); Jim_SetResultFormatted(goi.interp, "The command has no arguments");
return JIM_ERR; return JIM_ERR;
} }
@ -154,7 +154,7 @@ static int jim_arc_add_reg_type_flags(Jim_Interp *interp, int argc,
unsigned int fields_sz = (goi.argc - 2) / 3; unsigned int fields_sz = (goi.argc - 2) / 3;
unsigned int cur_field = 0; unsigned int cur_field = 0;
/* Tha maximum amount of bitfilds is 32 */ /* The maximum amount of bitfields is 32 */
if (fields_sz > 32) { if (fields_sz > 32) {
Jim_SetResultFormatted(goi.interp, "The amount of bitfields exceed 32"); Jim_SetResultFormatted(goi.interp, "The amount of bitfields exceed 32");
return JIM_ERR; return JIM_ERR;
@ -509,9 +509,9 @@ static int jim_arc_add_reg_type_struct(Jim_Interp *interp, int argc,
int e = JIM_OK; int e = JIM_OK;
/* Check if the amount of argnuments is not zero */ /* Check if the amount of arguments is not zero */
if (goi.argc <= 0) { if (goi.argc <= 0) {
Jim_SetResultFormatted(goi.interp, "The command has no argnuments"); Jim_SetResultFormatted(goi.interp, "The command has no arguments");
return JIM_ERR; return JIM_ERR;
} }
@ -520,7 +520,7 @@ static int jim_arc_add_reg_type_struct(Jim_Interp *interp, int argc,
unsigned int fields_sz = (goi.argc - 2) / 4; unsigned int fields_sz = (goi.argc - 2) / 4;
unsigned int cur_field = 0; unsigned int cur_field = 0;
/* Tha maximum amount of bitfilds is 32 */ /* The maximum amount of bitfields is 32 */
if (fields_sz > 32) { if (fields_sz > 32) {
Jim_SetResultFormatted(goi.interp, "The amount of bitfields exceed 32"); Jim_SetResultFormatted(goi.interp, "The amount of bitfields exceed 32");
return JIM_ERR; return JIM_ERR;
@ -672,19 +672,19 @@ static int jim_arc_add_reg(Jim_Interp *interp, int argc, Jim_Obj * const *argv)
} }
/* There is no architecture number that we could treat as invalid, so /* There is no architecture number that we could treat as invalid, so
* separate variable requried to ensure that arch num has been set. */ * separate variable required to ensure that arch num has been set. */
bool arch_num_set = false; bool arch_num_set = false;
const char *type_name = "int"; /* Default type */ const char *type_name = "int"; /* Default type */
int type_name_len = strlen(type_name); int type_name_len = strlen(type_name);
int e = ERROR_OK; int e = ERROR_OK;
/* At least we need to specify 4 parameters: name, number and gdb_feature, /* At least we need to specify 4 parameters: name, number and gdb_feature,
* which means there should be 6 arguments. Also there can be additional paramters * which means there should be 6 arguments. Also there can be additional parameters
* "-type <type>", "-g" and "-core" or "-bcr" which makes maximum 10 parameters. */ * "-type <type>", "-g" and "-core" or "-bcr" which makes maximum 10 parameters. */
if (goi.argc < 6 || goi.argc > 10) { if (goi.argc < 6 || goi.argc > 10) {
free_reg_desc(reg); free_reg_desc(reg);
Jim_SetResultFormatted(goi.interp, Jim_SetResultFormatted(goi.interp,
"Should be at least 6 argnuments and not greater than 10: " "Should be at least 6 arguments and not greater than 10: "
" -name <name> -num <num> -feature <gdb_feature> " " -name <name> -num <num> -feature <gdb_feature> "
" [-type <type_name>] [-core|-bcr] [-g]."); " [-type <type_name>] [-core|-bcr] [-g].");
return JIM_ERR; return JIM_ERR;
@ -1035,7 +1035,7 @@ static const struct command_registration arc_core_command_handlers[] = {
.usage = "arc add-reg -name <string> -num <int> -feature <string> [-gdbnum <int>] " .usage = "arc add-reg -name <string> -num <int> -feature <string> [-gdbnum <int>] "
"[-core|-bcr] [-type <type_name>] [-g]", "[-core|-bcr] [-type <type_name>] [-g]",
.help = "Add new register. Name, architectural number and feature name " .help = "Add new register. Name, architectural number and feature name "
"are requried options. GDB regnum will default to previous register " "are required options. GDB regnum will default to previous register "
"(gdbnum + 1) and shouldn't be specified in most cases. Type " "(gdbnum + 1) and shouldn't be specified in most cases. Type "
"defaults to default GDB 'int'.", "defaults to default GDB 'int'.",
}, },

4
src/target/arc_jtag.c
View File

@ -158,7 +158,7 @@ static void arc_jtag_enque_status_read(struct arc_jtag * const jtag_info,
assert(jtag_info->tap); assert(jtag_info->tap);
assert(buffer); assert(buffer);
/* first writin code(0x8) of jtag status register in IR */ /* first writing code(0x8) of jtag status register in IR */
arc_jtag_enque_write_ir(jtag_info, ARC_JTAG_STATUS_REG); arc_jtag_enque_write_ir(jtag_info, ARC_JTAG_STATUS_REG);
/* Now reading dr performs jtag status register read */ /* Now reading dr performs jtag status register read */
arc_jtag_enque_read_dr(jtag_info, buffer, TAP_IDLE); arc_jtag_enque_read_dr(jtag_info, buffer, TAP_IDLE);
@ -223,7 +223,7 @@ static void arc_jtag_enque_register_rw(struct arc_jtag *jtag_info, uint32_t *add
else else
arc_jtag_enque_read_dr(jtag_info, read_buffer + i * 4, TAP_IDLE); arc_jtag_enque_read_dr(jtag_info, read_buffer + i * 4, TAP_IDLE);
} }
/* To prevent pollution of next regiter due to optimization it is necessary * /* To prevent pollution of next register due to optimization it is necessary *
* to reset transaction */ * to reset transaction */
arc_jtag_enque_reset_transaction(jtag_info); arc_jtag_enque_reset_transaction(jtag_info);
} }

10
src/target/arc_mem.c
View File

@ -75,8 +75,8 @@ static int arc_mem_write_block16(struct target *target, uint32_t addr,
/* We will read data from memory, so we need to flush the cache. */ /* We will read data from memory, so we need to flush the cache. */
CHECK_RETVAL(arc_cache_flush(target)); CHECK_RETVAL(arc_cache_flush(target));
/* non-word writes are less common, than 4-byte writes, so I suppose we can /* non-word writes are less common than 4-byte writes, so I suppose we can
* allowe ourselves to write this in a cycle, instead of calling arc_jtag * allow ourselves to write this in a cycle, instead of calling arc_jtag
* with count > 1. */ * with count > 1. */
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
/* We can read only word at word-aligned address. Also *jtag_read_memory /* We can read only word at word-aligned address. Also *jtag_read_memory
@ -130,8 +130,8 @@ static int arc_mem_write_block8(struct target *target, uint32_t addr,
/* We will read data from memory, so we need to flush the cache. */ /* We will read data from memory, so we need to flush the cache. */
CHECK_RETVAL(arc_cache_flush(target)); CHECK_RETVAL(arc_cache_flush(target));
/* non-word writes are less common, than 4-byte writes, so I suppose we can /* non-word writes are less common than 4-byte writes, so I suppose we can
* allowe ourselves to write this in a cycle, instead of calling arc_jtag * allow ourselves to write this in a cycle, instead of calling arc_jtag
* with count > 1. */ * with count > 1. */
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
/* See comment in arc_mem_write_block16 for details. Since it is a byte /* See comment in arc_mem_write_block16 for details. Since it is a byte
@ -173,7 +173,7 @@ int arc_mem_write(struct target *target, target_addr_t address, uint32_t size,
if (((size == 4) && (address & 0x3u)) || ((size == 2) && (address & 0x1u))) if (((size == 4) && (address & 0x3u)) || ((size == 2) && (address & 0x1u)))
return ERROR_TARGET_UNALIGNED_ACCESS; return ERROR_TARGET_UNALIGNED_ACCESS;
/* correct endianess if we have word or hword access */ /* correct endianness if we have word or hword access */
if (size > 1) { if (size > 1) {
/* /*
* arc_..._write_mem with size 4/2 requires uint32_t/uint16_t * arc_..._write_mem with size 4/2 requires uint32_t/uint16_t

6
src/target/arm7_9_common.c
View File

@ -55,8 +55,8 @@
* shadowed registers, and support for the Thumb instruction set. * shadowed registers, and support for the Thumb instruction set.
* *
* Processor differences include things like presence or absence of MMU * Processor differences include things like presence or absence of MMU
* and cache, pipeline sizes, use of a modified Harvard Architecure * and cache, pipeline sizes, use of a modified Harvard Architecture
* (with separate instruction and data busses from the CPU), support * (with separate instruction and data buses from the CPU), support
* for cpu clock gating during idle, and more. * for cpu clock gating during idle, and more.
*/ */
@ -1009,7 +1009,7 @@ int arm7_9_deassert_reset(struct target *target)
/** /**
* Clears the halt condition for an ARM7/9 target. If it isn't coming out of * Clears the halt condition for an ARM7/9 target. If it isn't coming out of
* reset and if DBGRQ is used, it is progammed to be deasserted. If the reset * reset and if DBGRQ is used, it is programmed to be deasserted. If the reset
* vector catch was used, it is restored. Otherwise, the control value is * vector catch was used, it is restored. Otherwise, the control value is
* restored and the watchpoint unit is restored if it was in use. * restored and the watchpoint unit is restored if it was in use.
* *

4
src/target/arm946e.c
View File

@ -45,7 +45,7 @@
/** /**
* flag to give info about cache manipulation during debug : * flag to give info about cache manipulation during debug :
* "0" - cache lines are invalidated "on the fly", for affected addresses. * "0" - cache lines are invalidated "on the fly", for affected addresses.
* This is prefered from performance point of view. * This is preferred from performance point of view.
* "1" - cache is invalidated and switched off on debug_entry, and switched back on on restore. * "1" - cache is invalidated and switched off on debug_entry, and switched back on on restore.
* It is kept off during debugging. * It is kept off during debugging.
*/ */
@ -261,7 +261,7 @@ uint32_t arm946e_invalidate_whole_dcache(struct target *target)
*/ */
int nb_idx = (csize / (4*8*NB_CACHE_WAYS)); /* gives nb of lines (indexes) in the cache */ int nb_idx = (csize / (4*8*NB_CACHE_WAYS)); /* gives nb of lines (indexes) in the cache */
/* Loop for all segmentde (i.e. ways) */ /* Loop for all segments (i.e. ways) */
uint32_t seg; uint32_t seg;
for (seg = 0; seg < NB_CACHE_WAYS; seg++) { for (seg = 0; seg < NB_CACHE_WAYS; seg++) {
/* Loop for all indexes */ /* Loop for all indexes */

4
src/target/arm_adi_v5.c
View File

@ -51,7 +51,7 @@
* is set in the DP_CTRL_STAT register, the SSTICKYORUN status is set and * is set in the DP_CTRL_STAT register, the SSTICKYORUN status is set and
* further AP operations will fail. There are two basic methods to avoid * further AP operations will fail. There are two basic methods to avoid
* such overrun errors. One involves polling for status instead of using * such overrun errors. One involves polling for status instead of using
* transaction piplining. The other involves adding delays to ensure the * transaction pipelining. The other involves adding delays to ensure the
* AP has enough time to complete one operation before starting the next * AP has enough time to complete one operation before starting the next
* one. (For JTAG these delays are controlled by memaccess_tck.) * one. (For JTAG these delays are controlled by memaccess_tck.)
*/ */
@ -872,7 +872,7 @@ int dap_find_ap(struct adiv5_dap *dap, enum ap_type type_to_find, struct adiv5_a
* 3-0 : AP Type (0=JTAG-AP 1=AHB-AP 2=APB-AP 4=AXI-AP) * 3-0 : AP Type (0=JTAG-AP 1=AHB-AP 2=APB-AP 4=AXI-AP)
*/ */
/* Reading register for a non-existant AP should not cause an error, /* Reading register for a non-existent AP should not cause an error,
* but just to be sure, try to continue searching if an error does happen. * but just to be sure, try to continue searching if an error does happen.
*/ */
if ((retval == ERROR_OK) && /* Register read success */ if ((retval == ERROR_OK) && /* Register read success */

8
src/target/arm_disassembler.c
View File

@ -92,8 +92,8 @@
* the Cortex-M implementations). * the Cortex-M implementations).
*/ */
/* textual represenation of the condition field /* textual representation of the condition field
* ALways (default) is ommitted (empty string) */ * ALways (default) is omitted (empty string) */
static const char *arm_condition_strings[] = { static const char *arm_condition_strings[] = {
"EQ", "NE", "CS", "CC", "MI", "PL", "VS", "VC", "HI", "LS", "GE", "LT", "GT", "LE", "", "NV" "EQ", "NE", "CS", "CC", "MI", "PL", "VS", "VC", "HI", "LS", "GE", "LT", "GT", "LE", "", "NV"
}; };
@ -2896,7 +2896,7 @@ int thumb_evaluate_opcode(uint16_t opcode, uint32_t address, struct arm_instruct
instruction->instruction_size = 2; instruction->instruction_size = 2;
if ((opcode & 0xe000) == 0x0000) { if ((opcode & 0xe000) == 0x0000) {
/* add/substract register or immediate */ /* add/subtract register or immediate */
if ((opcode & 0x1800) == 0x1800) if ((opcode & 0x1800) == 0x1800)
return evaluate_add_sub_thumb(opcode, address, instruction); return evaluate_add_sub_thumb(opcode, address, instruction);
/* shift by immediate */ /* shift by immediate */
@ -2904,7 +2904,7 @@ int thumb_evaluate_opcode(uint16_t opcode, uint32_t address, struct arm_instruct
return evaluate_shift_imm_thumb(opcode, address, instruction); return evaluate_shift_imm_thumb(opcode, address, instruction);
} }
/* Add/substract/compare/move immediate */ /* Add/subtract/compare/move immediate */
if ((opcode & 0xe000) == 0x2000) if ((opcode & 0xe000) == 0x2000)
return evaluate_data_proc_imm_thumb(opcode, address, instruction); return evaluate_data_proc_imm_thumb(opcode, address, instruction);

4
src/target/arm_dpm.c
View File

@ -206,7 +206,7 @@ int arm_dpm_read_reg(struct arm_dpm *dpm, struct reg *r, unsigned regnum)
LOG_WARNING("Jazelle PC adjustment unknown"); LOG_WARNING("Jazelle PC adjustment unknown");
break; break;
default: default:
LOG_WARNING("unknow core state"); LOG_WARNING("unknown core state");
break; break;
} }
break; break;
@ -335,7 +335,7 @@ static int dpm_write_pc_core_state(struct arm_dpm *dpm, struct reg *r)
} }
/** /**
* Read basic registers of the the current context: R0 to R15, and CPSR; * Read basic registers of the current context: R0 to R15, and CPSR;
* sets the core mode (such as USR or IRQ) and state (such as ARM or Thumb). * sets the core mode (such as USR or IRQ) and state (such as ARM or Thumb).
* In normal operation this is called on entry to halting debug state, * In normal operation this is called on entry to halting debug state,
* possibly after some other operations supporting restore of debug state * possibly after some other operations supporting restore of debug state

4
src/target/arm_opcodes.h
View File

@ -38,7 +38,7 @@
/* Store multiple increment after /* Store multiple increment after
* Rn: base register * Rn: base register
* List: for each bit in list: store register * List: for each bit in list: store register
* S: in priviledged mode: store user-mode registers * S: in privileged mode: store user-mode registers
* W = 1: update the base register. W = 0: leave the base register untouched * W = 1: update the base register. W = 0: leave the base register untouched
*/ */
#define ARMV4_5_STMIA(Rn, List, S, W) \ #define ARMV4_5_STMIA(Rn, List, S, W) \
@ -47,7 +47,7 @@
/* Load multiple increment after /* Load multiple increment after
* Rn: base register * Rn: base register
* List: for each bit in list: store register * List: for each bit in list: store register
* S: in priviledged mode: store user-mode registers * S: in privileged mode: store user-mode registers
* W = 1: update the base register. W = 0: leave the base register untouched * W = 1: update the base register. W = 0: leave the base register untouched
*/ */
#define ARMV4_5_LDMIA(Rn, List, S, W) \ #define ARMV4_5_LDMIA(Rn, List, S, W) \

2
src/target/armv7a.c
View File

@ -160,7 +160,7 @@ int armv7a_read_ttbcr(struct target *target)
} }
/* /*
* ARM Architecture Reference Manual (ARMv7-A and ARMv7-Redition), * ARM Architecture Reference Manual (ARMv7-A and ARMv7-R edition),
* document # ARM DDI 0406C * document # ARM DDI 0406C
*/ */
armv7a->armv7a_mmu.ttbr_range[0] = 0xffffffff >> ttbcr_n; armv7a->armv7a_mmu.ttbr_range[0] = 0xffffffff >> ttbcr_n;

2
src/target/armv7a.h
View File

@ -48,7 +48,7 @@ struct armv7a_l2x_cache {
}; };
struct armv7a_cachesize { struct armv7a_cachesize {
/* cache dimensionning */ /* cache dimensioning */
uint32_t linelen; uint32_t linelen;
uint32_t associativity; uint32_t associativity;
uint32_t nsets; uint32_t nsets;

4
src/target/armv7a_cache.c
View File

@ -409,7 +409,7 @@ int armv7a_cache_flush_virt(struct target *target, uint32_t virt,
* We assume that target core was chosen correctly. It means if same data * We assume that target core was chosen correctly. It means if same data
* was handled by two cores, other core will loose the changes. Since it * was handled by two cores, other core will loose the changes. Since it
* is impossible to know (FIXME) which core has correct data, keep in mind * is impossible to know (FIXME) which core has correct data, keep in mind
* that some kind of data lost or korruption is possible. * that some kind of data lost or corruption is possible.
* Possible scenario: * Possible scenario:
* - core1 loaded and changed data on 0x12345678 * - core1 loaded and changed data on 0x12345678
* - we halted target and modified same data on core0 * - we halted target and modified same data on core0
@ -577,7 +577,7 @@ const struct command_registration arm7a_l1_di_cache_group_handlers[] = {
.name = "info", .name = "info",
.handler = arm7a_l1_cache_info_cmd, .handler = arm7a_l1_cache_info_cmd,
.mode = COMMAND_ANY, .mode = COMMAND_ANY,
.help = "print cache realted information", .help = "print cache related information",
.usage = "", .usage = "",
}, },
{ {

2
src/target/armv7a_cache_l2x.c
View File

@ -332,7 +332,7 @@ static const struct command_registration arm7a_l2x_cache_commands[] = {
.name = "info", .name = "info",
.handler = arm7a_l2x_cache_info_command, .handler = arm7a_l2x_cache_info_command,
.mode = COMMAND_ANY, .mode = COMMAND_ANY,
.help = "print cache realted information", .help = "print cache related information",
.usage = "", .usage = "",
}, },
{ {

2
src/target/armv7m_trace.h
View File

@ -56,7 +56,7 @@ struct armv7m_trace_config {
/** Synchronous output port width */ /** Synchronous output port width */
uint32_t port_size; uint32_t port_size;
/** Bitmask of currenty enabled ITM stimuli */ /** Bitmask of currently enabled ITM stimuli */
uint32_t itm_ter[8]; uint32_t itm_ter[8];
/** Identifier for multi-source trace stream formatting */ /** Identifier for multi-source trace stream formatting */
unsigned int trace_bus_id; unsigned int trace_bus_id;

8
src/target/armv8.c
View File

@ -795,7 +795,7 @@ static uint8_t armv8_pa_size(uint32_t ps)
ret = 48; ret = 48;
break; break;
default: default:
LOG_INFO("Unknow physicall address size"); LOG_INFO("Unknown physical address size");
break; break;
} }
return ret; return ret;
@ -822,7 +822,7 @@ static __attribute__((unused)) int armv8_read_ttbcr32(struct target *target)
armv8->armv8_mmu.ttbcr = ttbcr; armv8->armv8_mmu.ttbcr = ttbcr;
/* /*
* ARM Architecture Reference Manual (ARMv7-A and ARMv7-Redition), * ARM Architecture Reference Manual (ARMv7-A and ARMv7-R edition),
* document # ARM DDI 0406C * document # ARM DDI 0406C
*/ */
armv8->armv8_mmu.ttbr_range[0] = 0xffffffff >> ttbcr_n; armv8->armv8_mmu.ttbr_range[0] = 0xffffffff >> ttbcr_n;
@ -852,7 +852,7 @@ static __attribute__((unused)) int armv8_read_ttbcr(struct target *target)
if (retval != ERROR_OK) if (retval != ERROR_OK)
goto done; goto done;
/* claaer ttrr1_used and ttbr0_mask */ /* clear ttrr1_used and ttbr0_mask */
memset(&armv8->armv8_mmu.ttbr1_used, 0, sizeof(armv8->armv8_mmu.ttbr1_used)); memset(&armv8->armv8_mmu.ttbr1_used, 0, sizeof(armv8->armv8_mmu.ttbr1_used));
memset(&armv8->armv8_mmu.ttbr0_mask, 0, sizeof(armv8->armv8_mmu.ttbr0_mask)); memset(&armv8->armv8_mmu.ttbr0_mask, 0, sizeof(armv8->armv8_mmu.ttbr0_mask));
@ -902,7 +902,7 @@ static __attribute__((unused)) int armv8_read_ttbcr(struct target *target)
goto done; goto done;
break; break;
default: default:
LOG_ERROR("unknow core state"); LOG_ERROR("unknown core state");
retval = ERROR_FAIL; retval = ERROR_FAIL;
break; break;
} }

2
src/target/armv8.h
View File

@ -139,7 +139,7 @@ struct armv8_l2x_cache {
struct armv8_cachesize { struct armv8_cachesize {
uint32_t level_num; uint32_t level_num;
/* cache dimensionning */ /* cache dimensioning */
uint32_t linelen; uint32_t linelen;
uint32_t associativity; uint32_t associativity;
uint32_t nsets; uint32_t nsets;

2
src/target/armv8_dpm.c
View File

@ -731,7 +731,7 @@ static int dpmv8_write_reg(struct arm_dpm *dpm, struct reg *r, unsigned regnum)
} }
/** /**
* Read basic registers of the the current context: R0 to R15, and CPSR; * Read basic registers of the current context: R0 to R15, and CPSR;
* sets the core mode (such as USR or IRQ) and state (such as ARM or Thumb). * sets the core mode (such as USR or IRQ) and state (such as ARM or Thumb).
* In normal operation this is called on entry to halting debug state, * In normal operation this is called on entry to halting debug state,
* possibly after some other operations supporting restore of debug state * possibly after some other operations supporting restore of debug state

4
src/target/avrt.c
View File

@ -195,7 +195,7 @@ static int mcu_write_ir_u8(struct jtag_tap *tap, uint8_t *ir_in,
uint8_t ir_out, int ir_len, int rti) uint8_t ir_out, int ir_len, int rti)
{ {
if (ir_len > 8) { if (ir_len > 8) {
LOG_ERROR("ir_len overflow, maxium is 8"); LOG_ERROR("ir_len overflow, maximum is 8");
return ERROR_FAIL; return ERROR_FAIL;
} }
@ -208,7 +208,7 @@ static int mcu_write_dr_u32(struct jtag_tap *tap, uint32_t *dr_in,
uint32_t dr_out, int dr_len, int rti) uint32_t dr_out, int dr_len, int rti)
{ {
if (dr_len > 32) { if (dr_len > 32) {
LOG_ERROR("dr_len overflow, maxium is 32"); LOG_ERROR("dr_len overflow, maximum is 32");
return ERROR_FAIL; return ERROR_FAIL;
} }

2
src/target/cortex_a.c
View File

@ -841,7 +841,7 @@ static int cortex_a_internal_restore(struct target *target, int current,
LOG_ERROR("How do I resume into Jazelle state??"); LOG_ERROR("How do I resume into Jazelle state??");
return ERROR_FAIL; return ERROR_FAIL;
case ARM_STATE_AARCH64: case ARM_STATE_AARCH64:
LOG_ERROR("Shoudn't be in AARCH64 state"); LOG_ERROR("Shouldn't be in AARCH64 state");
return ERROR_FAIL; return ERROR_FAIL;
} }
LOG_DEBUG("resume pc = 0x%08" PRIx32, resume_pc); LOG_DEBUG("resume pc = 0x%08" PRIx32, resume_pc);

4
src/target/cortex_m.c
View File

@ -113,7 +113,7 @@ static int cortexm_dap_write_coreregister_u32(struct target *target,
return retval; return retval;
if (target->dbg_msg_enabled) { if (target->dbg_msg_enabled) {
/* restore DCB_DCRDR - this needs to be in a seperate /* restore DCB_DCRDR - this needs to be in a separate
* transaction otherwise the emulated DCC channel breaks */ * transaction otherwise the emulated DCC channel breaks */
if (retval == ERROR_OK) if (retval == ERROR_OK)
retval = mem_ap_write_atomic_u32(armv7m->debug_ap, DCB_DCRDR, dcrdr); retval = mem_ap_write_atomic_u32(armv7m->debug_ap, DCB_DCRDR, dcrdr);
@ -951,7 +951,7 @@ static int cortex_m_step(struct target *target, int current,
* just step over the instruction with interrupts disabled. * just step over the instruction with interrupts disabled.
* *
* The documentation has no information about this, it was found by observation * The documentation has no information about this, it was found by observation
* on STM32F1 and STM32F2. Proper explanation welcome. STM32F0 dosen't seem to * on STM32F1 and STM32F2. Proper explanation welcome. STM32F0 doesn't seem to
* suffer from this problem. * suffer from this problem.
* *
* To add some confusion: pc_value has bit 0 always set, while the breakpoint * To add some confusion: pc_value has bit 0 always set, while the breakpoint

4
src/target/dsp563xx.c
View File

@ -322,7 +322,7 @@ enum watchpoint_condition {
#define INSTR_JUMP 0x0AF080 #define INSTR_JUMP 0x0AF080
/* Effective Addressing Mode Encoding */ /* Effective Addressing Mode Encoding */
#define EAME_R0 0x10 #define EAME_R0 0x10
/* instrcution encoder */ /* instruction encoder */
/* movep /* movep
* s - peripheral space X/Y (X=0,Y=1) * s - peripheral space X/Y (X=0,Y=1)
* w - write/read * w - write/read
@ -1359,7 +1359,7 @@ static int dsp563xx_deassert_reset(struct target *target)
if (target->state == TARGET_HALTED) { if (target->state == TARGET_HALTED) {
/* after a reset the cpu jmp to the /* after a reset the cpu jmp to the
* reset vector and need 2 cycles to fill * reset vector and need 2 cycles to fill
* the cache (fetch,decode,excecute) * the cache (fetch,decode,execute)
*/ */
err = dsp563xx_step_ex(target, 1, 0, 1, 1); err = dsp563xx_step_ex(target, 1, 0, 1, 1);
if (err != ERROR_OK) if (err != ERROR_OK)

6
src/target/dsp5680xx.c
View File

@ -93,7 +93,7 @@ static int dsp5680xx_drscan(struct target *target, uint8_t *d_in,
if (len > 32) { if (len > 32) {
retval = ERROR_FAIL; retval = ERROR_FAIL;
err_check(retval, DSP5680XX_ERROR_JTAG_DR_LEN_OVERFLOW, err_check(retval, DSP5680XX_ERROR_JTAG_DR_LEN_OVERFLOW,
"dr_len overflow, maxium is 32"); "dr_len overflow, maximum is 32");
} }
/* TODO what values of len are valid for jtag_add_plain_dr_scan? */ /* TODO what values of len are valid for jtag_add_plain_dr_scan? */
/* can i send as many bits as i want? */ /* can i send as many bits as i want? */
@ -638,7 +638,7 @@ static int switch_tap(struct target *target, struct jtag_tap *master_tap,
* more complicated routine, which is guaranteed to work, but requires * more complicated routine, which is guaranteed to work, but requires
* a reset. This will complicate comm with the flash module, since * a reset. This will complicate comm with the flash module, since
* after a reset clock divisors must be set again. * after a reset clock divisors must be set again.
* This implementation works most of the time, and is not accesible to the * This implementation works most of the time, and is not accessible to the
* user. * user.
* *
* @param target * @param target
@ -1795,7 +1795,7 @@ static int set_fm_ck_div(struct target *target)
* Executes the FM calculate signature command. The FM will calculate over the * Executes the FM calculate signature command. The FM will calculate over the
* data from @address to @address + @words -1. The result is written to a * data from @address to @address + @words -1. The result is written to a
* register, then read out by this function and returned in @signature. The * register, then read out by this function and returned in @signature. The
* value @signature may be compared to the the one returned by perl_crc to * value @signature may be compared to the one returned by perl_crc to
* verify the flash was written correctly. * verify the flash was written correctly.
* *
* @param target * @param target

2
src/target/esirisc_regs.h
View File

@ -164,7 +164,7 @@ enum esirisc_reg_num {
#define CSR_CONFIG_DBG 0x0f /* Debug Configuration */ #define CSR_CONFIG_DBG 0x0f /* Debug Configuration */
#define CSR_CONFIG_MID 0x10 /* Manufacturer ID */ #define CSR_CONFIG_MID 0x10 /* Manufacturer ID */
#define CSR_CONFIG_REV 0x11 /* Revision Number */ #define CSR_CONFIG_REV 0x11 /* Revision Number */
#define CSR_CONFIG_MPID 0x12 /* Mulitprocessor ID */ #define CSR_CONFIG_MPID 0x12 /* Multiprocessor ID */
#define CSR_CONFIG_FREQn 0x13 /* Frequency [0..2] */ #define CSR_CONFIG_FREQn 0x13 /* Frequency [0..2] */
#define CSR_CONFIG_TRACE 0x16 /* Trace Configuration */ #define CSR_CONFIG_TRACE 0x16 /* Trace Configuration */

2
src/target/etm.h
View File

@ -203,7 +203,7 @@ typedef enum {
BR_ENABLE = 0x1, /* Trace has been enabled */ BR_ENABLE = 0x1, /* Trace has been enabled */
BR_RESTART = 0x2, /* Trace restarted after a FIFO overflow */ BR_RESTART = 0x2, /* Trace restarted after a FIFO overflow */
BR_NODEBUG = 0x3, /* ARM has exited for debug state */ BR_NODEBUG = 0x3, /* ARM has exited for debug state */
BR_PERIOD = 0x4, /* Peridioc synchronization point (ETM >= v1.2)*/ BR_PERIOD = 0x4, /* Periodic synchronization point (ETM >= v1.2)*/
BR_RSVD5 = 0x5, /* reserved */ BR_RSVD5 = 0x5, /* reserved */
BR_RSVD6 = 0x6, /* reserved */ BR_RSVD6 = 0x6, /* reserved */
BR_RSVD7 = 0x7, /* reserved */ BR_RSVD7 = 0x7, /* reserved */

2
src/target/feroceon.c
View File

@ -37,7 +37,7 @@
* - asserting DBGRQ doesn't work if target is looping on the undef vector * - asserting DBGRQ doesn't work if target is looping on the undef vector
* *
* - the EICE version signature in the COMMS_CTL reg is next to the flow bits * - the EICE version signature in the COMMS_CTL reg is next to the flow bits
* not at the top, and rather meaningless due to existing discrepencies * not at the top, and rather meaningless due to existing discrepancies
* *
* - the DCC channel is half duplex (only one FIFO for both directions) with * - the DCC channel is half duplex (only one FIFO for both directions) with
* seemingly no proper flow control. * seemingly no proper flow control.

2
src/target/image.c
View File

@ -832,7 +832,7 @@ int image_open(struct image *image, const char *url, const char *type_string)
for (section = 0; section < image->num_sections; section++) for (section = 0; section < image->num_sections; section++)
image->sections[section].base_address += image->base_address; image->sections[section].base_address += image->base_address;
/* we're done relocating. The two statements below are mainly /* we're done relocating. The two statements below are mainly
* for documenation purposes: stop anyone from empirically * for documentation purposes: stop anyone from empirically
* thinking they should use these values henceforth. */ * thinking they should use these values henceforth. */
image->base_address = 0; image->base_address = 0;
image->base_address_set = 0; image->base_address_set = 0;

10
src/target/lakemont.c
View File

@ -330,7 +330,7 @@ static int restore_context(struct target *t)
/* /*
* we keep reg_cache in sync with hardware at halt/resume time, we avoid * we keep reg_cache in sync with hardware at halt/resume time, we avoid
* writing to real hardware here bacause pm_regs reflects the hardware * writing to real hardware here because pm_regs reflects the hardware
* while we are halted then reg_cache syncs with hw on resume * while we are halted then reg_cache syncs with hw on resume
* TODO - in order for "reg eip force" to work it assume get/set reads * TODO - in order for "reg eip force" to work it assume get/set reads
* and writes from hardware, may be other reasons also because generally * and writes from hardware, may be other reasons also because generally
@ -363,7 +363,7 @@ static int lakemont_set_core_reg(struct reg *reg, uint8_t *buf)
} }
static const struct reg_arch_type lakemont_reg_type = { static const struct reg_arch_type lakemont_reg_type = {
/* these get called if reg_cache doesnt have a "valid" value /* these get called if reg_cache doesn't have a "valid" value
* of an individual reg eg "reg eip" but not for "reg" block * of an individual reg eg "reg eip" but not for "reg" block
*/ */
.get = lakemont_get_core_reg, .get = lakemont_get_core_reg,
@ -649,7 +649,7 @@ static int read_hw_reg(struct target *t, int reg, uint32_t *regval, uint8_t cach
struct x86_32_common *x86_32 = target_to_x86_32(t); struct x86_32_common *x86_32 = target_to_x86_32(t);
struct lakemont_core_reg *arch_info; struct lakemont_core_reg *arch_info;
arch_info = x86_32->cache->reg_list[reg].arch_info; arch_info = x86_32->cache->reg_list[reg].arch_info;
x86_32->flush = 0; /* dont flush scans till we have a batch */ x86_32->flush = 0; /* don't flush scans till we have a batch */
if (submit_reg_pir(t, reg) != ERROR_OK) if (submit_reg_pir(t, reg) != ERROR_OK)
return ERROR_FAIL; return ERROR_FAIL;
if (submit_instruction_pir(t, SRAMACCESS) != ERROR_OK) if (submit_instruction_pir(t, SRAMACCESS) != ERROR_OK)
@ -693,7 +693,7 @@ static int write_hw_reg(struct target *t, int reg, uint32_t regval, uint8_t cach
arch_info->op, arch_info->op,
regval); regval);
x86_32->flush = 0; /* dont flush scans till we have a batch */ x86_32->flush = 0; /* don't flush scans till we have a batch */
if (submit_reg_pir(t, reg) != ERROR_OK) if (submit_reg_pir(t, reg) != ERROR_OK)
return ERROR_FAIL; return ERROR_FAIL;
if (submit_instruction_pir(t, SRAMACCESS) != ERROR_OK) if (submit_instruction_pir(t, SRAMACCESS) != ERROR_OK)
@ -943,7 +943,7 @@ int lakemont_poll(struct target *t)
if (bp != NULL) { if (bp != NULL) {
t->debug_reason = DBG_REASON_BREAKPOINT; t->debug_reason = DBG_REASON_BREAKPOINT;
if (bp->type == BKPT_SOFT) { if (bp->type == BKPT_SOFT) {
/* The EIP is now pointing the the next byte after the /* The EIP is now pointing the next byte after the
* breakpoint instruction. This needs to be corrected. * breakpoint instruction. This needs to be corrected.
*/ */
buf_set_u32(x86_32->cache->reg_list[EIP].value, 0, 32, eip-1); buf_set_u32(x86_32->cache->reg_list[EIP].value, 0, 32, eip-1);

2
src/target/mips32.c
View File

@ -723,7 +723,7 @@ int mips32_read_config_regs(struct target *target)
break; /* no more config registers implemented */ break; /* no more config registers implemented */
} }
else else
return ERROR_OK; /* already succesfully read */ return ERROR_OK; /* already successfully read */
LOG_DEBUG("read %"PRId32" config registers", ejtag_info->config_regs); LOG_DEBUG("read %"PRId32" config registers", ejtag_info->config_regs);

2
src/target/mips32.h
View File

@ -42,7 +42,7 @@
/** Returns the kernel segment base of a given address */ /** Returns the kernel segment base of a given address */
#define KSEGX(a) ((a) & 0xe0000000) #define KSEGX(a) ((a) & 0xe0000000)
/** CP0 CONFIG regites fields */ /** CP0 CONFIG register fields */
#define MIPS32_CONFIG0_KU_SHIFT 25 #define MIPS32_CONFIG0_KU_SHIFT 25
#define MIPS32_CONFIG0_KU_MASK (0x7 << MIPS32_CONFIG0_KU_SHIFT) #define MIPS32_CONFIG0_KU_MASK (0x7 << MIPS32_CONFIG0_KU_SHIFT)

8
src/target/mips32_pracc.c
View File

@ -277,7 +277,7 @@ int mips32_pracc_exec(struct mips_ejtag *ejtag_info, struct pracc_queue_info *ct
return ERROR_JTAG_DEVICE_ERROR; return ERROR_JTAG_DEVICE_ERROR;
} }
} else } else
if (code_count > 10) { /* enough, abandone */ if (code_count > 10) { /* enough, abandon */
LOG_DEBUG("execution abandoned, store pending: %d", store_pending); LOG_DEBUG("execution abandoned, store pending: %d", store_pending);
return ERROR_JTAG_DEVICE_ERROR; return ERROR_JTAG_DEVICE_ERROR;
} }
@ -427,7 +427,7 @@ int mips32_pracc_queue_exec(struct mips_ejtag *ejtag_info, struct pracc_queue_in
fetch_addr += 4; fetch_addr += 4;
scan_count++; scan_count++;
/* check if previous intrucction is a store instruction at dmesg */ /* check if previous instruction is a store instruction at dmesg */
if (i > 0 && ctx->pracc_list[i - 1].addr) { if (i > 0 && ctx->pracc_list[i - 1].addr) {
uint32_t store_addr = ctx->pracc_list[i - 1].addr; uint32_t store_addr = ctx->pracc_list[i - 1].addr;
ejtag_ctrl = buf_get_u32(scan_in[scan_count].scan_32.ctrl, 0, 32); ejtag_ctrl = buf_get_u32(scan_in[scan_count].scan_32.ctrl, 0, 32);
@ -789,7 +789,7 @@ int mips32_pracc_write_mem(struct mips_ejtag *ejtag_info, uint32_t addr, int siz
* If we are in the cacheable region and cache is activated, * If we are in the cacheable region and cache is activated,
* we must clean D$ (if Cache Coherency Attribute is set to 3) + invalidate I$ after we did the write, * we must clean D$ (if Cache Coherency Attribute is set to 3) + invalidate I$ after we did the write,
* so that changes do not continue to live only in D$ (if CCA = 3), but to be * so that changes do not continue to live only in D$ (if CCA = 3), but to be
* replicated in I$ also (maybe we wrote the istructions) * replicated in I$ also (maybe we wrote the instructions)
*/ */
uint32_t conf = 0; uint32_t conf = 0;
int cached = 0; int cached = 0;
@ -816,7 +816,7 @@ int mips32_pracc_write_mem(struct mips_ejtag *ejtag_info, uint32_t addr, int siz
} }
/** /**
* Check cachablitiy bits coherency algorithm * Check cacheability bits coherency algorithm
* is the region cacheable or uncached. * is the region cacheable or uncached.
* If cacheable we have to synchronize the cache * If cacheable we have to synchronize the cache
*/ */

6
src/target/mips32_pracc.h
View File

@ -58,7 +58,7 @@ struct pracc_queue_info {
int retval; int retval;
int code_count; int code_count;
int store_count; int store_count;
int max_code; /* max intstructions with currently allocated memory */ int max_code; /* max instructions with currently allocated memory */
pa_list *pracc_list; /* Code and store addresses at dmseg */ pa_list *pracc_list; /* Code and store addresses at dmseg */
}; };
@ -93,7 +93,7 @@ int mips32_pracc_exec(struct mips_ejtag *ejtag_info, struct pracc_queue_info *ct
* @param[in] cp0_reg Number of copro C0 register we want to read * @param[in] cp0_reg Number of copro C0 register we want to read
* @param[in] cp0_sel Select for the given C0 register * @param[in] cp0_sel Select for the given C0 register
* *
* @return ERROR_OK on Sucess, ERROR_FAIL otherwise * @return ERROR_OK on Success, ERROR_FAIL otherwise
*/ */
int mips32_cp0_read(struct mips_ejtag *ejtag_info, int mips32_cp0_read(struct mips_ejtag *ejtag_info,
uint32_t *val, uint32_t cp0_reg, uint32_t cp0_sel); uint32_t *val, uint32_t cp0_reg, uint32_t cp0_sel);
@ -109,7 +109,7 @@ int mips32_cp0_read(struct mips_ejtag *ejtag_info,
* @param[in] cp0_reg Number of copro C0 register we want to write to * @param[in] cp0_reg Number of copro C0 register we want to write to
* @param[in] cp0_sel Select for the given C0 register * @param[in] cp0_sel Select for the given C0 register
* *
* @return ERROR_OK on Sucess, ERROR_FAIL otherwise * @return ERROR_OK on Success, ERROR_FAIL otherwise
*/ */
int mips32_cp0_write(struct mips_ejtag *ejtag_info, int mips32_cp0_write(struct mips_ejtag *ejtag_info,
uint32_t val, uint32_t cp0_reg, uint32_t cp0_sel); uint32_t val, uint32_t cp0_reg, uint32_t cp0_sel);

2
src/target/mips_ejtag.c
View File

@ -278,7 +278,7 @@ int mips_ejtag_exit_debug(struct mips_ejtag *ejtag_info)
return ctx.retval; return ctx.retval;
} }
/* mips_ejtag_init_mmr - asign Memory-Mapped Registers depending /* mips_ejtag_init_mmr - assign Memory-Mapped Registers depending
* on EJTAG version. * on EJTAG version.
*/ */
static void mips_ejtag_init_mmr(struct mips_ejtag *ejtag_info) static void mips_ejtag_init_mmr(struct mips_ejtag *ejtag_info)

10
src/target/mips_m4k.c
View File

@ -667,7 +667,7 @@ static int mips_m4k_set_breakpoint(struct target *target,
if (ejtag_info->endianness && isa_req) if (ejtag_info->endianness && isa_req)
sdbbp32_instr = SWAP16(sdbbp32_instr); sdbbp32_instr = SWAP16(sdbbp32_instr);
if ((breakpoint->address & 3) == 0) { /* word alligned */ if ((breakpoint->address & 3) == 0) { /* word aligned */
retval = target_read_memory(target, bpaddr, bplength, 1, breakpoint->orig_instr); retval = target_read_memory(target, bpaddr, bplength, 1, breakpoint->orig_instr);
if (retval != ERROR_OK) if (retval != ERROR_OK)
@ -784,9 +784,9 @@ static int mips_m4k_unset_breakpoint(struct target *target,
if (retval != ERROR_OK) if (retval != ERROR_OK)
return retval; return retval;
/** /**
* target_read_memory() gets us data in _target_ endianess. * target_read_memory() gets us data in _target_ endianness.
* If we want to use this data on the host for comparisons with some macros * If we want to use this data on the host for comparisons with some macros
* we must first transform it to _host_ endianess using target_buffer_get_u16(). * we must first transform it to _host_ endianness using target_buffer_get_u16().
*/ */
if (sdbbp32_instr == target_buffer_get_u32(target, current_instr)) { if (sdbbp32_instr == target_buffer_get_u32(target, current_instr)) {
retval = target_write_memory(target, breakpoint->address, 4, 1, retval = target_write_memory(target, breakpoint->address, 4, 1,
@ -794,7 +794,7 @@ static int mips_m4k_unset_breakpoint(struct target *target,
if (retval != ERROR_OK) if (retval != ERROR_OK)
return retval; return retval;
} }
} else { /* 16bit alligned */ } else { /* 16bit aligned */
retval = target_read_memory(target, breakpoint->address, 2, 2, current_instr); retval = target_read_memory(target, breakpoint->address, 2, 2, current_instr);
if (retval != ERROR_OK) if (retval != ERROR_OK)
return retval; return retval;
@ -1106,7 +1106,7 @@ static int mips_m4k_write_memory(struct target *target, target_addr_t address,
if (((size == 4) && (address & 0x3u)) || ((size == 2) && (address & 0x1u))) if (((size == 4) && (address & 0x3u)) || ((size == 2) && (address & 0x1u)))
return ERROR_TARGET_UNALIGNED_ACCESS; return ERROR_TARGET_UNALIGNED_ACCESS;
/** correct endianess if we have word or hword access */ /** correct endianness if we have word or hword access */
void *t = NULL; void *t = NULL;
if (size > 1) { if (size > 1) {
/* mips32_..._write_mem with size 4/2 requires uint32_t/uint16_t in host */ /* mips32_..._write_mem with size 4/2 requires uint32_t/uint16_t in host */

2
src/target/nds32_v2.c
View File

@ -256,7 +256,7 @@ static int nds32_v2_check_interrupt_stack(struct nds32_v2_common *nds32_v2)
aice_write_register(aice, IR2, val_ir2); aice_write_register(aice, IR2, val_ir2);
} }
/* get origianl DT bit and set to current state let debugger has same memory view /* get original DT bit and set to current state let debugger has same memory view
PSW.IT MUST be turned off. Otherwise, DIM could not operate normally. */ PSW.IT MUST be turned off. Otherwise, DIM could not operate normally. */
aice_read_register(aice, IR1, &val_ir1); aice_read_register(aice, IR1, &val_ir1);
modified_psw = val_ir0 | (val_ir1 & 0x80); modified_psw = val_ir0 | (val_ir1 & 0x80);

4
src/target/openrisc/or1k.c
View File

@ -632,7 +632,7 @@ static int or1k_is_cpu_running(struct target *target, int *running)
LOG_WARNING("Debug IF CPU control reg read failure."); LOG_WARNING("Debug IF CPU control reg read failure.");
/* Try once to restart the JTAG infrastructure - /* Try once to restart the JTAG infrastructure -
quite possibly the board has just been reset. */ quite possibly the board has just been reset. */
LOG_WARNING("Resetting JTAG TAP state and reconnectiong to debug IF."); LOG_WARNING("Resetting JTAG TAP state and reconnecting to debug IF.");
du_core->or1k_jtag_init(&or1k->jtag); du_core->or1k_jtag_init(&or1k->jtag);
LOG_WARNING("...attempt %d of %d", tries, RETRIES_MAX); LOG_WARNING("...attempt %d of %d", tries, RETRIES_MAX);
@ -742,7 +742,7 @@ static int or1k_deassert_reset(struct target *target)
int retval = du_core->or1k_cpu_reset(&or1k->jtag, CPU_NOT_RESET); int retval = du_core->or1k_cpu_reset(&or1k->jtag, CPU_NOT_RESET);
if (retval != ERROR_OK) { if (retval != ERROR_OK) {
LOG_ERROR("Error while desasserting RESET"); LOG_ERROR("Error while deasserting RESET");
return retval; return retval;
} }

2
src/target/openrisc/or1k_du_adv.c
View File

@ -995,7 +995,7 @@ int or1k_adv_jtag_jsp_xfer(struct or1k_jtag *jtag_info,
int *out_len, unsigned char *out_buffer, int *out_len, unsigned char *out_buffer,
int *in_len, unsigned char *in_buffer) int *in_len, unsigned char *in_buffer)
{ {
LOG_DEBUG("JSP transfert"); LOG_DEBUG("JSP transfer");
int retval; int retval;
if (!jtag_info->or1k_jtag_inited) if (!jtag_info->or1k_jtag_inited)

2
src/target/openrisc/or1k_tap_vjtag.c
View File

@ -99,7 +99,7 @@ static int or1k_tap_vjtag_init(struct or1k_jtag *jtag_info)
/* You can use a custom JTAG controller to discover transactions /* You can use a custom JTAG controller to discover transactions
* necessary to enumerate all Virtual JTAG megafunction instances * necessary to enumerate all Virtual JTAG megafunction instances
* from your design atruntime. All SLD nodes and the virtual JTAG * from your design at runtime. All SLD nodes and the virtual JTAG
* registers that they contain are targeted by two Instruction Register * registers that they contain are targeted by two Instruction Register
* values, USER0 and USER1. * values, USER0 and USER1.
* *

4
src/target/riscv/riscv-013.c
View File

@ -3732,10 +3732,10 @@ int riscv013_test_compliance(struct target *target)
COMPLIANCE_TEST(ERROR_OK == register_read_direct(target, &testval_read, GDB_REGNO_ZERO + i), COMPLIANCE_TEST(ERROR_OK == register_read_direct(target, &testval_read, GDB_REGNO_ZERO + i),
"GPR Reads should be supported."); "GPR Reads should be supported.");
if (riscv_xlen(target) > 32) { if (riscv_xlen(target) > 32) {
/* Dummy comment to satisfy linter, since removing the brances here doesn't actually compile. */ /* Dummy comment to satisfy linter, since removing the branches here doesn't actually compile. */
COMPLIANCE_TEST(testval == testval_read, "GPR Reads and writes should be supported."); COMPLIANCE_TEST(testval == testval_read, "GPR Reads and writes should be supported.");
} else { } else {
/* Dummy comment to satisfy linter, since removing the brances here doesn't actually compile. */ /* Dummy comment to satisfy linter, since removing the branches here doesn't actually compile. */
COMPLIANCE_TEST((testval & 0xFFFFFFFF) == testval_read, "GPR Reads and writes should be supported."); COMPLIANCE_TEST((testval & 0xFFFFFFFF) == testval_read, "GPR Reads and writes should be supported.");
} }
} }

4
src/target/riscv/riscv.h
View File

@ -215,12 +215,12 @@ int riscv_current_hartid(const struct target *target);
* without requiring multiple targets. */ * without requiring multiple targets. */
/* When using the RTOS to debug, this selects the hart that is currently being /* When using the RTOS to debug, this selects the hart that is currently being
* debugged. This doesn't propogate to the hardware. */ * debugged. This doesn't propagate to the hardware. */
void riscv_set_all_rtos_harts(struct target *target); void riscv_set_all_rtos_harts(struct target *target);
void riscv_set_rtos_hartid(struct target *target, int hartid); void riscv_set_rtos_hartid(struct target *target, int hartid);
/* Lists the number of harts in the system, which are assumed to be /* Lists the number of harts in the system, which are assumed to be
* concecutive and start with mhartid=0. */ * consecutive and start with mhartid=0. */
int riscv_count_harts(struct target *target); int riscv_count_harts(struct target *target);
/* Returns TRUE if the target has the given register on the given hart. */ /* Returns TRUE if the target has the given register on the given hart. */

4
src/target/semihosting_common.c
View File

@ -145,7 +145,7 @@ int semihosting_common(struct target *target)
{ {
struct semihosting *semihosting = target->semihosting; struct semihosting *semihosting = target->semihosting;
if (!semihosting) { if (!semihosting) {
/* Silently ignore if the semhosting field was not set. */ /* Silently ignore if the semihosting field was not set. */
return ERROR_OK; return ERROR_OK;
} }
@ -345,7 +345,7 @@ int semihosting_common(struct target *target)
"semihosting: *** application exited normally ***\n"); "semihosting: *** application exited normally ***\n");
} }
} else if (semihosting->param == ADP_STOPPED_RUN_TIME_ERROR) { } else if (semihosting->param == ADP_STOPPED_RUN_TIME_ERROR) {
/* Chosen more or less arbitrarly to have a nicer message, /* Chosen more or less arbitrarily to have a nicer message,
* otherwise all other return the same exit code 1. */ * otherwise all other return the same exit code 1. */
if (!gdb_actual_connections) if (!gdb_actual_connections)
exit(1); exit(1);

2
src/target/startup.tcl
View File

@ -119,7 +119,7 @@ proc ocd_process_reset_inner { MODE } {
continue continue
} }
# Wait upto 1 second for target to halt. Why 1sec? Cause # Wait up to 1 second for target to halt. Why 1sec? Cause
# the JTAG tap reset signal might be hooked to a slow # the JTAG tap reset signal might be hooked to a slow
# resistor/capacitor circuit - and it might take a while # resistor/capacitor circuit - and it might take a while
# to charge # to charge

2
src/target/stm8.c
View File

@ -967,7 +967,7 @@ static int stm8_reset_deassert(struct target *target)
if (target->reset_halt) if (target->reset_halt)
return ERROR_OK; return ERROR_OK;
/* Instead of going thrugh saving context, polling and /* Instead of going through saving context, polling and
then resuming target again just clear stall and proceed. */ then resuming target again just clear stall and proceed. */
target->state = TARGET_RUNNING; target->state = TARGET_RUNNING;
return stm8_exit_debug(target); return stm8_exit_debug(target);

12
src/target/target.c
View File

@ -593,7 +593,7 @@ int target_halt(struct target *target)
* @param address Optionally used as the program counter. * @param address Optionally used as the program counter.
* @param handle_breakpoints True iff breakpoints at the resumption PC * @param handle_breakpoints True iff breakpoints at the resumption PC
* should be skipped. (For example, maybe execution was stopped by * should be skipped. (For example, maybe execution was stopped by
* such a breakpoint, in which case it would be counterprodutive to * such a breakpoint, in which case it would be counterproductive to
* let it re-trigger. * let it re-trigger.
* @param debug_execution False if all working areas allocated by OpenOCD * @param debug_execution False if all working areas allocated by OpenOCD
* should be released and/or restored to their original contents. * should be released and/or restored to their original contents.
@ -709,7 +709,7 @@ static int default_check_reset(struct target *target)
return ERROR_OK; return ERROR_OK;
} }
/* Equvivalent Tcl code arp_examine_one is in src/target/startup.tcl /* Equivalent Tcl code arp_examine_one is in src/target/startup.tcl
* Keep in sync */ * Keep in sync */
int target_examine_one(struct target *target) int target_examine_one(struct target *target)
{ {
@ -3462,7 +3462,7 @@ COMMAND_HANDLER(handle_load_image_command)
uint32_t offset = 0; uint32_t offset = 0;
uint32_t length = buf_cnt; uint32_t length = buf_cnt;
/* DANGER!!! beware of unsigned comparision here!!! */ /* DANGER!!! beware of unsigned comparison here!!! */
if ((image.sections[i].base_address + buf_cnt >= min_address) && if ((image.sections[i].base_address + buf_cnt >= min_address) &&
(image.sections[i].base_address < max_address)) { (image.sections[i].base_address < max_address)) {
@ -4686,7 +4686,7 @@ static int target_configure(Jim_GetOptInfo *goi, struct target *target)
} }
switch (n->value) { switch (n->value) {
case TCFG_TYPE: case TCFG_TYPE:
/* not setable */ /* not settable */
if (goi->isconfigure) { if (goi->isconfigure) {
Jim_SetResultFormatted(goi->interp, Jim_SetResultFormatted(goi->interp,
"not settable: %s", n->name); "not settable: %s", n->name);
@ -5674,7 +5674,7 @@ static int jim_target_smp(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
retval = 0; retval = 0;
LOG_DEBUG("%d", argc); LOG_DEBUG("%d", argc);
/* argv[1] = target to associate in smp /* argv[1] = target to associate in smp
* argv[2] = target to assoicate in smp * argv[2] = target to associate in smp
* argv[3] ... * argv[3] ...
*/ */
@ -5844,7 +5844,7 @@ COMMAND_HANDLER(handle_fast_load_image_command)
uint32_t offset = 0; uint32_t offset = 0;
uint32_t length = buf_cnt; uint32_t length = buf_cnt;
/* DANGER!!! beware of unsigned comparision here!!! */ /* DANGER!!! beware of unsigned comparison here!!! */
if ((image.sections[i].base_address + buf_cnt >= min_address) && if ((image.sections[i].base_address + buf_cnt >= min_address) &&
(image.sections[i].base_address < max_address)) { (image.sections[i].base_address < max_address)) {

2
src/target/target_request.c
View File

@ -261,7 +261,7 @@ COMMAND_HANDLER(handle_target_request_debugmsgs_command)
return ERROR_OK; return ERROR_OK;
} }
/* see if reciever is already registered */ /* see if receiver is already registered */
if (find_debug_msg_receiver(CMD_CTX, target) != NULL) if (find_debug_msg_receiver(CMD_CTX, target) != NULL)
receiving = 1; receiving = 1;

12
src/target/xscale.c
View File

@ -824,7 +824,7 @@ static int xscale_poll(struct target *target)
retval = xscale_debug_entry(target); retval = xscale_debug_entry(target);
} else if (retval != ERROR_TARGET_RESOURCE_NOT_AVAILABLE) { } else if (retval != ERROR_TARGET_RESOURCE_NOT_AVAILABLE) {
LOG_USER("error while polling TX register, reset CPU"); LOG_USER("error while polling TX register, reset CPU");
/* here we "lie" so GDB won't get stuck and a reset can be perfomed */ /* here we "lie" so GDB won't get stuck and a reset can be performed */
target->state = TARGET_HALTED; target->state = TARGET_HALTED;
} }
@ -955,7 +955,7 @@ static int xscale_debug_entry(struct target *target)
xscale->arch_debug_reason = XSCALE_DBG_REASON_GENERIC; xscale->arch_debug_reason = XSCALE_DBG_REASON_GENERIC;
pc -= 4; pc -= 4;
break; break;
case 0x5: /* Vector trap occured */ case 0x5: /* Vector trap occurred */
target->debug_reason = DBG_REASON_BREAKPOINT; target->debug_reason = DBG_REASON_BREAKPOINT;
xscale->arch_debug_reason = XSCALE_DBG_REASON_GENERIC; xscale->arch_debug_reason = XSCALE_DBG_REASON_GENERIC;
pc -= 4; pc -= 4;
@ -2412,7 +2412,7 @@ static int xscale_get_reg(struct reg *reg)
} else if (strcmp(reg->name, "XSCALE_TXRXCTRL") == 0) { } else if (strcmp(reg->name, "XSCALE_TXRXCTRL") == 0) {
/* can't (explicitly) read from TXRXCTRL register */ /* can't (explicitly) read from TXRXCTRL register */
return ERROR_OK; return ERROR_OK;
} else {/* Other DBG registers have to be transfered by the debug handler } else {/* Other DBG registers have to be transferred by the debug handler
* send CP read request (command 0x40) */ * send CP read request (command 0x40) */
xscale_send_u32(target, 0x40); xscale_send_u32(target, 0x40);
@ -2450,7 +2450,7 @@ static int xscale_set_reg(struct reg *reg, uint8_t *buf)
} else if (strcmp(reg->name, "XSCALE_TXRXCTRL") == 0) { } else if (strcmp(reg->name, "XSCALE_TXRXCTRL") == 0) {
/* can't (explicitly) write to TXRXCTRL register */ /* can't (explicitly) write to TXRXCTRL register */
return ERROR_OK; return ERROR_OK;
} else {/* Other DBG registers have to be transfered by the debug handler } else {/* Other DBG registers have to be transferred by the debug handler
* send CP write request (command 0x41) */ * send CP write request (command 0x41) */
xscale_send_u32(target, 0x41); xscale_send_u32(target, 0x41);
@ -2809,7 +2809,7 @@ static int xscale_analyze_trace(struct target *target, struct command_invocation
current_pc = chkpt_reg; current_pc = chkpt_reg;
else if (current_pc != chkpt_reg) /* sanity check */ else if (current_pc != chkpt_reg) /* sanity check */
LOG_WARNING("trace is suspect: checkpoint register " LOG_WARNING("trace is suspect: checkpoint register "
"inconsistent with adddress from image"); "inconsistent with address from image");
} }
if (current_pc == 0) if (current_pc == 0)
@ -2942,7 +2942,7 @@ static int xscale_init_arch_info(struct target *target,
arm = &xscale->arm; arm = &xscale->arm;
/* store architecture specfic data */ /* store architecture specific data */
xscale->common_magic = XSCALE_COMMON_MAGIC; xscale->common_magic = XSCALE_COMMON_MAGIC;
/* PXA3xx with 11 bit IR shifts the JTAG instructions */ /* PXA3xx with 11 bit IR shifts the JTAG instructions */