interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

target/mips32: change prototype of mips32_verify_pointer() 

To prepare for handling TCL return values consistently, all calls
to command_print/command_print_sameline should be ready to switch
to CMD as first parameter.

Change prototype of mips32_verify_pointer() to pass CMD instead of
CMD_CTX.

This change was part of http://openocd.zylin.com/1815 from Paul
Fertser and has been extracted and rebased to simplify the review.

Change-Id: Ic4a4de10518ee009d6df420e7278fd028e1f22ca
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5062
Tested-by: jenkins
This commit is contained in:
Paul Fertser 2019-04-01 04:57:01 +02:00 committed by Tomas Vanek
parent 07632ab94c
commit 42bc2051aa
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/target/mips32.c
View File

@ -905,11 +905,11 @@ cleanup:
return 1; /* only one block has been checked */ return 1; /* only one block has been checked */
} }
static int mips32_verify_pointer(struct command_context *cmd_ctx, static int mips32_verify_pointer(struct command_invocation *cmd,
struct mips32_common *mips32) struct mips32_common *mips32)
{ {
if (mips32->common_magic != MIPS32_COMMON_MAGIC) { if (mips32->common_magic != MIPS32_COMMON_MAGIC) {
command_print(cmd_ctx, "target is not an MIPS32"); command_print(cmd->ctx, "target is not an MIPS32");
return ERROR_TARGET_INVALID; return ERROR_TARGET_INVALID;
} }
return ERROR_OK; return ERROR_OK;
@ -927,7 +927,7 @@ COMMAND_HANDLER(mips32_handle_cp0_command)
struct mips_ejtag *ejtag_info = &mips32->ejtag_info; struct mips_ejtag *ejtag_info = &mips32->ejtag_info;
retval = mips32_verify_pointer(CMD_CTX, mips32); retval = mips32_verify_pointer(CMD, mips32);
if (retval != ERROR_OK) if (retval != ERROR_OK)
return retval; return retval;