interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix 'flash protect' and 'flash erase_sector' 

Command upgrading introduced two off-by-one bugs in the flash commands.
This patch fixes the 'flash {protect,erase_sector}' commands to check
that they have been passed the correct number of arguments.

Ammended during commit to fix help text for 'erase_address' too.
This commit is contained in:
Eric Wetzel 2009-11-26 07:54:45 -08:00 committed by Zachary T Welch
parent 2653b80307
commit 3f8aa3cb03
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/flash/flash.c
View File

@ -559,7 +559,7 @@ static int flash_check_sector_parameters(struct command_context *cmd_ctx,
COMMAND_HANDLER(handle_flash_erase_command) COMMAND_HANDLER(handle_flash_erase_command)
{ {
if (CMD_ARGC != 2) if (CMD_ARGC != 3)
return ERROR_COMMAND_SYNTAX_ERROR; return ERROR_COMMAND_SYNTAX_ERROR;
uint32_t bank_nr; uint32_t bank_nr;
@ -599,7 +599,7 @@ COMMAND_HANDLER(handle_flash_erase_command)
COMMAND_HANDLER(handle_flash_protect_command) COMMAND_HANDLER(handle_flash_protect_command)
{ {
if (CMD_ARGC != 3) if (CMD_ARGC != 4)
return ERROR_COMMAND_SYNTAX_ERROR; return ERROR_COMMAND_SYNTAX_ERROR;
uint32_t bank_nr; uint32_t bank_nr;
@ -1316,7 +1316,7 @@ static const struct command_registration flash_exec_command_handlers[] = {
.name = "erase_address", .name = "erase_address",
.handler = &handle_flash_erase_address_command, .handler = &handle_flash_erase_address_command,
.mode = COMMAND_EXEC, .mode = COMMAND_EXEC,
.usage = "<bank> <address> <length>", .usage = "<address> <length>",
.help = "erase address range", .help = "erase address range",
}, },