gdbserver: gdb cmds returning failure on success

The gdb_memory_map cmd for example fell through and returned
ERROR_COMMAND_SYNTAX_ERROR on success - behaviour is now as expected.

Signed-off-by: Spencer Oliver <ntfreak@users.sourceforge.net>
This commit is contained in:
Spencer Oliver 2010-05-17 10:17:21 +01:00
parent 5fd1c2db9a
commit 3ecc191b36
1 changed files with 12 additions and 9 deletions

View File

@ -2503,26 +2503,29 @@ COMMAND_HANDLER(handle_gdb_port_command)
COMMAND_HANDLER(handle_gdb_memory_map_command) COMMAND_HANDLER(handle_gdb_memory_map_command)
{ {
if (CMD_ARGC == 1) if (CMD_ARGC != 1)
COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_use_memory_map); return ERROR_COMMAND_SYNTAX_ERROR;
return ERROR_COMMAND_SYNTAX_ERROR; COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_use_memory_map);
return ERROR_OK;
} }
COMMAND_HANDLER(handle_gdb_flash_program_command) COMMAND_HANDLER(handle_gdb_flash_program_command)
{ {
if (CMD_ARGC == 1) if (CMD_ARGC != 1)
COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_flash_program); return ERROR_COMMAND_SYNTAX_ERROR;
return ERROR_COMMAND_SYNTAX_ERROR; COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_flash_program);
return ERROR_OK;
} }
COMMAND_HANDLER(handle_gdb_report_data_abort_command) COMMAND_HANDLER(handle_gdb_report_data_abort_command)
{ {
if (CMD_ARGC == 1) if (CMD_ARGC != 1)
COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_report_data_abort); return ERROR_COMMAND_SYNTAX_ERROR;
return ERROR_COMMAND_SYNTAX_ERROR; COMMAND_PARSE_ENABLE(CMD_ARGV[0], gdb_report_data_abort);
return ERROR_OK;
} }
/* gdb_breakpoint_override */ /* gdb_breakpoint_override */