interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

openocd: drop useless typedef 

There is no need to use typedef for the array of functions.
Drop it.

While there, move the declaration outside the function and use the
array size to drop the error-prone sentinel to NULL.

Change-Id: I424964a6ef82ed1a7b27e78fbd19aa9f985b52c7
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/8699
Reviewed-by: zapb <dev@zapb.de>
Tested-by: jenkins
This commit is contained in:
Antonio Borneo 2025-01-10 13:40:59 +01:00
parent 6e39af3b0e
commit 3e4512d62d
1 changed files with 18 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/openocd.c
View File

@ -232,6 +232,23 @@ static int openocd_register_commands(struct command_context *cmd_ctx)
struct command_context *global_cmd_ctx;
static int (* const command_registrants[])(struct command_context *cmd_ctx_value) = {
openocd_register_commands,
server_register_commands,
gdb_register_commands,
log_register_commands,
rtt_server_register_commands,
transport_register_commands,
adapter_register_commands,
target_register_commands,
flash_register_commands,
nand_register_commands,
pld_register_commands,
cti_register_commands,
dap_register_commands,
arm_tpiu_swo_register_commands,
};
static struct command_context *setup_command_handler(Jim_Interp *interp)
{
log_init();
@ -240,25 +257,7 @@ static struct command_context *setup_command_handler(Jim_Interp *interp)
struct command_context *cmd_ctx = command_init(openocd_startup_tcl, interp);
/* register subsystem commands */
typedef int (*command_registrant_t)(struct command_context *cmd_ctx_value);
static const command_registrant_t command_registrants[] = {
&openocd_register_commands,
&server_register_commands,
&gdb_register_commands,
&log_register_commands,
&rtt_server_register_commands,
&transport_register_commands,
&adapter_register_commands,
&target_register_commands,
&flash_register_commands,
&nand_register_commands,
&pld_register_commands,
&cti_register_commands,
&dap_register_commands,
&arm_tpiu_swo_register_commands,
NULL
};
for (unsigned int i = 0; command_registrants[i]; i++) {
for (unsigned int i = 0; i < ARRAY_SIZE(command_registrants); i++) {
int retval = (*command_registrants[i])(cmd_ctx);
if (retval != ERROR_OK) {
command_done(cmd_ctx);