interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

SimonQian <simonqian@SimonQian.com>, reported by R.Doss: 

This patch fixes a segfault when TDO was not received in XXR command:
- allocate space for the value and mask anyway
- clear the mask to zero to effectively skip the output comparison step


git-svn-id: svn://svn.berlios.de/openocd/trunk@1915 b42882b7-edfa-0310-969c-e2dbd0fdcd60
This commit is contained in:
zwelch 2009-05-26 01:27:56 +00:00
parent fe465bd33e
commit 3848774d33
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/svf/svf.c
View File

@ -918,6 +918,27 @@ static int svf_run_command(struct command_context_s *cmd_ctx, char *cmd_str)
} }
buf_set_ones(xxr_para_tmp->mask, xxr_para_tmp->len); buf_set_ones(xxr_para_tmp->mask, xxr_para_tmp->len);
} }
// If TDO is absent, no comparison is needed, set the mask to 0
if (!(xxr_para_tmp->data_mask & XXR_TDO))
{
if (NULL == xxr_para_tmp->tdo)
{
if (ERROR_OK != svf_adjust_array_length(&xxr_para_tmp->tdo, i_tmp, xxr_para_tmp->len))
{
LOG_ERROR("fail to adjust length of array");
return ERROR_FAIL;
}
}
if (NULL == xxr_para_tmp->mask)
{
if (ERROR_OK != svf_adjust_array_length(&xxr_para_tmp->mask, i_tmp, xxr_para_tmp->len))
{
LOG_ERROR("fail to adjust length of array");
return ERROR_FAIL;
}
}
memset(xxr_para_tmp->mask, 0, (xxr_para_tmp->len + 7) >> 3);
}
// do scan if necessary // do scan if necessary
if (SDR == command) if (SDR == command)
{ {