interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

helper/options: handle errors in `-l` 

Before the patch an error in opening the log file (e.g. can't write a
file) was ignored when specified via `-l`.
E.g.:
```
> touch log
> chmod -w log
> openocd -l log -c shutdown
...
failed to open output log "log"
shutdown command invoked
> echo $?
0
```

After the patch:
```
...
> openocd -l log -c shutdown
...
failed to open output log "log"
> echo $?
1
```

Change-Id: Ibab45f580dc46a499bf967c4afad071f9c2972a2
Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/8666
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
This commit is contained in:
Evgeniy Naydanov 2024-12-17 18:13:00 +03:00 committed by Antonio Borneo
parent 778d2dc4bb
commit 345473f3ce
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/helper/options.c
View File

@ -303,8 +303,12 @@ int parse_cmdline_args(struct command_context *cmd_ctx, int argc, char *argv[])
break; break;
} }
case 'l': /* --log_output | -l */ case 'l': /* --log_output | -l */
command_run_linef(cmd_ctx, "log_output %s", optarg); {
int retval = command_run_linef(cmd_ctx, "log_output %s", optarg);
if (retval != ERROR_OK)
return retval;
break; break;
}
case 'c': /* --command | -c */ case 'c': /* --command | -c */
add_config_command(optarg); add_config_command(optarg);
break; break;