interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

target/lakemont: fix dead assignment 

Clang scan-build complains for a dead assignment:
	Value stored to 'tapstatus' is never read

Remove the assignment and add a comment to point for a potential
removal of the line.

Change-Id: Iad2fdc7e6faf650e24cc086ee74c745acb0d1c73
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/6591
Tested-by: jenkins
This commit is contained in:
Antonio Borneo 2021-09-22 19:14:29 +02:00
parent 01de751025
commit 327040ad74
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/target/lakemont.c
View File

@ -1070,7 +1070,8 @@ int lakemont_step(struct target *t, int current,
LOG_DEBUG("EFLAGS [TF] [RF] bits set=0x%08" PRIx32 ", PMCR=0x%08" PRIx32 ", EIP=0x%08" PRIx32, LOG_DEBUG("EFLAGS [TF] [RF] bits set=0x%08" PRIx32 ", PMCR=0x%08" PRIx32 ", EIP=0x%08" PRIx32,
eflags, pmcr, eip); eflags, pmcr, eip);
tapstatus = get_tapstatus(t); /* Returned value unused. Can this line be removed? */
get_tapstatus(t);
t->debug_reason = DBG_REASON_SINGLESTEP; t->debug_reason = DBG_REASON_SINGLESTEP;
t->state = TARGET_DEBUG_RUNNING; t->state = TARGET_DEBUG_RUNNING;