From 2f6f7c442d24ba296dd9447e254e34b817fd02b4 Mon Sep 17 00:00:00 2001 From: Spencer Oliver Date: Mon, 30 Jan 2012 13:15:08 +0000 Subject: [PATCH] checkpatch: remove typedef check We may enable this again - but at the moment is causing extra issues with reformatting the codebase. Change-Id: Ic64310a20605a0ef3206caa15c8e6c8ee655bfda Signed-off-by: Spencer Oliver Reviewed-on: http://openocd.zylin.com/413 Tested-by: jenkins --- tools/scripts/checkpatch.pl | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/scripts/checkpatch.pl b/tools/scripts/checkpatch.pl index 50fffc175..cabfa6799 100755 --- a/tools/scripts/checkpatch.pl +++ b/tools/scripts/checkpatch.pl @@ -2121,14 +2121,14 @@ sub process { # check for new typedefs, only function parameters and sparse annotations # make sense. - if ($line =~ /\btypedef\s/ && - $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ && - $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ && - $line !~ /\b$typeTypedefs\b/ && - $line !~ /\b__bitwise(?:__|)\b/) { - WARN("NEW_TYPEDEFS", - "do not add new typedefs\n" . $herecurr); - } +# if ($line =~ /\btypedef\s/ && +# $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ && +# $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ && +# $line !~ /\b$typeTypedefs\b/ && +# $line !~ /\b__bitwise(?:__|)\b/) { +# WARN("NEW_TYPEDEFS", +# "do not add new typedefs\n" . $herecurr); +# } # * goes on variable not on type # (char*[ const])