interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

TARGET: fix segfault in handle_dump_image_command() 

The struct fileio is used after fileio_close().
Move fileio_close() after last usage.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
This commit is contained in:
Antonio Borneo 2010-10-12 16:08:35 +08:00 committed by Øyvind Harboe
parent e3773e3e3d
commit 2ee47b22c6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/target/target.c
View File

@ -2643,9 +2643,6 @@ COMMAND_HANDLER(handle_dump_image_command)
address += this_run_size; address += this_run_size;
} }
if ((retvaltemp = fileio_close(&fileio)) != ERROR_OK)
return retvaltemp;
if ((ERROR_OK == retval) && (duration_measure(&bench) == ERROR_OK)) if ((ERROR_OK == retval) && (duration_measure(&bench) == ERROR_OK))
{ {
int filesize; int filesize;
@ -2657,6 +2654,9 @@ COMMAND_HANDLER(handle_dump_image_command)
duration_elapsed(&bench), duration_kbps(&bench, filesize)); duration_elapsed(&bench), duration_kbps(&bench, filesize));
} }
if ((retvaltemp = fileio_close(&fileio)) != ERROR_OK)
return retvaltemp;
return retval; return retval;
} }