From 27d04d42842b31a3eb83de965ba7f3dc0fac3142 Mon Sep 17 00:00:00 2001 From: Antonio Borneo <borneo.antonio@gmail.com> Date: Sun, 29 Mar 2020 23:19:29 +0200 Subject: [PATCH] sysfsgpio: minor fix for bool types Return bool value in functions that return bool. Change return type to bool to function is_gpio_valid(). Change-Id: Ic2e62be737772b22e69881c034956549f659370b Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: http://openocd.zylin.com/5552 Tested-by: jenkins Reviewed-by: Marc Schink <dev@zapb.de> --- src/jtag/drivers/sysfsgpio.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/jtag/drivers/sysfsgpio.c b/src/jtag/drivers/sysfsgpio.c index bf33767c8..c398d5384 100644 --- a/src/jtag/drivers/sysfsgpio.c +++ b/src/jtag/drivers/sysfsgpio.c @@ -61,7 +61,7 @@ * * Assume here that there will be less than 10000 gpios on a system */ -static int is_gpio_valid(int gpio) +static bool is_gpio_valid(int gpio) { return gpio >= 0 && gpio < 10000; } @@ -603,23 +603,23 @@ static void cleanup_all_fds(void) static bool sysfsgpio_jtag_mode_possible(void) { if (!is_gpio_valid(tck_gpio)) - return 0; + return false; if (!is_gpio_valid(tms_gpio)) - return 0; + return false; if (!is_gpio_valid(tdi_gpio)) - return 0; + return false; if (!is_gpio_valid(tdo_gpio)) - return 0; - return 1; + return false; + return true; } static bool sysfsgpio_swd_mode_possible(void) { if (!is_gpio_valid(swclk_gpio)) - return 0; + return false; if (!is_gpio_valid(swdio_gpio)) - return 0; - return 1; + return false; + return true; } static int sysfsgpio_init(void)