interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mpsse: Add missing read buffer checks 

These two unused functions added reads without checking for available
space.

Change-Id: I17dbbe9988b057e5a3a1768f405fc9d1027d1c01
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1500
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
This commit is contained in:
Andreas Fritiofson 2013-07-10 19:22:42 +02:00 committed by Spencer Oliver
parent c979a08144
commit 209e0beed3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/jtag/drivers/mpsse.c
View File

@ -602,7 +602,7 @@ void mpsse_read_data_bits_low_byte(struct mpsse_ctx *ctx, uint8_t *data)
return; return;
} }
if (buffer_write_space(ctx) < 1) if (buffer_write_space(ctx) < 1 || buffer_read_space(ctx) < 1)
ctx->retval = mpsse_flush(ctx); ctx->retval = mpsse_flush(ctx);
buffer_write_byte(ctx, 0x81); buffer_write_byte(ctx, 0x81);
@ -618,7 +618,7 @@ void mpsse_read_data_bits_high_byte(struct mpsse_ctx *ctx, uint8_t *data)
return; return;
} }
if (buffer_write_space(ctx) < 1) if (buffer_write_space(ctx) < 1 || buffer_read_space(ctx) < 1)
ctx->retval = mpsse_flush(ctx); ctx->retval = mpsse_flush(ctx);
buffer_write_byte(ctx, 0x83); buffer_write_byte(ctx, 0x83);