interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

gdb_server,rtos: Differentiate rtos_get_gdb_reg failing and not implemented 

If it fails, then pass that failure on. If it's simply not implemented,
then we can fall through and try target_get_gdb_reg_list_noread().

This difference matters when the target representing the current
hwthread is unavailable, but the target that is linked to the gdb
connection is available. In that case we want the operation to return an
error to gdb, instead of reading the register from the target that is
available.

Change-Id: I9c84ca556f818c5580e25ab349a34a226fcf0f43
Signed-off-by: Tim Newsome <tim@sifive.com>
This commit is contained in:
Tim Newsome 2023-09-14 13:04:39 -07:00
parent b5e57e1894
commit 15f399691e
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/rtos/rtos.c
View File

@ -591,7 +591,7 @@ int rtos_get_gdb_reg(struct connection *connection, int reg_num)
free(reg_list);
}
return ERROR_FAIL;
return ERROR_NOT_IMPLEMENTED;
}
/** Return a list of general registers. */

7
src/server/gdb_server.c
View File

@ -1397,8 +1397,13 @@ static int gdb_get_register_packet(struct connection *connection,
LOG_DEBUG("-");
#endif
if ((target->rtos) && (rtos_get_gdb_reg(connection, reg_num) == ERROR_OK))
if (target->rtos) {
retval = rtos_get_gdb_reg(connection, reg_num);
if (retval == ERROR_OK)
return ERROR_OK;
if (retval != ERROR_NOT_IMPLEMENTED)
return gdb_error(connection, retval);
}
retval = target_get_gdb_reg_list_noread(target, &reg_list, &reg_list_size,
REG_CLASS_ALL);