interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Factoring of jtag_examine_chain for maintainability: 

- Reduce indent: invert logic test for unexpected TAP (no IDs).


git-svn-id: svn://svn.berlios.de/openocd/trunk@2081 b42882b7-edfa-0310-969c-e2dbd0fdcd60
This commit is contained in:
zwelch 2009-06-07 05:22:42 +00:00
parent 32350a5006
commit 15ae1ac678
1 changed files with 39 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/jtag/jtag.c
View File

@ -1058,11 +1058,20 @@ static int jtag_examine_chain(void)
tap->idcode = idcode;
if (tap->expected_ids_cnt > 0) {
if (0 == tap->expected_ids_cnt)
{
// @todo Enable LOG_INFO to ask for reports about unknown TAP IDs.
#if 0
LOG_INFO("Uknown JTAG TAP ID: 0x%08x", tap->idcode)
LOG_INFO("Please report the chip name and reported ID code to the openocd project");
#endif
tap = jtag_tap_next_enabled(tap);
continue;
}
/* Loop over the expected identification codes and test for a match */
u8 ii;
for (ii = 0; ii < tap->expected_ids_cnt; ii++) {
if( tap->idcode == tap->expected_ids[ii] ){
if (tap->idcode == tap->expected_ids[ii]) {
break;
}
}
@ -1090,12 +1099,7 @@ static int jtag_examine_chain(void)
} else {
LOG_INFO("JTAG Tap/device matched");
}
} else {
#if 0
LOG_INFO("JTAG TAP ID: 0x%08x - Unknown - please report (A) chipname and (B) idcode to the openocd project",
tap->idcode);
#endif
}
tap = jtag_tap_next_enabled(tap);
}