interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

server: fix: remove kept_alive() from server loop 

The kept_alive() action is specific of a server that enjoyed an
unscheduled keep_alive and want to communicate it to the keep
alive logic to reschedule next keep_alive().
In server loop we are not expected to call kept_alive().
Remove it!

This call was erroneously added in commit 94e75e0c06.
Later, commit 7442b26d45 properly added the same call in
gdb_put_packet(), but incorrectly left the older in place.

Change-Id: If476410f870eebfbdaccdb1366ba2e9254e2fdf6
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/6836
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
This commit is contained in:
Antonio Borneo 2022-01-30 23:57:38 +01:00
parent be0d68eb66
commit 15a72fa644
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/server/server.c
View File

@ -487,7 +487,6 @@ int server_loop(struct command_context *command_context)
timeout_ms = polling_period; timeout_ms = polling_period;
tv.tv_usec = timeout_ms * 1000; tv.tv_usec = timeout_ms * 1000;
/* Only while we're sleeping we'll let others run */ /* Only while we're sleeping we'll let others run */
kept_alive();
retval = socket_select(fd_max + 1, &read_fds, NULL, NULL, &tv); retval = socket_select(fd_max + 1, &read_fds, NULL, NULL, &tv);
} }