Makefile: drop warning suppression on win build
Commitdcdf71c21b
("- fix signed/unsigned build errors under win32. Thanks Zach Welch <zw@superlucidity.net>") in 2009 prevents gcc warnings on sign/unsigned comparisons while building for Win on folders 'helper' and 'server'. In 2011, commitb69119668e
("RTOS Thread awareness support wip") uses the same method on the new folder 'rtos'. In mean time, all the incorrect sign/unsigned comparisons has been fixed and no warning is present with the default -Wextra flag that implies -Wsign-compare. The comment: # FD_* macros are sloppy with their signs on MinGW32 platform seems linked to some old implementation of MinGW32 include file that doesn't apply on current versions. Remove the obsolete hacks to suppress the warnings. Change-Id: I76dba9e54a647d3b9fbf1b7e9ae1844e3d7adc9a Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/6254 Tested-by: jenkins Reviewed-by: Xiaofan Chen <xiaofanc@gmail.com>
This commit is contained in:
parent
b3a51bbb59
commit
12e2dfd31f
|
@ -30,12 +30,6 @@ noinst_LTLIBRARIES += %D%/libhelper.la
|
|||
%D%/jep106.inc \
|
||||
%D%/jim-nvp.h
|
||||
|
||||
%C%_libhelper_la_CFLAGS = $(AM_CFLAGS)
|
||||
if IS_MINGW
|
||||
# FD_* macros are sloppy with their signs on MinGW32 platform
|
||||
%C%_libhelper_la_CFLAGS += -Wno-sign-compare
|
||||
endif
|
||||
|
||||
STARTUP_TCL_SRCS += %D%/startup.tcl
|
||||
EXTRA_DIST += \
|
||||
%D%/bin2char.sh \
|
||||
|
|
|
@ -31,10 +31,3 @@ noinst_LTLIBRARIES += %D%/librtos.la
|
|||
%D%/rtos_riot_stackings.h \
|
||||
%D%/rtos_ucos_iii_stackings.h \
|
||||
%D%/nuttx_header.h
|
||||
|
||||
%C%_librtos_la_CFLAGS = $(AM_CFLAGS)
|
||||
|
||||
if IS_MINGW
|
||||
# FD_* macros are sloppy with their signs on MinGW32 platform
|
||||
%C%_librtos_la_CFLAGS += -Wno-sign-compare
|
||||
endif
|
||||
|
|
|
@ -14,10 +14,4 @@ noinst_LTLIBRARIES += %D%/libserver.la
|
|||
%D%/ipdbg.c \
|
||||
%D%/ipdbg.h
|
||||
|
||||
%C%_libserver_la_CFLAGS = $(AM_CFLAGS)
|
||||
if IS_MINGW
|
||||
# FD_* macros are sloppy with their signs on MinGW32 platform
|
||||
%C%_libserver_la_CFLAGS += -Wno-sign-compare
|
||||
endif
|
||||
|
||||
STARTUP_TCL_SRCS += %D%/startup.tcl
|
||||
|
|
Loading…
Reference in New Issue