Style changes suggested in review.

Change-Id: I29e83d3dbef09cb971ec0355aff733191a6e4679
Signed-off-by: Tim Newsome <tim@sifive.com>
This commit is contained in:
Tim Newsome 2022-05-06 09:57:14 -07:00
parent ecd736dc53
commit 103c1bc922
1 changed files with 8 additions and 6 deletions

View File

@ -1509,14 +1509,16 @@ typedef enum {
} grouptype_t; } grouptype_t;
static int set_group(struct target *target, bool *supported, unsigned group, grouptype_t grouptype) static int set_group(struct target *target, bool *supported, unsigned group, grouptype_t grouptype)
{ {
uint32_t write = set_field(DM_DMCS2_HGWRITE, DM_DMCS2_GROUP, group); uint32_t write_val = DM_DMCS2_HGWRITE;
write = set_field(write, DM_DMCS2_GROUPTYPE, (grouptype == HALTGROUP) ? 1 : 0); assert(group <= 31);
if (dmi_write(target, DM_DMCS2, write) != ERROR_OK) write_val = set_field(write_val, DM_DMCS2_GROUP, group);
write_val = set_field(write_val, DM_DMCS2_GROUPTYPE, (grouptype == HALTGROUP) ? 1 : 0);
if (dmi_write(target, DM_DMCS2, write_val) != ERROR_OK)
return ERROR_FAIL; return ERROR_FAIL;
uint32_t read; uint32_t read_val;
if (dmi_read(target, &read, DM_DMCS2) != ERROR_OK) if (dmi_read(target, &read_val, DM_DMCS2) != ERROR_OK)
return ERROR_FAIL; return ERROR_FAIL;
*supported = get_field(read, DM_DMCS2_GROUP) == group; *supported = get_field(read_val, DM_DMCS2_GROUP) == group;
return ERROR_OK; return ERROR_OK;
} }