interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

helper/command: silent debug msg on command register/unregister 

Commit e216186fab ("helper/command: register full-name commands
in jim") and commit a7d68878e4 ("helper/command: unregister
commands through their full-name") introduce a LOG_DEBUG() message
each for command registration and unregistration.
The messages above are quite noisy and pollute the log when
debug_level is 3 or higher.
They can be useful to debug the command registration logic, but
for the other debug activities on OpenOCD are just noisy.
Already commit a03ac1ba30 ("helper/command: disable logging of
registered commands [RFC]") was merged to silent the first case
that is now back with additional logs.

Silent both log messages.
Use 'if (false)' to silent them, making easy to re-enable it when
or if someone needs it.

Change-Id: Id8a067e60e822d4ecbddcb036d081298f7e6181f
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/6220
Tested-by: jenkins
This commit is contained in:
Antonio Borneo 2021-05-08 11:02:12 +02:00
parent 909d45e35c
commit 0c5ca348ec
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/helper/command.c
View File

@ -343,7 +343,8 @@ static struct command *register_command(struct command_context *context,
return NULL; return NULL;
} }
LOG_DEBUG("registering '%s'...", full_name); if (false) /* too noisy with debug_level 3 */
LOG_DEBUG("registering '%s'...", full_name);
int retval = Jim_CreateCommand(context->interp, full_name, int retval = Jim_CreateCommand(context->interp, full_name,
jim_command_dispatch, c, command_free); jim_command_dispatch, c, command_free);
if (retval != JIM_OK) { if (retval != JIM_OK) {
@ -441,7 +442,8 @@ int unregister_commands_match(struct command_context *cmd_ctx, const char *forma
Jim_DecrRefCount(interp, elem); Jim_DecrRefCount(interp, elem);
continue; continue;
} }
LOG_DEBUG("delete command \"%s\"", name); if (false) /* too noisy with debug_level 3 */
LOG_DEBUG("delete command \"%s\"", name);
#if JIM_VERSION >= 80 #if JIM_VERSION >= 80
Jim_DeleteCommand(interp, elem); Jim_DeleteCommand(interp, elem);
#else #else