interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

flash/nor/kinetis_ke: fix warning retval set but not used 

I see no reason for not returning error from target_run_algorithm()
to higher level.

Reported by Clang static analyzer.

Change-Id: Iaaa8b66e487ecae88c0cf4ae2addba63341c032c
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/4391
Tested-by: jenkins
Reviewed-by: Ivan Meleca <ivan@artekit.eu>
This commit is contained in:
Tomas Vanek 2018-01-21 10:47:32 +01:00
parent f2b228f5d1
commit 0056037d68
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/flash/nor/kinetis_ke.c
View File

@ -478,14 +478,13 @@ int kinetis_ke_stop_watchdog(struct target *target)
watchdog_algorithm->address, 0, 100000, &armv7m_info); watchdog_algorithm->address, 0, 100000, &armv7m_info);
if (retval != ERROR_OK) { if (retval != ERROR_OK) {
LOG_ERROR("Error executing Kinetis KE watchdog algorithm"); LOG_ERROR("Error executing Kinetis KE watchdog algorithm");
retval = ERROR_FAIL;
} else { } else {
LOG_INFO("Watchdog stopped"); LOG_INFO("Watchdog stopped");
} }
target_free_working_area(target, watchdog_algorithm); target_free_working_area(target, watchdog_algorithm);
return ERROR_OK; return retval;
} }
COMMAND_HANDLER(kinetis_ke_disable_wdog_handler) COMMAND_HANDLER(kinetis_ke_disable_wdog_handler)