2009-04-28 01:29:32 -05:00
|
|
|
Please mail patches to:
|
|
|
|
|
2009-05-21 00:46:29 -05:00
|
|
|
openocd-development@lists.berlios.de
|
2009-04-28 01:29:32 -05:00
|
|
|
|
2009-05-18 12:20:51 -05:00
|
|
|
Note that you can't send patches to that list unless
|
|
|
|
you're a member, despite what the list info page says.
|
|
|
|
|
2009-04-28 01:29:32 -05:00
|
|
|
The patch should be against svn trunk using an SVN
|
2009-05-21 00:46:29 -05:00
|
|
|
diff. If you use git-svn, a git diff or patch is OK
|
|
|
|
too; likewise a quilt patch, if you use quilt.
|
|
|
|
|
|
|
|
It should be a "good patch": focus it on a single
|
|
|
|
issue, and make it be easily reviewable. Don't make
|
|
|
|
it so large that it's hard to review; split large
|
|
|
|
patches into smaller ones. (That can also help
|
|
|
|
track down bugs later on.) All patches should
|
|
|
|
be "clean", which includes preserving the existing
|
|
|
|
coding style and updating documentation as needed.j
|
2009-04-28 01:29:32 -05:00
|
|
|
|
|
|
|
Attach the patch to the email as a .txt file and
|
|
|
|
also write a short change log entry that maintainers
|
|
|
|
can copy and paste into the commit message
|
|
|
|
|
2009-05-21 00:46:29 -05:00
|
|
|
Say if it's a bugfix (describe the bug) or a new
|
|
|
|
feature. Don't expect patches to merge immediately
|
|
|
|
for the next release. Be ready to rework patches
|
|
|
|
in response to feedback.
|
2009-05-18 12:20:51 -05:00
|
|
|
|
2009-04-28 01:29:32 -05:00
|
|
|
Add yourself to the GPL copyright for non-trivial changes.
|
|
|
|
|
|
|
|
To create a patch from the command line:
|
|
|
|
|
2009-05-21 00:46:29 -05:00
|
|
|
svn diff >mypatch.txt
|
2009-04-28 01:29:32 -05:00
|
|
|
|
2009-05-21 00:46:29 -05:00
|
|
|
See:
|
2009-04-28 01:29:32 -05:00
|
|
|
|
2009-05-21 00:46:29 -05:00
|
|
|
http://svnbook.red-bean.com/en/1.0/re09.html
|
2009-04-28 01:29:32 -05:00
|
|
|
|
2009-05-21 00:46:29 -05:00
|
|
|
NB! remember to use "svn add" on new files first!
|
2009-04-28 01:29:32 -05:00
|
|
|
|
2009-05-21 00:46:29 -05:00
|
|
|
http://svnbook.red-bean.com/en/1.0/re01.html
|
2009-04-28 01:29:32 -05:00
|
|
|
|
|
|
|
If you have a decent SVN GUI, then that should be
|
|
|
|
able to create and apply patches as well...
|
2009-05-21 00:46:29 -05:00
|
|
|
|