Commit Graph

37 Commits

Author SHA1 Message Date
Kevin Wojniak 49e17cbfd7 Fix "attempt to destroy map with items inside" when menuManager is deallocated
Fixes #58. The map needs to have its contents properly freed which requires releasing the properly retaining the NSMenuItem object.
2016-05-23 21:41:52 -07:00
Kevin Wojniak 2ebb9052cc Fix crash when closing program on OS X
This fixes #14. Autorelease pools need to be used to make sure objects get properly released. Unfortunately this produces a new error when menuManager gets deallocated, which I am looking at fixing:

map.m:25:mapDestroy() POSSIBLE IMPLEMENTATION BUG; CONTACT ANDLABS:
attempt to destroy map with items inside
2016-05-23 21:09:46 -07:00
Pietro Gagliardi d52c92d2f8 Cleaned out complain()s in the OS X backend. Affects everything *except* drawtext.m, which will need its own migration. 2016-05-13 20:14:46 -04:00
Pietro Gagliardi b6c54aac43 Fixed build errors. Let's test! 2016-04-24 16:14:19 -04:00
Pietro Gagliardi ded1ee6997 Removed typed stuff from darwin/menu.m. Now let's try building it. 2016-04-24 16:07:45 -04:00
Pietro Gagliardi 499a93e32e Completely rewrote the OS X map system to use NSMapTable correctly and hide the details behind more wrapper functions to prevent further mass rewrites; this fixes most of the crashing issues on OS X. The one with package ui still stands... 2016-01-07 14:41:20 -05:00
Pietro Gagliardi 54332b90fb Finally merged out the redo folder. 2015-09-02 13:48:06 -04:00
Pietro Gagliardi ed9e70c058 Started redoing the OS X port. 2015-07-02 16:09:57 -04:00
Pietro Gagliardi e1e9dddfdd Fixed some more warnings on the OS X backend. This also introduces realNSApp() and makes applicationClass global, which is important for fixing a few other TODOs (the setAppleMenu: one, for instance). 2015-05-10 14:27:25 -04:00
Pietro Gagliardi ce96272f03 Fixed a bunch of warnings on the OS X backend. 2015-05-10 14:21:35 -04:00
Pietro Gagliardi 8032c24f74 Implemented the should quit logic on Mac OS X. The actual new quitting logic isn't in yet; that will wait for tests. 2015-05-09 10:05:24 -04:00
Pietro Gagliardi 86a4b0a7ba More expository comments and TODOs. 2015-05-08 20:34:57 -04:00
Pietro Gagliardi f47c8172e1 Implemented uninitMenus() on Mac OS X. 2015-05-08 20:31:19 -04:00
Pietro Gagliardi 2ec8fb8589 Fixed a typo. 2015-05-08 20:24:53 -04:00
Pietro Gagliardi ada7608c14 Added menu tracking to the OS X backend. This is needed for uninitMenus(). 2015-05-08 19:33:51 -04:00
Pietro Gagliardi cc1491d1a7 More TODOs. 2015-05-08 18:02:02 -04:00
Pietro Gagliardi b9597028fb Moved some OS X TODOs to the long-term list. 2015-05-04 17:33:05 -04:00
Pietro Gagliardi 4ba0f795eb Switched from manually enabling menu items on OS X to automatic enabling, just like with the application menu. Same code :/ Also cleaned up useless [NSMenuItem setEnabled:] calls. 2015-05-03 21:37:45 -04:00
Pietro Gagliardi 82312861e9 Implemented menu finalization on OS X. 2015-05-03 21:28:21 -04:00
Pietro Gagliardi d25c954d9f Added code to get the active window for menu events on Mac OS X. Will test next. 2015-05-03 21:05:55 -04:00
Pietro Gagliardi 511cc76ef8 Investigated setAppleMenu:; decided to save it for later. 2015-05-03 16:28:46 -04:00
Pietro Gagliardi 2a6da36542 Finished the OS X menu disabling code. 2015-05-03 02:45:59 -04:00
Pietro Gagliardi 810e2225ea Started writing code for proper Quit/Preferences/About enabling and disabling on Mac OS X. 2015-05-02 23:04:37 -04:00
Pietro Gagliardi c89b473c76 Added the Services menu to the OS X application menu. 2015-05-02 11:11:13 -04:00
Pietro Gagliardi f86d312c74 Verified action signatures in darwin/menu.; thanks to mikeash in irc.freenode.net/#macdev for confirming. 2015-05-01 10:31:56 -04:00
Pietro Gagliardi 442907ad64 Implemented menu uniqueness checks on OS X. More TODOs. 2015-04-30 23:24:52 -04:00
Pietro Gagliardi 8b74c2fb92 Removed a duplicate TODO. 2015-04-30 22:46:24 -04:00
Pietro Gagliardi 4035aee115 Marked a TODO in darwin/menu.m as resolved; we were already doing it properly. 2015-04-30 18:02:21 -04:00
Pietro Gagliardi c6023ee151 Some TODO resolution and changes. 2015-04-30 15:08:03 -04:00
Pietro Gagliardi c8695e4ca2 Decided to remove allocation logging. Leak checking can be done with dedicated tools. 2015-04-30 13:37:13 -04:00
Pietro Gagliardi 6c6bce3702 Moved everything back to the top level. 2015-04-29 11:02:38 -04:00
Pietro Gagliardi 4c280ca42c Removed or moved a bunch of stale files from the old source. All that's left now is to re-add the main controls and recreate the test program. 2015-04-29 10:20:25 -04:00
Pietro Gagliardi 855bca9b0c Started the stub menu code. 2015-04-28 14:17:28 -04:00
Pietro Gagliardi 2f1a806a31 More TODOs. 2015-04-21 18:10:48 -04:00
Pietro Gagliardi de3c1cc0ea Implemented the standard application menu on the Mac OS X backend. 2015-04-21 18:09:12 -04:00
Pietro Gagliardi e26257006f Converted the OS X menu code to the changes in the past few commits and made a few other small changes. 2015-04-21 00:46:30 -04:00
Pietro Gagliardi b258e1fc82 Began implementing menus on Mac OS X. 2015-04-20 22:34:31 -04:00