Commit Graph

731 Commits

Author SHA1 Message Date
Pietro Gagliardi e098cb5585 More TODOs 2018-08-29 20:36:18 -04:00
Pietro Gagliardi f065abedd7 Fixed the uiImage implemenation on OS X. Even though libui won't be running on a big-endian Mac any time soon, I still want to test that code on one to make sure it's correct. 2018-08-29 20:32:12 -04:00
Pietro Gagliardi 9120d6b93f Continuation of previous commit. 2018-08-09 05:08:38 -04:00
Pietro Gagliardi 5d959e5cbc
Merge pull request #387 from mischnic/area-scroll
"Fix area setSize macOS"

I forgot to change this when I made scrollview.m not use Auto Layout. Oops.
2018-08-09 05:07:01 -04:00
Pietro Gagliardi 52bd45bb09 More TODOs. Update #395 2018-08-09 04:54:49 -04:00
Niklas Mischkulnig 68dade3e81
Rename loop variable 2018-08-06 10:54:19 +02:00
Niklas Mischkulnig c0742d3de0
Mac uiImageAppend: handle stride correctly 2018-08-06 09:28:25 +02:00
Pietro Gagliardi e0ca00e55b Resolved confusion about the terminology of strides in uiImageAppend(). Also prevents overallocation on some platforms. Thanks to @mischnic and @msink for spotting this. Update #402. 2018-08-05 18:39:29 -04:00
Pietro Gagliardi 4eaf01f840 Fix double-free spotted by @mischnic in #402. 2018-07-29 13:25:53 -04:00
Pietro Gagliardi a37fdadbd7 Implemented uiControlDestroy() for uiTable on OS X. 2018-07-08 21:22:55 -04:00
Pietro Gagliardi 095e63d522 Fixed memory leaks in the tester and a symbol name flub in OS X's image.m. 2018-07-08 21:20:42 -04:00
Pietro Gagliardi 1700c0ccea Reworded a TODO. 2018-07-08 21:13:19 -04:00
Pietro Gagliardi bd685f24f9 Removed a stale TODO; added more TODOs. 2018-06-24 14:48:09 -04:00
Pietro Gagliardi 4ed6e3ec8a Minor TODO resolution. 2018-06-24 14:46:24 -04:00
Pietro Gagliardi f3882d6124 Cleaned up color access across platforms. 2018-06-24 14:22:05 -04:00
Pietro Gagliardi acb40964f3 Deduplicated editable logic across platforms. 2018-06-24 11:41:19 -04:00
Pietro Gagliardi fb67c429d8 Made background color columns only settable at creation time; added a uiTableParams struct for the purpose. This should end edits to uitable.h for now (until we're ready to document it). Now to just clean up all the implementations. 2018-06-24 10:28:41 -04:00
Pietro Gagliardi 72c7c05f04 Fixed up AddColumn parameter and private fields names; made them consistent. 2018-06-24 09:52:01 -04:00
Pietro Gagliardi 4dbf1994a6 Deduplicated the default text column parameters across platforms. 2018-06-24 00:45:54 -04:00
Pietro Gagliardi 9b340ed40c Fixed checkboxes on Mac OS X. 2018-06-23 23:48:47 -04:00
Pietro Gagliardi 8f4598f641 Finally removed the extra uiImage declarations that were there for long-irrelevant compiler errors. 2018-06-23 23:45:58 -04:00
Pietro Gagliardi 74ec21f4c7 Turned the direct method calls on uiTableModel into functions to make the call sites look a bit cleaner. More stuff will go into common/tablemodel.c... 2018-06-23 23:35:42 -04:00
Pietro Gagliardi 9a79eed2ac Final cleanup, first part: renamed uiTableData to uiTableValue. 2018-06-23 20:19:30 -04:00
Pietro Gagliardi 7a5577db94 Deleted now-irrelevant code from OLD_table.m. 2018-06-04 23:28:46 -04:00
Pietro Gagliardi 3c063c71d5 And one more TODO before we move on. 2018-06-04 22:15:05 -04:00
Pietro Gagliardi 0a6a781be7 And implemented row background colors and button clicks. OS X implementation done for now! 2018-06-04 22:14:05 -04:00
Pietro Gagliardi 3fa15d5277 Fixed graphical glitches in the OS X Table. Finally. SOMEHOW. 2018-06-04 20:17:15 -04:00
Pietro Gagliardi 71e02a5c6e And set up the constraints for the other column types. 2018-06-04 20:09:09 -04:00
Pietro Gagliardi 8a0ca54e93 Fixed constraint issues in tablecolumn.m for text-containing columns. I guess that one constraint function needs to go... 2018-06-04 20:03:05 -04:00
Pietro Gagliardi 2cfbb0144e Fixed segfaults. Now to fix logic errors. (Technically one of the two changes here is a logic error too.) 2018-06-04 18:17:05 -04:00
Pietro Gagliardi 2b428d50f6 And fixed build errors. Now I just need to rewrite the tester and try this out... 2018-06-03 23:06:44 -04:00
Pietro Gagliardi 8fc4a9aaf5 Filled in the rest of tablecolumn.m: wrote the NSTableColumn subclasses and implemented the public functions. Let's build and see what breaks! 2018-06-03 22:37:36 -04:00
Pietro Gagliardi 6457e1668f Rewrote uiTableModelRowChanged() to properly update rows. We can do this now that we have the setup for row updates and reuse, but this is better than calling reloadData anyway (and reloadData doesn't update the row view, but we (almost) do, so...)... 2018-06-03 21:39:49 -04:00
Pietro Gagliardi 247d63be60 Added a table.h and simplified uiprivTableColumn into an abstract interface. 2018-06-03 20:55:08 -04:00
Pietro Gagliardi da2a4c1e36 Started building back the uiTable implementation. 2018-06-03 19:59:05 -04:00
Pietro Gagliardi 8ee5c61fe8 And added button columns. Now to start writing the rest of the uiTable glue. 2018-06-03 19:21:01 -04:00
Pietro Gagliardi b74b987fff Added progressbar columns. 2018-06-03 18:34:29 -04:00
Pietro Gagliardi c04f3d3fbe Adjusted tablecolumn.m to use the new data functions. 2018-06-03 17:39:02 -04:00
Pietro Gagliardi 9c519f1bfa Added checkboxes and consolidated all the columns with or without text. Progressbars and buttons will be separate object types. I do need to redo the data-passing method, and now that there's uiAttribute I can just model a better one off that. 2018-06-03 16:50:35 -04:00
Pietro Gagliardi d1b7d14a82 Added image columns. 2018-06-03 14:13:32 -04:00
Pietro Gagliardi 5d57666764 Started writing the new table column code on OS X. This new code will take full advantage of NSTableView features like the reuse cache. Right now we just have the boilerplate for text-only columns. 2018-06-03 13:28:42 -04:00
Niklas Mischkulnig 3e5f4b3674 Fix area setSize macOS 2018-06-01 15:45:55 +02:00
Pietro Gagliardi 7911ed0e81 Merge branch 'master' into table 2018-05-31 08:21:21 -04:00
Niklas Mischkulnig 1b4c898a0c Fix datetimepicker crash 2018-05-31 13:03:19 +02:00
Pietro Gagliardi 31090442be Merge branch 'master' into table 2018-05-13 18:05:50 -04:00
Pietro Gagliardi 02fc3e267e And fixed on OS X too. IIRC I handled it on Windows in a prior commit. 2018-05-13 18:04:57 -04:00
Pietro Gagliardi 9dad806693 Merge branch 'master' into table 2018-05-13 12:05:43 -04:00
Pietro Gagliardi ca1079f344 Cleaned up from the previous merge and added it to the README. 2018-05-13 12:05:09 -04:00
cody271 fd3b693ffe uiDateTimePicker Use more 'uipriv' on OS X 2018-05-12 21:40:47 -07:00
cody271 9aba97714d uiDateTimePicker Add comments 2018-05-12 21:35:07 -07:00