More TODO resolution and pointless TODO elimination.
This commit is contained in:
parent
f6e9da916a
commit
cca4db5ce9
|
@ -129,7 +129,7 @@ _UI_ENUM(uiAttribute) {
|
|||
// 9 = inverted box
|
||||
// 10 = inverted rounded box
|
||||
// TODO rename to AnnotatedForms?
|
||||
uiAttributeGlyphAnnotations, // an integer from 0 to a font-specified upper bound
|
||||
uiAttributeAnnotatedGlyphForms, // an integer from 0 to a font-specified upper bound
|
||||
// TODO provide a function to get the upper bound?
|
||||
|
||||
// TODO kKanaSpacingType
|
||||
|
|
|
@ -144,7 +144,7 @@ void specToOpenType(uiAttributeSpec *spec, specToOpenTypeEnumFunc f, void *data)
|
|||
case uiAttributeHanjaToHangul:
|
||||
boolspec(spec, "hngl", f, data);
|
||||
return;
|
||||
case uiAttributeGlyphAnnotations:
|
||||
case uiAttributeAnnotatedGlyphForms:
|
||||
(*f)("nalt", (uint32_t) (spec->Value), data);
|
||||
return;
|
||||
case uiAttributeRubyKanaForms:
|
||||
|
|
|
@ -162,7 +162,7 @@ int specToAAT(uiAttributeSpec *spec, specToAATEnumFunc f, void *data)
|
|||
if (spec->Value != 0)
|
||||
(*f)(kTransliterationType, kHanjaToHangulSelector, data);
|
||||
return 1;
|
||||
case uiAttributeGlyphAnnotations:
|
||||
case uiAttributeAnnotatedGlyphForms:
|
||||
(*f)(kAnnotationType, (uint16_t) (spec->Value), data);
|
||||
return 1;
|
||||
case uiAttributeRubyKanaForms:
|
||||
|
|
|
@ -483,21 +483,21 @@ static void setupAttributedString(void)
|
|||
start = uiAttributedStringLen(attrstr);
|
||||
end = start + strlen(next);
|
||||
uiAttributedStringAppendUnattributed(attrstr, next);
|
||||
spec.Type = uiAttributeGlyphAnnotations;
|
||||
spec.Type = uiAttributeAnnotatedGlyphForms;
|
||||
spec.Value = 0;
|
||||
uiAttributedStringSetAttribute(attrstr, &spec, start, end);
|
||||
uiAttributedStringAppendUnattributed(attrstr, " vs. ");
|
||||
start = uiAttributedStringLen(attrstr);
|
||||
end = start + strlen(next);
|
||||
uiAttributedStringAppendUnattributed(attrstr, next);
|
||||
spec.Type = uiAttributeGlyphAnnotations;
|
||||
spec.Type = uiAttributeAnnotatedGlyphForms;
|
||||
spec.Value = 1;
|
||||
uiAttributedStringSetAttribute(attrstr, &spec, start, end);
|
||||
uiAttributedStringAppendUnattributed(attrstr, " vs. ");
|
||||
start = uiAttributedStringLen(attrstr);
|
||||
end = start + strlen(next);
|
||||
uiAttributedStringAppendUnattributed(attrstr, next);
|
||||
spec.Type = uiAttributeGlyphAnnotations;
|
||||
spec.Type = uiAttributeAnnotatedGlyphForms;
|
||||
spec.Value = 4; // AAT inverted circle
|
||||
uiAttributedStringSetAttribute(attrstr, &spec, start, end);
|
||||
uiAttributedStringAppendUnattributed(attrstr, ")");
|
||||
|
|
|
@ -29,7 +29,7 @@ _UI_ENUM(uiAttribute) {
|
|||
uiAttributeBackground, // use R, G, B, A
|
||||
|
||||
uiAttributeUnderline, // enum uiDrawUnderlineStyle
|
||||
// TODO ensure the color in the case we don't specify it is the text color?
|
||||
// TODO document that the color in the case we don't specify it is the text color
|
||||
uiAttributeUnderlineColor, // enum uiDrawUnderlineColor
|
||||
|
||||
// These attributes represent typographic features. Each feature
|
||||
|
@ -85,7 +85,6 @@ _UI_ENUM(uiAttribute) {
|
|||
// following values:
|
||||
// 0 = none
|
||||
// OpenType calls this "access all alternates".
|
||||
// TODO doesn't OpenType do the same about 0?
|
||||
uiAttributeSpecificCharacterForm, // an integer from 0 to a font-specified upper bound
|
||||
// TODO provide a function to get the upper bound?
|
||||
|
||||
|
@ -111,8 +110,7 @@ _UI_ENUM(uiAttribute) {
|
|||
// 8 = diamond
|
||||
// 9 = inverted box
|
||||
// 10 = inverted rounded box
|
||||
// TODO rename to AnnotatedForms?
|
||||
uiAttributeGlyphAnnotations, // an integer from 0 to a font-specified upper bound
|
||||
uiAttributeAnnotatedGlyphForms, // an integer from 0 to a font-specified upper bound
|
||||
// TODO provide a function to get the upper bound?
|
||||
|
||||
uiAttributeRubyKanaForms, // 0 = off, 1 = on
|
||||
|
|
Loading…
Reference in New Issue