From bf58601ff8ab6468ef8a0dfe62bcc1505a83ab41 Mon Sep 17 00:00:00 2001 From: Pietro Gagliardi Date: Mon, 5 Mar 2018 23:16:43 -0500 Subject: [PATCH] More TODOs. --- darwin/attrstr.m | 1 + 1 file changed, 1 insertion(+) diff --git a/darwin/attrstr.m b/darwin/attrstr.m index e2a53e0d..6d443648 100644 --- a/darwin/attrstr.m +++ b/darwin/attrstr.m @@ -72,6 +72,7 @@ struct foreachParams { // instead of incrementally adjusting CTFontRefs (which, judging from NSFontManager, seems finicky and UI-centric), we use a custom class to incrementally store attributes that go into a CTFontRef, and then convert everything to CTFonts en masse later // https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/AttributedStrings/Tasks/ChangingAttrStrings.html#//apple_ref/doc/uid/20000162-BBCBGCDG says we must have -hash and -isEqual: workign properly for this to work, so we must do that too, using a basic xor-based hash and leveraging Cocoa -hash implementations where useful and feasible (if not necessary) // TODO structure and rewrite this part +// TODO re-find sources proving support of custom attributes // TODO what if this is NULL? static const CFStringRef combinedFontAttrName = CFSTR("libuiCombinedFontAttribute");