interesting
/
libui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix #416, uiTableModelRowInserted on windows adds 2 rows instead of 1. 

When LVM_INSERTITEM is called after we updated LVM_SETITEMCOUNT,
the actual count will be increased by one causing one extra item
to appear in the table and loading data from the model.
This extra item is invisible at first because it doesn't get painted but
you can click on it to confirm that it is actually there.

To fix this problem we need to call INSERTITEM first and
then update the ITEMCOUNT.

Fixes #416
Fixes andlabs/ui#369

cc @bcampbell
r? @andlabs
This commit is contained in:
Vadzim Dambrouski 2020-02-05 22:26:23 +03:00
parent a0a980712e
commit b2946761fc
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
windows/table.cpp
View File

@ -36,16 +36,16 @@ void uiTableModelRowInserted(uiTableModel *m, int newIndex)
item.iItem = newIndex;
item.iSubItem = 0;
for (auto t : *(m->tables)) {
// update selection state
if (SendMessageW(t->hwnd, LVM_INSERTITEM, 0, (LPARAM) (&item)) == (LRESULT) (-1))
logLastError(L"error calling LVM_INSERTITEM in uiTableModelRowInserted() to update selection state");
// actually insert the rows
if (SendMessageW(t->hwnd, LVM_SETITEMCOUNT, (WPARAM) newCount, LVSICF_NOINVALIDATEALL) == 0)
logLastError(L"error calling LVM_SETITEMCOUNT in uiTableModelRowInserted()");
// and redraw every row from the new row down to simulate adding it
if (SendMessageW(t->hwnd, LVM_REDRAWITEMS, (WPARAM) newIndex, (LPARAM) (newCount - 1)) == FALSE)
logLastError(L"error calling LVM_REDRAWITEMS in uiTableModelRowInserted()");
// update selection state
if (SendMessageW(t->hwnd, LVM_INSERTITEM, 0, (LPARAM) (&item)) == (LRESULT) (-1))
logLastError(L"error calling LVM_INSERTITEM in uiTableModelRowInserted() to update selection state");
}
}