interesting
/
libui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

More OS X 10.7 fixes and TODOs.

This commit is contained in:
Pietro Gagliardi 2016-05-21 11:28:11 -04:00
parent 2c0e333ca0
commit 7b04d974ac
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
darwin/colorbutton.m
View File

@ -87,7 +87,6 @@ struct uiColorButton {
CGFloat cr, cg, cb, ca; CGFloat cr, cg, cb, ca;
// the given color may not be an RGBA color, which will cause the -getRed:green:blue:alpha: call to throw an exception // the given color may not be an RGBA color, which will cause the -getRed:green:blue:alpha: call to throw an exception
// TODO device RGB space?
rgba = [[self color] colorUsingColorSpaceName:NSCalibratedRGBColorSpace]; rgba = [[self color] colorUsingColorSpaceName:NSCalibratedRGBColorSpace];
[rgba getRed:&cr green:&cg blue:&cb alpha:&ca]; [rgba getRed:&cr green:&cg blue:&cb alpha:&ca];
*r = cr; *r = cr;
@ -100,7 +99,7 @@ struct uiColorButton {
- (void)libuiSetColor:(double)r g:(double)g b:(double)b a:(double)a - (void)libuiSetColor:(double)r g:(double)g b:(double)b a:(double)a
{ {
// TODO does this set the panel color? does it send a signal? // TODO does this set the panel color? does it send a signal?
[self setColor:[NSColor colorWithRed:r green:g blue:b alpha:a]]; [self setColor:[NSColor colorWithSRGBRed:r green:g blue:b alpha:a]];
} }
@end @end

2
darwin/radiobuttons.m
View File

@ -4,7 +4,7 @@
// In the old days you would use a NSMatrix for this; as of OS X 10.8 this was deprecated and now you need just a bunch of NSButtons with the same superview AND same action method. // In the old days you would use a NSMatrix for this; as of OS X 10.8 this was deprecated and now you need just a bunch of NSButtons with the same superview AND same action method.
// This is documented on the NSMatrix page, but the rest of the OS X documentation says to still use NSMatrix. // This is documented on the NSMatrix page, but the rest of the OS X documentation says to still use NSMatrix.
// NSMatrix has weird quirks anyway... // NSMatrix has weird quirks anyway...
// TODO verify this works on 10.7. // TODO this does not work on 10.7
// TODO // TODO
// - check that multiple radio buttons on the same parent container work right // - check that multiple radio buttons on the same parent container work right